Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 275923 - sys-fs/e2fsprogs-1.41.7: executing findfs starts tune2fs instead when --disable-libblkid
Summary: sys-fs/e2fsprogs-1.41.7: executing findfs starts tune2fs instead when --disab...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Core system (show other bugs)
Hardware: All Linux
: High major (vote)
Assignee: Gentoo's Team for Core System packages
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-06-30 10:56 UTC by Bernhard Hartleb
Modified: 2009-07-04 13:37 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Bernhard Hartleb 2009-06-30 10:56:38 UTC
After an upgrade to sys-fs/e2fsprogs-1.41.6-r1 findfs does not work anymore.
It prints the tune2fs help instead of the usual findfs output.

Using version sys-fs/e2fsprogs-1.41.3-r1, findfs works as expected.

Reproducible: Always

Steps to Reproduce:
1. emerge -1 sys-fs/e2fsprogs-1.41.6-r1
2. /sbin/findfs

Actual Results:  
console output:
tune2fs 1.41.6 (30-May-2009)
Usage: findfs [-c max_mounts_count] [-e errors_behavior] [-g group]
        [-i interval[d|m|w]] [-j] [-J journal_options] [-l]
        [-m reserved_blocks_percent] [-o [^]mount_options[,...]]
        [-r reserved_blocks_count] [-u user] [-C mount_count] [-L volume_label]
        [-M last_mounted_dir] [-O [^]feature[,...]]
        [-E extended-option[,...]] [-T last_check_time] [-U UUID]
        [ -I new_inode_size ] device

Expected Results:  
console output:
Usage: findfs LABEL=<label>|UUID=<uuid>
Comment 1 Bernhard Hartleb 2009-07-01 17:47:38 UTC
This bug still exists in sys-fs/e2fsprogs-1.41.7
Comment 2 Matthias Schwarzott gentoo-dev 2009-07-03 09:43:48 UTC
Same result here with e2fsprogs-1.41.7
Comment 3 Matthias Schwarzott gentoo-dev 2009-07-03 10:40:28 UTC
It seems the configure script defines the needed CONFIG_BUILD_FINDFS only when enabling libblkid.
So the code in the ebuild to enable findfs either needs to change configure to define it, or we just inject it into CPPFLAGS.
Comment 4 SpanKY gentoo-dev 2009-07-03 18:42:51 UTC
Ted: considering everyone is moving to the blkid in util-linux rather than e2fsprogs, seems that everyone will have a broken findfs installed ...
Comment 5 Bernhard Hartleb 2009-07-03 19:12:58 UTC
So how can this be fixed?

I think the findfs code is already in util-linux,
could there be a way to enable and build it with util-linux?

I noticed that other distributions already use the version in there.
Unfortunately I don't know how this could work in Gentoo.

Thank you.
Comment 6 SpanKY gentoo-dev 2009-07-03 19:23:11 UTC
oh, i didnt realize findfs had moved to util-linux as well.  nothing for Ted to look at then.
Comment 7 SpanKY gentoo-dev 2009-07-03 19:25:04 UTC
looks like Robin's hack to 1.41.6-r1 wasnt complete.  we'll probably need to inject the CPPFLAGS too like Matthias said.
Comment 8 SpanKY gentoo-dev 2009-07-03 19:35:39 UTC
added the CPPFLAGS hack to 1.41.7-r1
Comment 9 Theodore Tso 2009-07-04 12:42:52 UTC
This is a version skew between e2fsprogs and util-linux-ng.   Sounds like Gentoo is using an older version of util-linux-ng that doesn't provide findfs.   I don't consider the blkid handoff to util-linux-ng to be complete yet in terms of being BugFree(tm) yet.   Gentoo rushing in where other distros fear to trend is great for exposing these bugs, although in this case this is a bug in util-linux-bg.  :-)
Comment 10 Theodore Tso 2009-07-04 12:55:41 UTC
One more thought.   At least in the e2fsprogs makefile, findfs is installed as a hard link to tune2fs.   With --disable-findfs, findfs isn't installed any more.   So either Gentoo in its packaging is unconditionally installing findfs as a hardlink to tune2fs, OR it is installing findfs as a symlink to tune2fs.
It might be worth checking to see what is going on here.
Comment 11 Matthias Schwarzott gentoo-dev 2009-07-04 13:37:52 UTC
(In reply to comment #9)
> This is a version skew between e2fsprogs and util-linux-ng.   Sounds like
> Gentoo is using an older version of util-linux-ng that doesn't provide findfs. 
For all to work nice without dependency cicles and other strange stuff, we need to use not yet avail util-linux-2.16.

But: This bug was about findfs in e2fsprogs not working correct.
Using the util-linux-ng version does work fine.
See Bug #269378 for discussion of all issues related to this move.