Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 275051 - net-im/pidgin-2.5.7 uses broken po/Makefile.in.in from intltool-0.40.6
Summary: net-im/pidgin-2.5.7 uses broken po/Makefile.in.in from intltool-0.40.6
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Gentoo Net-im project
URL: http://developer.pidgin.im/ticket/9520
Whiteboard:
Keywords:
: 275384 (view as bug list)
Depends on:
Blocks:
 
Reported: 2009-06-22 13:23 UTC by Juanlu Pérez
Modified: 2009-06-29 16:31 UTC (History)
9 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Fix + LINGUAS support (2.5.7-linguas.patch,1.25 KB, patch)
2009-06-25 15:42 UTC, Denis Kaganovich
Details | Diff
pidgin-2.5.7.ebuild.diff (pidgin-2.5.7.ebuild.diff,860 bytes, patch)
2009-06-25 16:30 UTC, Lars Wendler (Polynomial-C) (RETIRED)
Details | Diff
simper pidgin-2.5.7.ebuild.diff (pidgin-2.5.7.ebuild.diff,309 bytes, patch)
2009-06-25 16:40 UTC, Marco Leogrande
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Juanlu Pérez 2009-06-22 13:23:30 UTC
Pidgin should be localized in Spanish like it previously was, but it is in English.

Reproducible: Always

Steps to Reproduce:
1.emerge =pidgin-2.5.7
2.
3.

Actual Results:  
Showed in English

Expected Results:  
To be showed in Spanish
Comment 1 ScytheMan 2009-06-22 15:48:16 UTC
I can confirm this bug for German localization. 
Comment 2 Lars Wendler (Polynomial-C) (RETIRED) gentoo-dev 2009-06-22 15:55:50 UTC
This is another bug caused by the broken Makefile.in.in file from intltool-0.40.6 (see bug #264114). Running 

  intltoolize --force --copy --automake

in src_prepare() should fix this problem.
Comment 3 Marco Leogrande 2009-06-22 18:33:47 UTC
Perhaps a simple
   sed "s:'\^\$\$lang\$\$':\^\$\$lang\$\$:g" -i po/Makefile.in.in || die "sed failed"
would suffice, trying right now.
Comment 4 Marco Leogrande 2009-06-22 19:16:29 UTC
Ok, I can confirm that adding that sed substitution as the last line in src_prepare() solves the problem for me.
Comment 5 Hanno Zysik (geki) 2009-06-25 10:46:37 UTC
Hmm, I have intltool-0.40.5 and still no localization. :)
Glad to see the sed fix does the job.

# emerge -pv intltool

These are the packages that would be merged, in order:

Calculating dependencies... done!
[ebuild   R   ] dev-util/intltool-0.40.5  138 kB

Total: 1 package (1 reinstall), Size of downloads: 138 kB
Comment 6 Marco Leogrande 2009-06-25 11:09:51 UTC
@h.mth
This bug is not about the dev-util/intltool version you've installed on your system (I have 0.40.5 too), but the one of the package that was installed on the package author's machine. 0.40.6 is known to be broken in generating po/Makefile.in.in files, so the source tarballs must be manually patched to restore locale selection (the sed substitution is a standard one, I borrowed it from another ebuild ;) ).
Comment 7 Lars Wendler (Polynomial-C) (RETIRED) gentoo-dev 2009-06-25 14:11:29 UTC
*** Bug 275384 has been marked as a duplicate of this bug. ***
Comment 8 Denis Kaganovich 2009-06-25 15:42:55 UTC
Created attachment 195752 [details, diff]
Fix + LINGUAS support

Simple way: just add "unset LINGUAS"  before econf (Bug 275384 https://bugs.gentoo.org/attachment.cgi?id=195746&action=view). Current attachment adding LINGUAS support to selective locales.
Comment 9 Lars Wendler (Polynomial-C) (RETIRED) gentoo-dev 2009-06-25 16:30:32 UTC
Created attachment 195761 [details, diff]
pidgin-2.5.7.ebuild.diff

The proper fix should be similar to the one done for dev-util/geany-0.17 (bug #268810). See http://sources.gentoo.org/viewcvs.py/gentoo-x86/dev-util/geany/geany-0.17.ebuild?r1=1.1&r2=1.2 for reference.
Comment 10 Marco Leogrande 2009-06-25 16:40:26 UTC
Created attachment 195762 [details, diff]
simper pidgin-2.5.7.ebuild.diff

I'd rather say that the patch is even simpler :)
Comment 11 Denis Kaganovich 2009-06-25 18:41:13 UTC
;) Yes, this is better. I was think all locales installed by default. Not verify now, may be 2.5.6 only, may be no.
Comment 12 Balazs Nemeth 2009-06-29 08:46:15 UTC
(In reply to comment #10)
> Created an attachment (id=195762) [edit]
> simper pidgin-2.5.7.ebuild.diff
> 
> I'd rather say that the patch is even simpler :)
> 

works for me. thx!
Comment 13 Juanlu Pérez 2009-06-29 10:18:35 UTC
Appling your patch worked for me.

Thanks.

(In reply to comment #10)
> Created an attachment (id=195762) [edit]
> simper pidgin-2.5.7.ebuild.diff
> 
> I'd rather say that the patch is even simpler :)
> 

Comment 14 Olivier Crete (RETIRED) gentoo-dev 2009-06-29 16:31:12 UTC
I added the sed line to the ebuild, hopefully they'll use a non-buggy version next time.