Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 274934 - net-dialup/ppp-2.4.4-r22[mppe-mppc]: sed command targets ppp instead of ppp.conf
Summary: net-dialup/ppp-2.4.4-r22[mppe-mppc]: sed command targets ppp instead of ppp.conf
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High minor (vote)
Assignee: Gentoo Dialup Developers
URL: http://sources.gentoo.org/viewcvs.py/...
Whiteboard:
Keywords:
Depends on:
Blocks: 274942
  Show dependency tree
 
Reported: 2009-06-21 12:06 UTC by Martin von Gagern
Modified: 2009-06-23 06:26 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Martin von Gagern 2009-06-21 12:06:36 UTC
The current ppp-2.4.4-r22.ebuild ebuild contains these lines:

	insinto /etc/modprobe.d
	insopts -m0644
	newins "${FILESDIR}/modules.ppp" ppp.conf
	if use mppe-mppc; then
		sed -i -e 's/ppp_mppe/ppp_mppe_mppc/' "${D}/etc/modprobe.d/ppp"
	fi

So the file gets installed as "ppp.conf", but with the use flag enabled, sed tries to operate on a different file called "ppp". And as the return value of the sed isn't checked, the problem will most likely go unnoticed.

I'm reporting this issue solely based on the contents of the ebuild; I haven't expecienced any consequences of this myself. Is there a tracker for issues with modprobe.d files newly requiring the .conf extension?
Comment 1 Alin Năstac (RETIRED) gentoo-dev 2009-06-23 06:26:28 UTC
Fixed in revision -r23. The old revisions were removed and the new one was submitted with stable keywords.