Bug 274445 – [GNOME/upstream] net-libs/webkit-gtk dark theme support

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Priit Laes (IRC: plaes) 2009-06-17 05:55:26 UTC]

Only change required compared with 1.1.8 ebuild: change '--enable-svg-filters' to '--enable-filters'

[Comment 1 Lukas Zavodny 2009-06-17 09:03:26 UTC]

well I made an ebuild that fixed some bugs in prev. version and add more features to set. However it will need some tests with all this features enabled/disabled. And I add patch for dark themes and forms.

[Comment 2 Lukas Zavodny 2009-06-17 09:04:29 UTC]

Created attachment 194966 [details]
1.1.10 ebuild

[Comment 3 Lukas Zavodny 2009-06-17 09:05:15 UTC]

Created attachment 194968 [details]
dark theme patch for forms

[Comment 4 Lukas Zavodny 2009-06-17 09:29:14 UTC]

Created attachment 194974 [details]
few fixes in ebuild

[Comment 5 Romain Perier (RETIRED) 2009-06-19 06:04:06 UTC]

@Lukas: This ebuild use EAPI="2", so your patch need to be applied from src_prepare() and not from src_unpack(), for exemple after the sed expression.

can you fix it ? thanks ;)

[Comment 6 Lukas Zavodny 2009-06-19 14:28:52 UTC]

Created attachment 195171 [details]
fixed patching

ok :) I hope it is ok now :)

[Comment 7 Romain Perier (RETIRED) 2009-06-19 16:00:23 UTC]

@Lukas: well thanks, now can open an upstream and attach your patch to it ?
(open a bug on bugzilla.gnome.org, explain your fix, then attach your patch)

[Comment 8 Romain Perier (RETIRED) 2009-06-19 16:44:32 UTC]

post on bugs.webkit.org  and not bugzilla.gnome.org sorry :\

[Comment 9 Romain Perier (RETIRED) 2009-06-19 18:10:19 UTC]

Bumped into the tree, now just missing your upstream Lukas and then we can close this bug.

@Priit: Thanks for your original ebuild :)

[Comment 10 Lukas Zavodny 2009-06-19 23:08:04 UTC]

Created attachment 195230 [details, diff]
updated patch

There is already opened bug in webkit bugzilla. This patch is mainly from there, I only added one more fix, and now I have removed lines what aren't necessary. I can post it there, but this is just a workaround if I understood it well, until it will be fixed by better way more. At this moment in theme changing the page must be reloaded to proper font color. But better than nothing (I mean better then write something and don't see what :)).

[Comment 11 Priit Laes (IRC: plaes) 2009-06-20 07:54:25 UTC]

> There is already opened bug in webkit bugzilla. This patch is mainly from
> there, I only added one more fix, and now I have removed lines what aren't
> necessary. I can post it there, but this is just a workaround if I understood
> it well, until it will be fixed by better way more. At this moment in theme
> changing the page must be reloaded to proper font color. But better than
> nothing (I mean better then write something and don't see what :)).
> 

Could you please post link to bug in webkit's bugzilla...

[Comment 12 Lukas Zavodny 2009-06-20 08:25:01 UTC]

> Could you please post link to bug in webkit's bugzilla...
> 

yep, https://bugs.webkit.org/show_bug.cgi?id=15597

[Comment 13 Priit Laes (IRC: plaes) 2009-06-20 08:55:26 UTC]

Updating summary...

[Comment 14 Romain Perier (RETIRED) 2009-06-20 12:25:59 UTC]

Well, gnome herd is now in CC list of the upstream bug, if upstream developers are agree about this patch we will include it (depending if there is an other version bump which may be could fix this problem)

i'm close this bug