Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 273957 - dev-lang/R-2.9.0 broken html links to manual in DOC_SYMLINKS_DIR
Summary: dev-lang/R-2.9.0 broken html links to manual in DOC_SYMLINKS_DIR
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Development (show other bugs)
Hardware: All Linux
: High minor (vote)
Assignee: Gentoo Science Mathematics related packages
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-06-13 07:44 UTC by Martin von Gagern
Modified: 2009-07-16 06:14 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
Adjust links using sed and a symlink (273957a.patch,784 bytes, patch)
2009-07-15 20:33 UTC, Martin von Gagern
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Martin von Gagern 2009-06-13 07:44:32 UTC
Steps to reproduce:
1. mkdir -p /usr/share/doc/html
2. DOC_SYMLINKS_DIR=/usr/share/doc/html emerge -1 =dev-lang/R
3. firefox file:///usr/share/doc/html/dev-lang/R/index.html
4. select any manual, e.g. "An Introduction to R"

Expected behaviour:
Page file:///usr/share/doc/R-2.9.0/manual/R-intro.html displayed, either under this address, or even better, under a symlinked address that doesn't involve the version number and is thus better suited as a bookmark.

Actual behaviour:
URL file:///usr/share/doc/html/dev-lang/manual/R-intro.html attempted which does not refer to any existing file.

I believe that in order to fix this, you should symlink the manual directory into the html directory, and rewrite index.html and search/SearchEngine.html to refer to manual instead of ../manual. A simple sed can do this.
Comment 1 Sébastien Fabbro (RETIRED) gentoo-dev 2009-07-07 21:15:53 UTC
Hi,

I'm not so sure we want to do this yet. DOC_SYMLINKS_DIR is not official as far as I know, and not supported by all package managers.
Comment 2 Martin von Gagern 2009-07-08 07:32:50 UTC
(In reply to comment #1)
> DOC_SYMLINKS_DIR is not official as far as I know

The make.conf(5) man page does document it on my system. The file comes from sys-apps/portage-2.2_rc33. No experimental warning around. Seems official to me.

> and not supported by all package managers.

So what? If there is at least one package manager supporting it, and if the change doesn't break anything for users not using the feature, then this seems reason enough to implement it.
Comment 3 Sébastien Fabbro (RETIRED) gentoo-dev 2009-07-15 17:20:20 UTC
> > DOC_SYMLINKS_DIR is not official as far as I know
> 
> The make.conf(5) man page does document it on my system. The file comes from
> sys-apps/portage-2.2_rc33. No experimental warning around. Seems official to
> me.

make.conf is official for portage only. I don't particularly like this way of handling the docs anyway, since you will have to patch all the packages which install docs similarly to R, and it's not compatible with upstream. So unless it's official (such as in PMS), I don't see a reason to work on it.

> > and not supported by all package managers.
> 
> So what? If there is at least one package manager supporting it, and if the
> change doesn't break anything for users not using the feature, then this seems
> reason enough to implement it.

Please provide a patch if you think it's worth it. I'd be happy to apply it.

Comment 4 Martin von Gagern 2009-07-15 20:33:39 UTC
Created attachment 198098 [details, diff]
Adjust links using sed and a symlink

(In reply to comment #3)
> Please provide a patch if you think it's worth it. I'd be happy to apply it.

Here you go. Works for me, shouldn't break anything.
Comment 5 Sébastien Fabbro (RETIRED) gentoo-dev 2009-07-16 06:14:48 UTC
In cvs. Thanks!