Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 271906 - media-video/mplayer-1.0_rc2_p20090530: mp3lib patch needs review
Summary: media-video/mplayer-1.0_rc2_p20090530: mp3lib patch needs review
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Gentoo Media-video project
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-05-30 20:51 UTC by Samuli Suominen (RETIRED)
Modified: 2009-07-18 14:21 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Output when Diego's mp3lib patch is applied, no sounds at all. (output-with-diegos-patch.txt,1.45 KB, text/plain)
2009-05-31 16:31 UTC, Samuli Suominen (RETIRED)
Details
The patch that broke MP3 playing. (mplayer-1.0_rc2_p20090322-fix-mp3lib-use-local-labels.patch,984 bytes, patch)
2009-05-31 16:37 UTC, Samuli Suominen (RETIRED)
Details | Diff
New patch. (mplayer-1.0_rc2_p20090530-fix-mp3lib-use-local-labels-2.patch,986 bytes, patch)
2009-06-03 00:07 UTC, Samuli Suominen (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Samuli Suominen (RETIRED) gentoo-dev 2009-05-30 20:51:41 UTC
audio still plays with -ac mad or -afm ffmpeg but without parameters, there is no sound. 

-9999 version plays fine, so I assume the bug is fixed and we just need a new snapshot.

These are built with gcc-4.4.0 and glibc-2.10.1-r0
Comment 1 Samuli Suominen (RETIRED) gentoo-dev 2009-05-30 20:53:12 UTC
These are the flags (when downgrading from -9999)

[ebuild     UD] media-video/mplayer-1.0_rc2_p20090322 [9999] USE="X a52 aac aalib alsa amrnb amrwb ass cddb cdio cdparanoia dirac dts dv dvd dvdnav enca encode faac faad gtk* iconv ipv6 jpeg libcaca live mad mmx mp2 mp3 nemesi network openal opengl png quicktime rar real rtc schroedinger sdl speex sse sse2 ssse3 theora tremor truetype unicode vdpau vorbis x264 xscreensaver xv xvid xvmc -3dnow -3dnowext (-altivec) -arts -bidi -bindist -bl -cpudetection -custom-cflags -custom-cpuopts -debug -dga -directfb -doc -dvb -dxr3 -esd -fbcon -ftp -ggi -gif -jack -joystick -ladspa -lirc -lzo -md5sum -mmxext -mng -musepack -nas -oss -pnm -pulseaudio -pvr -radio -samba (-svga) -teletext -tga -v4l -v4l2 (-vidix) (-win32codecs) -xanim -xinerama -zoran (-nut%) (-osdmenu%*) (-shm%*)" VIDEO_CARDS="nvidia -mga -s3virge -tdfx -vesa"
Comment 2 Samuli Suominen (RETIRED) gentoo-dev 2009-05-30 22:21:24 UTC
Sounds are back in -9999 and new snapshot mplayer-1.0_rc2_p20090530

Thanks beandog!
Comment 3 Samuli Suominen (RETIRED) gentoo-dev 2009-05-30 22:21:52 UTC
err.. reopening for tracking purposes
Comment 4 Samuli Suominen (RETIRED) gentoo-dev 2009-05-31 16:26:21 UTC
Your patch breaks playing MP3 entirely. Reverting the commit you just made.
Comment 5 Samuli Suominen (RETIRED) gentoo-dev 2009-05-31 16:31:28 UTC
Created attachment 193070 [details]
Output when Diego's mp3lib patch is applied, no sounds at all.
Comment 6 Samuli Suominen (RETIRED) gentoo-dev 2009-05-31 16:37:05 UTC
Created attachment 193071 [details, diff]
The patch that broke MP3 playing.

For reference.
Comment 7 Luca Barbato gentoo-dev 2009-05-31 16:48:18 UTC
strangely here seemed to work, try to use as jump target 0b and 1b...
Comment 8 Samuli Suominen (RETIRED) gentoo-dev 2009-05-31 16:49:57 UTC
With the patch applied, only way to listen MP3's was to pass

-ac mad

or

-demuxer lavf

to commandline (advises from #mplayer)
Comment 9 Samuli Suominen (RETIRED) gentoo-dev 2009-05-31 16:59:49 UTC
(In reply to comment #8)
> With the patch applied, only way to listen MP3's was to pass
> -demuxer lavf

Or was that -afm ffmpeg.. one of them, grepping .bash_history (rebuilding mplayer with and without the patch takes a good while, i'll try again tonight)
Comment 10 Diego Elio Pettenò (RETIRED) gentoo-dev 2009-05-31 17:07:47 UTC
[Would have been nice to be CCed at the first round; btw here it worked fine, but I have to say that it might be related to my flags just like for the failures...]
Comment 11 Diego Elio Pettenò (RETIRED) gentoo-dev 2009-05-31 17:21:14 UTC
I can confirm that I can (still) play mp3s with Luca's patch modified to use 0b 1b instead of just 0 and 1 during jumps.

Samuli can you try with that change please?
Comment 12 Klaus Kusche 2009-06-01 19:55:38 UTC
For me, that patch makes mplayer SIGSEGVing (on x86-64):
Old version of mplayer-1.0_rc2_p20090322 ebuild without that patch worked fine,
new version of ebuild with that patch SIGSEGV's mplayer with a NULL pointer.

Last message before SIGSEGV is about loading mp3lib.
Comment 13 Samuli Suominen (RETIRED) gentoo-dev 2009-06-03 00:06:19 UTC
+  03 Jun 2009; Samuli Suominen <ssuominen@gentoo.org>
+  mplayer-1.0_rc2_p20090322.ebuild, mplayer-1.0_rc2_p20090530.ebuild,
+  -files/mplayer-1.0_rc2_p20090322-fix-mp3lib-use-local-labels.patch,
+  +files/mplayer-1.0_rc2_p20090530-fix-mp3lib-use-local-labels-2.patch:
+  Modify fix-mp3lib-use-local-labels to use jump 0b and 1b instead of 0 and
+  1 wrt #271906, thanks to Luca Barbato. Remove the broken patch from old
+  version.

I hope I got this right. Works for me.

Please review, and if OK, please Luca commit to upstream.
Comment 14 Samuli Suominen (RETIRED) gentoo-dev 2009-06-03 00:07:11 UTC
Created attachment 193342 [details, diff]
New patch.

New patch. Works here, please review.
Comment 15 Diego Elio Pettenò (RETIRED) gentoo-dev 2009-06-03 07:02:12 UTC
Works here too, thanks Samuli!
Comment 16 Steve Dibb (RETIRED) gentoo-dev 2009-06-19 17:20:47 UTC
(In reply to comment #13)
> +  03 Jun 2009; Samuli Suominen <ssuominen@gentoo.org>
> +  mplayer-1.0_rc2_p20090322.ebuild, mplayer-1.0_rc2_p20090530.ebuild,
> +  -files/mplayer-1.0_rc2_p20090322-fix-mp3lib-use-local-labels.patch,
> +  +files/mplayer-1.0_rc2_p20090530-fix-mp3lib-use-local-labels-2.patch:
> +  Modify fix-mp3lib-use-local-labels to use jump 0b and 1b instead of 0 and
> +  1 wrt #271906, thanks to Luca Barbato. Remove the broken patch from old
> +  version.
> 
> I hope I got this right. Works for me.
> 
> Please review, and if OK, please Luca commit to upstream.
> 

*poke* :)
Comment 17 Samuli Suominen (RETIRED) gentoo-dev 2009-07-18 13:45:13 UTC
?
Comment 18 Samuli Suominen (RETIRED) gentoo-dev 2009-07-18 14:21:30 UTC
According to Luca it was posted on mplayer-dev-eng already; and I accidentally double-posted it today..

Should be enough posting :P