Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 271341 - app-emulation/virtualbox-guest-additions-2.2.2 pulls in X even when USE=-X
Summary: app-emulation/virtualbox-guest-additions-2.2.2 pulls in X even when USE=-X
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Markus Ullmann (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-05-26 19:48 UTC by Brad House
Modified: 2009-06-01 00:28 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Ebuild patch to remove X dependency (virtualbox-guest-additions-2.2.2.patch,917 bytes, patch)
2009-05-26 19:49 UTC, Brad House
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brad House 2009-05-26 19:48:41 UTC
The ebuild currently always requires X for no apparent reason.  Attaching a patch to the ebuild which removes this dependency when USE=-X.  Tested here on amd64, works.
Comment 1 Brad House 2009-05-26 19:49:25 UTC
Created attachment 192537 [details, diff]
Ebuild patch to remove X dependency
Comment 2 Lars Wendler (Polynomial-C) (RETIRED) gentoo-dev 2009-05-26 22:02:37 UTC
Please don't CC maintainers/herds yourself. Leave that to the bug-wranglers.
Comment 3 Alessio Cassibba (X-Drum) 2009-05-30 23:47:04 UTC
Hi, 
thanks for your report fixed (my fault) on jokey's overlay[1]
both for virtualbox-guest-additions-2.2.2 and 
virtualbox-guest-additions-2.2.4.


[1] http://overlays.gentoo.org/dev/jokey
Comment 4 Brad House 2009-05-31 00:33:11 UTC
Just checked out your repo and you don't actually appear to correct the issue. It looks like you only merged the DEPEND fix, but not the RDEPEND fix. The first line of the 'RDEPEND' still pulls in 'x11-libs/libXt', it should not as it is being pulled later in the X? () section ...  Also, the amd64? () should only pull in the app-emulation/emul-linux-x86-xlibs if the X use flag exists.  My patch addressed both of those as well.

Thanks.
-Brad
Comment 5 Alessio Cassibba (X-Drum) 2009-05-31 13:16:47 UTC
(In reply to comment #4)
[..]

yes, you are right again, fixed,

thanks!
Comment 6 Patrick Lauer gentoo-dev 2009-06-01 00:28:47 UTC
+  01 Jun 2009; Patrick Lauer <patrick@gentoo.org>                                                                 
+  +virtualbox-ose-2.2.4.ebuild:                                                                                   
+  Bump to 2.2.4, thanks to Alessio Cassibba. Fixes #271983 #271341 #269335 

Since all of virtualbox got bumped that should include this bug too.