I've been trying to rid my system of gstreamer, and one of my last remaining dependencies is from gnome-games. A cursory glance shows that gnome-games can be built against sdl (default) or gstreamer (which the ebuild explicitly selects). Unless there is a reason for this, I think that gstreamer support should be enabled via use flag, and should fall back on sdl when disabled. Reproducible: Always
care enough to try and submit and patch for the ebuild ?
Created attachment 191263 [details] Modified gnome-games-2.26 ebuild with gstreamer and sdl use flags I made sdl the dominant option because it's the default for the release and IMHO it sounds better than gstreamer when they're backed by pulseaudio.
FTR, I've checked upstream's code and libcanberra is a possibility at least in git master... Maybe a patch that's worth backporting?
@Matthew, please attach diffs instead of full ebuilds. Makes reviewing much easier. Thanks
Created attachment 191273 [details, diff] Patch for previous ebuild, plus an additional warning about disabled sound support Sorry, I couldn't remember which format was preferred. I think it would be nice to backport the libcanberra changes, but it looks like its still undergoing implementation changes. By the time it stabilizes, GNOME 2.28 might be close enough to just wait for it.
Created attachment 192310 [details, diff] Make gstreamer the default, fall back on sdl-mixer Thanks for the patch! I'm attaching a slightly different patch that makes gstreamer the default option and falls back on sdl-mixer otherwise. I don't want to drop keywords on sh support for this patch, so I've filed another one (blocking this bug) requesting sh support in sdl-mixer first.
Arun, your patch looks good. One thing though, I think users would like to know in advance if they'll get sound or not. If they're not in front of their computer at the moment it gets printed it's not important if it's before or after building anyway.
Included in 2.26.2-r1. Thanks for reporting and the patch.
