Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 269691 - media-video/kaffeine-0.8.7-r1 USE=-dvb EAPI-2 horkage [patch]
Summary: media-video/kaffeine-0.8.7-r1 USE=-dvb EAPI-2 horkage [patch]
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] KDE (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Gentoo KDE team
URL:
Whiteboard:
Keywords: InVCS
Depends on:
Blocks:
 
Reported: 2009-05-13 12:46 UTC by Duncan
Modified: 2009-05-14 13:04 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
emerge --info (emerge.info,4.96 KB, text/plain)
2009-05-13 12:49 UTC, Duncan
Details
emerge log (media-video:kaffeine-0.8.7-r1:20090513-111735.log,73.58 KB, text/plain)
2009-05-13 13:03 UTC, Duncan
Details
kaffeine eapi2 & /usr/kde/ mv patch (kaffeine-eapi2&usrkde-mv.patch,878 bytes, patch)
2009-05-13 18:25 UTC, Duncan
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Duncan 2009-05-13 12:46:37 UTC
I'm having issues similar to those in (ancient) bug #198973 , in the dvb code.  What's interesting is that I have USE=-dvb, and the ebuild knows that, because it tries to continue without the linuxtv-dvb-headers package that would be required with USE=dvb.  Thus, it's expected that it would fail trying to compile the dvb stuff, and the problem must be in the configuration steps since it's still trying to compile it anyway.  In fact, under Kaffeine configure results, it says Build with DVB support: .... yes.

Also interesting, despite what the ebuild is setting up with myconf (the $(use_with dvb) line in particular, I'm getting this:

* econf: updating kaffeine-0.8.7/admin/config.guess with /usr/share/gnuconfig/config.guess
./configure --prefix=/usr --build=x86_64-pc-linux-gnu
 --host=x86_64-pc-linux-gnu --mandir=/usr/share/man --infodir=/usr/share/info
 --datadir=/usr/share --sysconfdir=/etc --localstatedir=/var/lib
 --libdir=/usr/kde/3.5/lib64 --with-x --enable-mitshm --with-xinerama
 --with-qt-dir=/usr/qt/3 --enable-mt --with-qt-libraries=/usr/qt/3/lib64
 --disable-dependency-tracking --disable-debug --without-debug --without-arts
 --prefix=/usr/kde/3.5 --mandir=/usr/kde/3.5/share/man
 --infodir=/usr/kde/3.5/share/info --datadir=/usr/kde/3.5/share
 --sysconfdir=/usr/kde/3.5/etc --enable-libsuffix=64
configure: WARNING: unrecognized options: --with-x, --enable-mitshm, --without-debug

Do you see anything in that configure line about no dvb?  I don't.

So USE=-dvb isn't getting to .configure, for whatever reason.  Maybe an incompatible set of autotools?  That's about as far as I know how to take it.

I'll attach emerge --info and the build log.  Before you worry about any semi-exotic flags, however, note that I've already tried with the following very basic flags set in /etc/portage/env/media-video/kaffeine, without any change, so it's not exotic (C(XX)|LD)FLAGS, nor is it parallel make related, and I've tried both gcc-4.3 and 4.4, so it wouldn't seem to be that, either:

CFLAGS="-march=opteron-sse3 -pipe -O2"
CXXFLAGS=$CFLAGS
LDFLAGS=
MAKEOPTS=-j1

It should be noted that this would be a rebuild of the same kaffeine-0.8.7-r1 that merged just fine for me on February 21, with the same flags as in the emerge --info I'll be attaching.  According to the changelog, there's been one change to the ebuild since, a change to the xine-lib dependency line on Feb 22, the day after I merged.  That single change is confirmed with a diff of the current tree and package-database versions of the ebuild.  But that doesn't seem related and it looks to be an autotools issue from the best I can figure, here.  I didn't check eclasses tho and it appears from a diff of the environment files, pkg-db against the "live" one in tmp, that there have been some changes.  FWIW, WANT_AUTOCONF="2.5" and WANT_AUTOMAKE="1.9" in both, so that didn't change.  The only auto* package that has a date since February is auto-conf-2.63.1-r1, with an binpkg (and thus install) date of 2009-04-06.  So it would seem to be either that, or an eclass change.

(FWIW, I'm trying to rebuild kaffeine because I'm seeing something close to #241372 again, it can't find xine_part.desktop, this with kdelibs-3.5.10-r4, but I'm going to file that as a separate bug as it would seem to be just that, not related at all to this failure to merge bug.)
Comment 1 Duncan 2009-05-13 12:49:06 UTC
Created attachment 191143 [details]
emerge --info
Comment 2 Duncan 2009-05-13 13:03:25 UTC
Created attachment 191145 [details]
emerge log

This is (I think) the log with the "simple flags" env file mentioned above activated.  Here's the emerge -av1 prompt, showing USE=-dvb

[ebuild   R   ] media-video/kaffeine-0.8.7-r1  USE="encode vorbis xcb xinerama -debug -dvb -gstreamer" 0 kB

Note again the .configure line (not turning off dvb, despite the ebuild myconf), the configure results summary (DVB support enabled), and that the failure was in the dvb subdirs, which it shouldn't be building anyway, according to the USE flag, but will, according to the configure summary.
Comment 3 Duncan 2009-05-13 15:18:20 UTC
I tried downgrading autoconf to 2.63, which is what I had when I did the successful February kaffeine merge, no change.  So eclasses?
Comment 4 Duncan 2009-05-13 15:56:50 UTC
Nailed to kde.eclass, the May 12 changes, revision 1.223.  Substituting in 1.222, the config summary correctly states DVB no, with the current 1.223, it incorrectly states DVB yes.
Comment 5 Duncan 2009-05-13 17:26:48 UTC
D'oh.  Simple enough fix.  When the ebuild claims to be EAPI-2, make it so -- split the src_compile accordingly.  In this case, it's all configure, so rename the function to src_configure, and at the end, call kde_src_configure instead of kde_src_compile.  The compile is then handed automatically  Two-line change:

-- kaffeine-0.8.7-r1.ebuild    2009-04-12 01:07:53.000000000 -0700
+++ /tmp/kaffeine-0.8.7-r1.ebuild  2009-05-13 10:12:59.000000000 -0700
@@ -46,7 +46,7 @@ src_prepare() {
        :
 }

-src_compile() {
+src_configure() {
        # see bug #143168
        replace-flags -O3 -O2

@@ -63,7 +63,7 @@ src_compile() {
                $(use_with xcb)
                $(use_with encode lame)"

-       kde_src_compile
+       kde_src_configure
 }

 src_install() {

Comment 6 Duncan 2009-05-13 18:25:00 UTC
Created attachment 191183 [details, diff]
kaffeine eapi2 & /usr/kde/ mv patch

OK, the patch in comment #5 fixed the EAPI-2 horkage, but the recent kdelibs update moved most kde-3.5 package files from /usr to /usr/kde/3.5, and the ebuild had the old location hard-coded in a couple places, so it was still breaking.

Namely, the l10n/mofile fix was breaking, as was the removal of the mplayer desktop file, both at the end of the install phase.  This patch should fix those too, and at least here, I get a successful merge, now. 

This obsoletes the patch in the comment above.
Comment 7 Tomáš Chvátal (RETIRED) gentoo-dev 2009-05-13 20:54:24 UTC
replace /usr/kde/3.5 for ${KDEDIR}
otherwise patch looks good for applying.
Comment 8 Tomáš Chvátal (RETIRED) gentoo-dev 2009-05-14 13:04:42 UTC
Thx for patch.
Applied.