Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 268394 - [p.masked] net-libs/xulrunner-1.9.1 & www-client/mozilla-firefox-3.5 release
Summary: [p.masked] net-libs/xulrunner-1.9.1 & www-client/mozilla-firefox-3.5 release
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High normal with 4 votes (vote)
Assignee: Mozilla Gentoo Team
URL:
Whiteboard:
Keywords:
: 275973 (view as bug list)
Depends on: 237317 241400 256773 257803 258917 267228 272163 275252 276380
Blocks: CVE-2009-2462
  Show dependency tree
 
Reported: 2009-05-03 08:18 UTC by Harald van Dijk (RETIRED)
Modified: 2009-08-21 06:39 UTC (History)
28 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
List of packages depending on xulrunner (xulrunner,1.09 KB, text/plain)
2009-07-01 04:44 UTC, Nirbheek Chauhan (RETIRED)
Details
updated list (xulrunner-deps.txt,1.24 KB, text/plain)
2009-07-02 04:32 UTC, Jory A. Pratt
Details
New list (xulrunner.list,1.20 KB, text/plain)
2009-07-02 06:29 UTC, Nirbheek Chauhan (RETIRED)
Details
Newest list (xulrunner.list,1.20 KB, text/plain)
2009-07-10 11:01 UTC, Nirbheek Chauhan (RETIRED)
Details
Newerest list (xulrunner.list,1.02 KB, text/plain)
2009-07-10 18:21 UTC, Nirbheek Chauhan (RETIRED)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Harald van Dijk (RETIRED) gentoo-dev 2009-05-03 08:18:02 UTC
I was using firefox 3.5_beta4 with USE=-xulrunner, and xulrunner 1.9.0 installed separately, because some things (one of them being gnash) aren't yet updated to build against xulrunner 1.9.1. That's not possible any more: either I lose the ability to build plugins (unless they were recently fixed) or I lose the ability to try out firefox 3.5. Please either allow xulrunner 1.9.0 and 1.9.1 to be installed side by side while making sure plugins use 1.9.0, or bring back USE=xulrunner support.
Comment 1 Nirbheek Chauhan (RETIRED) gentoo-dev 2009-05-03 09:15:48 UTC
Plugins not building with 1.9.1 really should not be happening since mozilla tries to keep the plugin API constant between releases (mostly so that proprietary plugins keep working)

I'll take a look at gnash, in the meanwhile you should take a look at swfdec-mozilla, and give me a list of what else stops working. I have the following plugins working with 1.9.1:

www-plugins/moonlight-1.0.1
media-video/totem-2.26.1[nsplugin]
media-sound/rhythmbox-0.12.1[nsplugin]
www-plugins/adobe-flash-10.0.22.87
www-plugins/swfdec-mozilla-0.8.2
Comment 2 Harald van Dijk (RETIRED) gentoo-dev 2009-05-03 09:28:47 UTC
(In reply to comment #1)
> Plugins not building with 1.9.1 really should not be happening since mozilla
> tries to keep the plugin API constant between releases (mostly so that
> proprietary plugins keep working)

Are you sure they don't keep the plugin ABI constant? That's all that's required to keep existing installed plugins (whether proprietary or not) working. If they do keep the plugin API constant, that suggests other things are relying on xulrunner internals.

Already had swfdec-mozilla installed next to gnash :) I enable one and disable the other when one doesn't work on a particular site.

I will check what exactly is depending on xulrunner on my system, try to build all of those with 1.9.1, and give you a list of anything that fails. It will take a little while though, especially since xulrunner itself will take a long time to update.
Comment 3 Nirbheek Chauhan (RETIRED) gentoo-dev 2009-05-03 09:44:16 UTC
(In reply to comment #2)
> Are you sure they don't keep the plugin ABI constant? That's all that's
> required to keep existing installed plugins (whether proprietary or not)
> working. If they do keep the plugin API constant, that suggests other things
> are relying on xulrunner internals.
> 

Hey, isn't keeping ABI constant a superset of keeping API constant? :)

> I will check what exactly is depending on xulrunner on my system, try to build
> all of those with 1.9.1, and give you a list of anything that fails. It will
> take a little while though, especially since xulrunner itself will take a long
> time to update.
> 

Excellent, if you find a lot of breakage, convert this bug into a tracker bug and open other bugs blocking this.
Comment 4 BedOS_Gui 2009-05-03 10:00:14 UTC
> Excellent, if you find a lot of breakage, convert this bug into a tracker bug
> and open other bugs blocking this.
> 

there is my bug about epiphany :-) :

http://bugs.gentoo.org/show_bug.cgi?id=265700
Comment 5 Nirbheek Chauhan (RETIRED) gentoo-dev 2009-05-03 10:08:15 UTC
Strange. Here, gnash compiles perfectly fine.

(In reply to comment #4)
> there is my bug about epiphany :-) :
> 
> http://bugs.gentoo.org/show_bug.cgi?id=265700
> 

INVALID -- epiphany 2.26 works with xulrunner 1.9.1 :p
Comment 6 BedOS_Gui 2009-05-03 10:12:02 UTC
(In reply to comment #5)
> Strange. Here, gnash compiles perfectly fine.
> 
> (In reply to comment #4)
> > there is my bug about epiphany :-) :
> > 
> > http://bugs.gentoo.org/show_bug.cgi?id=265700
> > 
> 
> INVALID -- epiphany 2.26 works with xulrunner 1.9.1 :p
> 
Yes Nirbheek, but epiphany-2.26 isn't yet in portage tree :-)
Comment 7 Harald van Dijk (RETIRED) gentoo-dev 2009-05-03 10:15:15 UTC
(In reply to comment #3)
> Hey, isn't keeping ABI constant a superset of keeping API constant? :)

No, it really isn't. It's possible to change the API without changing the ABI, and it's possible to change the ABI without changing the API. You were partially joking, I know, but I'm not sure which part was the joke, so responding anyway.

(In reply to comment #5)
> Strange. Here, gnash compiles perfectly fine.

That's great. Hopefully it was a problem that has since been fixed and gnash will compile and install equally fine for me.
Comment 8 Nirbheek Chauhan (RETIRED) gentoo-dev 2009-05-03 10:20:08 UTC
(In reply to comment #6)
> > INVALID -- epiphany 2.26 works with xulrunner 1.9.1 :p
> > 
> Yes Nirbheek, but epiphany-2.26 isn't yet in portage tree :-)
> 

Neither is xulrunner 1.9.1, anyway, 2.26 is slowly entering portage, so that bug is not an issue right now, except to change the deps of epiphany-2.24
Comment 9 Harald van Dijk (RETIRED) gentoo-dev 2009-05-03 16:43:06 UTC
The first result:

dev-java/icedtea6 (java overlay) fails with

IcedTeaPlugin.cc:3768: error: no matching function for call to 'nsIProcess::Run(int, const char**&, int&, int)'
/usr/include/xulrunner-1.9.1/unstable/nsIProcess.h:66: note: candidates are: virtual nsresult nsIProcess::Run(PRBool, const char**, PRUint32)
Comment 10 Harald van Dijk (RETIRED) gentoo-dev 2009-05-03 17:14:01 UTC
dev-java/swt and gnome-extra/yelp built fine, then came media-video/vlc:

support/npunix.c:55:19: error: npupp.h: No such file or directory
Comment 11 Harald van Dijk (RETIRED) gentoo-dev 2009-05-03 17:28:40 UTC
www-client/mozilla-firefox failed, but you already fixed that.
www-client/kazehakase installs, but fails with "libxul.so: cannot open shared object file: No such file or directory" at runtime (which is nothing new), and fails by not doing anything useful when including /usr/$(get_libdir)/xulrunner-1.9.1 in LD_LIBRARY_PATH (which is new)
www-plugins/mplayerplug-in fails because its pkg_setup built_with_use check is broken. I cannot test anything else because glibc fucking broke my entire system (/var/tmp/portage/sys-libs/glibc-2.9_p20081201-r2/temp/environment: line 1275: eblit-glibc-src_install: command not found) and portage happily continued to get rid of everything of my existing glibc install.
Comment 12 Nirbheek Chauhan (RETIRED) gentoo-dev 2009-05-03 17:36:28 UTC
(In reply to comment #10)
> dev-java/swt and gnome-extra/yelp built fine, then came media-video/vlc:
> 
> support/npunix.c:55:19: error: npupp.h: No such file or directory
> 

That file's been replaced by npfunctions.h see if just symlinking to npupp.h works -- if it does, then the patch will be trivial for 1.9.1. Else we'll have to go patch-hunting :p
Comment 13 Harald van Dijk (RETIRED) gentoo-dev 2009-05-09 12:05:23 UTC
My system's almost back to normal, and sane enough to retry mplayerplug-in with the buggy pkg_setup check bypassed. It fails with

[...]
checking pkg-config is at least version 0.9.0... yes
checking for MOZPLUG... no
configure: WARNING: mozilla-plugin not found
checking for MOZPLUG... no
configure: WARNING: firefox-plugin not found
checking for MOZPLUG... no
configure: WARNING: seamonkey-plugin not found
checking for MOZPLUG... no
configure: WARNING: xulrunner-plugin not found
checking for MOZPLUG... yes
checking for xpidl... no
configure: error: xpidl compiler not found
[...]

which seems to be because it's looking in $MOZILLA_HOME, rather than $MOZILLA_HOME/bin.
Comment 14 Harald van Dijk (RETIRED) gentoo-dev 2009-05-09 12:16:22 UTC
(In reply to comment #12)
> (In reply to comment #10)
> > dev-java/swt and gnome-extra/yelp built fine, then came media-video/vlc:
> > 
> > support/npunix.c:55:19: error: npupp.h: No such file or directory
> 
> That file's been replaced by npfunctions.h see if just symlinking to npupp.h
> works

Actually, I see the code already does

#ifdef HAVE_NPFUNCTIONS_H
#include <npfunctions.h>
#else
#include <npupp.h>
#endif

but HAVE_NPFUNCTIONS_H isn't getting defined.

In comment #1, you wrote that plugins should still build without a problem, but clearly, regardless of whether it's mozilla's fault or the plugins', they don't. So again, please bring back firefox[!xulrunner].
Comment 15 Nirbheek Chauhan (RETIRED) gentoo-dev 2009-05-09 12:55:36 UTC
(In reply to comment #14)
> Actually, I see the code already does
> 
> #ifdef HAVE_NPFUNCTIONS_H
> #include <npfunctions.h>
> #else
> #include <npupp.h>
> #endif
> 
> but HAVE_NPFUNCTIONS_H isn't getting defined.
> 

Well then, I suppose a bug report is in order.

> In comment #1, you wrote that plugins should still build without a problem, but
> clearly, regardless of whether it's mozilla's fault or the plugins', they
> don't. So again, please bring back firefox[!xulrunner].
> 

Not going to happen.

* This is the overlay, things are expected to break
* Is there any reason to keep xulrunner optional in firefox besides this? No.
* This reason is not sufficient; these problems need to be fixed regardless of whether firefox uses the system xulrunner.

Changing summary to reflect the true goal of this bug...
Comment 16 Jory A. Pratt gentoo-dev 2009-05-31 13:21:13 UTC
(In reply to comment #13)
> My system's almost back to normal, and sane enough to retry mplayerplug-in with
> the buggy pkg_setup check bypassed. It fails with
> 
> [...]
> checking pkg-config is at least version 0.9.0... yes
> checking for MOZPLUG... no
> configure: WARNING: mozilla-plugin not found
> checking for MOZPLUG... no
> configure: WARNING: firefox-plugin not found
> checking for MOZPLUG... no
> configure: WARNING: seamonkey-plugin not found
> checking for MOZPLUG... no
> configure: WARNING: xulrunner-plugin not found
> checking for MOZPLUG... yes
> checking for xpidl... no
> configure: error: xpidl compiler not found
> [...]
> 
> which seems to be because it's looking in $MOZILLA_HOME, rather than
> $MOZILLA_HOME/bin.
> 

mplayerplug-in is really depreciated and should me p.masked for removal. Everyone should start moving to gecko-mediaplayer.
Comment 17 Jory A. Pratt gentoo-dev 2009-06-24 02:27:09 UTC
(In reply to comment #10)
> dev-java/swt and gnome-extra/yelp built fine, then came media-video/vlc:
> 
> support/npunix.c:55:19: error: npupp.h: No such file or directory
> 

This is fixed in vlc-1.0.0_rc4 which is in the tree, I would imagine it would come out of p.mask long before xulrunner makes its final release of 1.9.1.
Comment 18 Harald van Dijk (RETIRED) gentoo-dev 2009-06-30 22:19:10 UTC
(In reply to comment #15)
> * This is the overlay, things are expected to break

For the record, it's no longer the overlay.
Comment 19 Nirbheek Chauhan (RETIRED) gentoo-dev 2009-07-01 04:44:16 UTC
Created attachment 196223 [details]
List of packages depending on xulrunner

(In reply to comment #18)
> For the record, it's no longer the overlay.
> 

And it's masked. I've attached a list of packages that depend on xulrunner, and their status. The "Unknown" status packages need to have their status updated.

PS: kazehakaze should work now, I've added an env.d entry for LDPATH for xulrunner
Comment 20 Jory A. Pratt gentoo-dev 2009-07-02 01:51:21 UTC
(In reply to comment #18)
> (In reply to comment #15)
> > * This is the overlay, things are expected to break
> 
> For the record, it's no longer the overlay.
> 

It is still ~arch that is p.masked, still expected to be problems with packages that link against it.
Comment 21 Jory A. Pratt gentoo-dev 2009-07-02 04:32:41 UTC
Created attachment 196311 [details]
updated list 

Original is obsolete, The new list includes all those working and ebuilds that have broken check on useflags, and ebuilds that need to be patched for new xulrunner. List is far from complete but closer then it was :)
Comment 22 404 Error 2009-07-02 04:46:41 UTC
FYI

dev-util/monodevelop-2.0
dev-dotnet/gluezilla-2.4.2
dev-dotnet/gecko-sharp-0.13
dev-util/devhelp-0.23-r1

All of those build and install without errors here. I tried to run Monodevelop and Devhelp : everything is fine.
Comment 23 Nirbheek Chauhan (RETIRED) gentoo-dev 2009-07-02 06:29:27 UTC
Created attachment 196316 [details]
New list

(In reply to comment #22)
> FYI
[snip]
> dev-util/devhelp-0.23-r1

devhelp-0.23 uses webkit-gtk, not xulrunner, 0.21 was the last version using xulrunner. The rest of the packages have been added (alongwith more) to the list

PS: gnu-classpath has been removed from the list because it pulls in xulrunner:1.8 not 1.9
Comment 24 Thomas Frenzel 2009-07-05 09:59:31 UTC
=gnome-extra/evolution-data-server-2.26.2 and some other packages seem to have problems with the doc use flag enabled and nspr-4.8 installed. See http://bugs.gentoo.org/show_bug.cgi?id=275249 and http://bugs.gentoo.org/show_bug.cgi?id=275260 for example.
Comment 25 Nirbheek Chauhan (RETIRED) gentoo-dev 2009-07-10 11:01:02 UTC
Created attachment 197445 [details]
Newest list

Here's the final list. Some things have been removed because they pulled in 1.8.

Once the stuff in this list is fixed, we can unmask firefox and nspr-4.8
Comment 26 Nirbheek Chauhan (RETIRED) gentoo-dev 2009-07-10 11:26:47 UTC
I fixed devhelp (gnome herd) and mplayerplug-in (mozilla herd). Bugs should be opened for the others and made to block this one
Comment 27 Billy DeVincentis 2009-07-10 12:31:15 UTC
Is it my understanding that openoffice will fail to reemerge if I unmask whats needed to emerge firefox 3.5? Will revdep-rebuild force a rebuild of openoffice?
Comment 28 Nirbheek Chauhan (RETIRED) gentoo-dev 2009-07-10 16:59:15 UTC
(In reply to comment #27)
> Is it my understanding that openoffice will fail to reemerge if I unmask whats
> needed to emerge firefox 3.5? Will revdep-rebuild force a rebuild of
> openoffice?
> 

Just rebuild it w/o the nsplugin USE-flag, it's unlikely that you would want to use it.
Comment 29 Nirbheek Chauhan (RETIRED) gentoo-dev 2009-07-10 18:21:09 UTC
Created attachment 197480 [details]
Newerest list

Here's another list. Turns out swt isn't quite fixed
Comment 30 Jory A. Pratt gentoo-dev 2009-07-10 18:21:40 UTC
(In reply to comment #27)
> Is it my understanding that openoffice will fail to reemerge if I unmask whats
> needed to emerge firefox 3.5? Will revdep-rebuild force a rebuild of
> openoffice?
> 

Yes it will force a rebuild.
Comment 31 Jory A. Pratt gentoo-dev 2009-07-10 18:23:45 UTC
(In reply to comment #29)
> Created an attachment (id=197480) [edit]
> Newerest list
> 
> Here's another list. Turns out swt isn't quite fixed
> 

Nirbheek is no point in keeping a package masked over four packages, there are known work arounds until maintainers catch up with development. I still say xulrunner-1.9.1, nspr-4.8. and firefox-3.5 all need to be unmasked so bugs can be found reported and fixed before the 3.5.1 release of firefox and xulrunner-1.9.2 are released.
Comment 32 Nirbheek Chauhan (RETIRED) gentoo-dev 2009-07-12 16:23:45 UTC
Changing focus to generic release bug tracker...
Comment 33 Christophe Saout 2009-07-12 21:44:25 UTC
Just a question:

Someone know why these patches have been dropped:

patch -p0 < /root/x/patch/000_flex-configure-LANG.patch 
patch -p1 < /root/x/patch/055_firefox-2.0_gfbsd-pthreads.patch 
patch -p1 < /root/x/patch/063_firefox-rpath-3.patch 
patch -p0 < /root/x/patch/068_firefox-nss-gentoo-fix.patch 
patch -p0 < /root/x/patch/100-system-hunspell-corrections.patch 
patch -p0 < /root/x/patch/800-bsd_include.patch 

They still apply cleanly.  Maybe check if the bugs they fixed are not reintroduced by dropping them.

At least the rpath thing was needed in e.g. _rc3 to keep prelink happy.
(otherwise it would complaining that stuff in /usr/lib(64)/xulrunner-1.9.1 could not be prelinked because it couldn't find the dependencies or so.
Comment 34 aidar 2009-07-14 03:51:09 UTC
the OOO 3.1.0 is broken after I got FF3.5 with corresponding xulrunner.

can't emerge it as well, can't revdep rebuild it as well. Here is what it says : 

In file included from ../inc/plugin/unx/plugcon.hxx:105,                                                     
                 from ../inc/plugin/unx/sysplug.hxx:35,                                                      
                 from ../inc/plugin/impl.hxx:85,                                                             
                 from /var/tmp/portage/app-office/openoffice-3.1.0/work/ooo/build/ooo310-m11/extensions/source/plugin/base/service.cxx:38:                                                                                
/usr/include/xulrunner-1.9.1/stable/npapi.h:155: error: redefinition of 'struct _NPP'                        
/var/tmp/portage/app-office/openoffice-3.1.0/work/ooo/build/ooo310-m11/solver/310/unxlngx6.pro/inc/npsdk/npapi.h:210: error: previous definition of 'struct _NPP'                                     
Comment 35 aidar 2009-07-14 03:51:40 UTC
the OOO 3.1.0 is broken after I got FF3.5 with corresponding xulrunner.

can't emerge it as well, can't revdep rebuild it as well. Here is what it says : 

In file included from ../inc/plugin/unx/plugcon.hxx:105,                                                     
                 from ../inc/plugin/unx/sysplug.hxx:35,                                                      
                 from ../inc/plugin/impl.hxx:85,                                                             
                 from /var/tmp/portage/app-office/openoffice-3.1.0/work/ooo/build/ooo310-m11/extensions/source/plugin/base/service.cxx:38:                                                                                
/usr/include/xulrunner-1.9.1/stable/npapi.h:155: error: redefinition of 'struct _NPP'                        
/var/tmp/portage/app-office/openoffice-3.1.0/work/ooo/build/ooo310-m11/solver/310/unxlngx6.pro/inc/npsdk/npapi.h:210: error: previous definition of 'struct _NPP'                                     


is there anyone doing something on this ?
Comment 36 Jory A. Pratt gentoo-dev 2009-07-14 03:55:31 UTC
(In reply to comment #35)
> the OOO 3.1.0 is broken after I got FF3.5 with corresponding xulrunner.
> 
> can't emerge it as well, can't revdep rebuild it as well. Here is what it says
> : 
> 
> In file included from ../inc/plugin/unx/plugcon.hxx:105,                        
>                  from ../inc/plugin/unx/sysplug.hxx:35,                         
>                  from ../inc/plugin/impl.hxx:85,                                
>                  from
> /var/tmp/portage/app-office/openoffice-3.1.0/work/ooo/build/ooo310-m11/extensions/source/plugin/base/service.cxx:38: 
> /usr/include/xulrunner-1.9.1/stable/npapi.h:155: error: redefinition of 'struct
> _NPP'                        
> /var/tmp/portage/app-office/openoffice-3.1.0/work/ooo/build/ooo310-m11/solver/310/unxlngx6.pro/inc/npsdk/npapi.h:210:
> error: previous definition of 'struct _NPP'                                     
> 
> 
> is there anyone doing something on this ?
> 
Please watch the double post. There is an openoffice bug for this already, if you just can not wait just -nsplugin openoffice and it will compile cleanly.
Comment 37 Nirbheek Chauhan (RETIRED) gentoo-dev 2009-07-14 08:55:20 UTC
(In reply to comment #35)
> the OOO 3.1.0 is broken after I got FF3.5 with corresponding xulrunner.
> 

bug 256773

Please see the bugs this one depends on, and if you have an issue which is NOT in those, open a NEW bug blocking this one. Do not comment here.
Comment 38 Nirbheek Chauhan (RETIRED) gentoo-dev 2009-07-20 13:31:21 UTC
*** Bug 275973 has been marked as a duplicate of this bug. ***
Comment 39 Nirbheek Chauhan (RETIRED) gentoo-dev 2009-07-22 05:51:44 UTC
3.5.1 has been unmasked in CVS, will hit users in a few hours.

Thanks everyone.