Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 268371 - depend.apache.eclass: Calls to use() in "depend" phase
Summary: depend.apache.eclass: Calls to use() in "depend" phase
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Eclasses (show other bugs)
Hardware: All All
: High major (vote)
Assignee: Apache Team - Bugzilla Reports
URL:
Whiteboard:
Keywords: QAglobalscope
Depends on:
Blocks:
 
Reported: 2009-05-02 23:38 UTC by Arfrever Frehtes Taifersar Arahesis (RETIRED)
Modified: 2009-05-26 18:06 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
depend.apache.eclass.patch (depend.apache.eclass.patch,2.26 KB, patch)
2009-05-02 23:39 UTC, Arfrever Frehtes Taifersar Arahesis (RETIRED)
Details | Diff
depend.apache.eclass.patch (depend.apache.eclass.patch,2.32 KB, patch)
2009-05-11 02:12 UTC, Arfrever Frehtes Taifersar Arahesis (RETIRED)
Details | Diff
depend.apache.eclass.patch (depend.apache.eclass.patch,2.38 KB, patch)
2009-05-16 21:36 UTC, Arfrever Frehtes Taifersar Arahesis (RETIRED)
Details | Diff
depend.apache.eclass.diff (depend.apache.eclass.diff,3.07 KB, patch)
2009-05-25 07:25 UTC, Benedikt Böhm (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Arfrever Frehtes Taifersar Arahesis (RETIRED) gentoo-dev 2009-05-02 23:38:05 UTC
depend.apache.eclass contains calls to use() in functions which are called in "depend" phase (global scope). use() should be called in other phases (e.g. "setup" phase). Calling use() in global scope will cause die() in EAPI >=3.

I suggest to move calls to use() to a new function apache2_optional_init() which should be called in pkg_setup().

All ebuilds which call want_apache(), want_apache2() or want_apache2_2() will have to be updated to call apache2_optional_init() in pkg_setup().
Comment 1 Arfrever Frehtes Taifersar Arahesis (RETIRED) gentoo-dev 2009-05-02 23:39:23 UTC
Created attachment 190193 [details, diff]
depend.apache.eclass.patch
Comment 2 Arfrever Frehtes Taifersar Arahesis (RETIRED) gentoo-dev 2009-05-02 23:51:59 UTC
The following packages call want_apache(), want_apache2() or want_apache2_2():

dev-lang/php
dev-perl/HTML-Mason
dev-php5/eaccelerator
dev-ruby/nitro
dev-util/subversion
net-analyzer/aimsniff
net-analyzer/base
net-analyzer/cacti
net-analyzer/nagios-core
sci-geosciences/mapserver
www-apps/bugzilla
www-apps/otrs
www-misc/awstats
Comment 3 Arfrever Frehtes Taifersar Arahesis (RETIRED) gentoo-dev 2009-05-11 02:12:27 UTC
Created attachment 190895 [details, diff]
depend.apache.eclass.patch
Comment 4 Arfrever Frehtes Taifersar Arahesis (RETIRED) gentoo-dev 2009-05-16 21:36:03 UTC
Created attachment 191501 [details, diff]
depend.apache.eclass.patch
Comment 5 Benedikt Böhm (RETIRED) gentoo-dev 2009-05-25 07:25:25 UTC
Created attachment 192368 [details, diff]
depend.apache.eclass.diff

i'd prefer doing this in pkg_setup, since ebuilds can automatically pick this up, if they don't have other pkg_setup stuff.

if you have the time to fix this in the ebuilds, please do so, my time is currently very limited due to work and this needs fixing rather soon
Comment 6 Arfrever Frehtes Taifersar Arahesis (RETIRED) gentoo-dev 2009-05-26 18:06:06 UTC
Everything should be fixed.