Bug 267445 – app-pda/pilot-link-0.12.3-r1 generates too high bytecode version

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Vlastimil Babka (Caster) (RETIRED) 2009-04-25 17:26:54 UTC]

The build system does not respect JAVACFLAGS, which results in bytecode version depending on JDK used.
I've tried this, which usually helps, without patching:

 src_compile() {                                                                                                    
        # Unfortunately, parallel compilation is badly broken. cf. bug  202857.                                     
-       emake -j1 || die "emake failed"                                                                             
+       emake JAVAC="${JAVAC} ${JAVACFLAGS}" -j1 || die "emake failed"   

But for some reason, the .class files are recompiled and .jar recreated during install. So either override JAVAC also in the emake install, or (perhaps better) figure out why does it happen. I can't see it from the Makefile, the dependencies between targets look sane to me.

[Comment 1 Serkan Kaba (RETIRED) 2009-04-26 05:09:24 UTC]

Created attachment 189446 [details, diff]
pilot-link-0.12.3-respect-javacflags.patch

Patching Makefile.am works.

[Comment 2 Petteri Räty (RETIRED) 2009-04-26 12:31:53 UTC]

(In reply to comment #1)
> Created an attachment (id=189446) [edit]
> pilot-link-0.12.3-respect-javacflags.patch
> 
> Patching Makefile.am works.
> 

submit upstream and apply in the tree please

[Comment 3 Serkan Kaba (RETIRED) 2009-04-26 18:34:33 UTC]

(In reply to comment #2)
> submit upstream and apply in the tree please
Fixed in tree with a revbump, but I couldn't find anywhere to report it, maybe PDA herd knows.