Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 267041 - gnome-extra/gnome-games-2.24.3 should be build with --disable-setgid
Summary: gnome-extra/gnome-games-2.24.3 should be build with --disable-setgid
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] GNOME (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Gentoo Linux Gnome Desktop Team
URL: http://bugzilla.gnome.org/show_bug.cg...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-04-21 23:54 UTC by Jeremy Guitton
Modified: 2009-05-31 15:47 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jeremy Guitton 2009-04-21 23:54:38 UTC 
It seems that --enable-setgid is bogus. I've tried 4 builds and see a part of the final info :

Build 1 :
>>> Installing gnome-extra/gnome-games-2.24.3
 * >>> SetGID: [chmod o-r] /usr/bin/gnomine ...                           [ ok ]
 * >>> SetGID: [chmod o-r] /usr/bin/gnobots2 ...                          [ ok ]
 * >>> SetGID: [chmod o-r] /usr/bin/gnibbles ...                          [ ok ]
 * >>> SetGID: [chmod o-r] /usr/bin/mahjongg ...                          [ ok ]
 * Installing GGZ modules ...                                             [ ok ]

Build 2 :
>>> Installing gnome-extra/gnome-games-2.24.3
 * >>> SetGID: [chmod o-r] /usr/bin/gnomine ...                           [ ok ]
 * >>> SetGID: [chmod o-r] /usr/bin/glines ...                            [ ok ]
 * >>> SetGID: [chmod o-r] /usr/bin/gnobots2 ...                          [ ok ]
 * >>> SetGID: [chmod o-r] /usr/bin/gnibbles ...                          [ ok ]
 * >>> SetGID: [chmod o-r] /usr/bin/gnotravex ...                         [ ok ]
 * >>> SetGID: [chmod o-r] /usr/bin/mahjongg ...                          [ ok ]
 * Installing GGZ modules ...                                             [ ok ]

Build 3 :
>>> Installing gnome-extra/gnome-games-2.24.3
 * >>> SetGID: [chmod o-r] /usr/bin/gnomine ...                           [ ok ]
 * >>> SetGID: [chmod o-r] /usr/bin/glines ...                            [ ok ]
 * >>> SetGID: [chmod o-r] /usr/bin/gnobots2 ...                          [ ok ]
 * >>> SetGID: [chmod o-r] /usr/bin/gnibbles ...                          [ ok ]
 * >>> SetGID: [chmod o-r] /usr/bin/mahjongg ...                          [ ok ]
 * Installing GGZ modules ...                                             [ ok ]

Build 4 :
>>> Installing gnome-extra/gnome-games-2.24.3
 * >>> SetGID: [chmod o-r] /usr/bin/gnomine ...                           [ ok ]
 * >>> SetGID: [chmod o-r] /usr/bin/gnobots2 ...                          [ ok ]
 * >>> SetGID: [chmod o-r] /usr/bin/gnibbles ...                          [ ok ]
 * >>> SetGID: [chmod o-r] /usr/bin/mahjongg ...                          [ ok ]
 * Installing GGZ modules ...                                             [ ok ]

Like you can see, not the same resultat for build with the same option !

SetGid is not necessary to play games, the only obligation, it must belong to the group games to play and record the scores.

Reproducible: Always

Steps to Reproduce:
Comment 1 Gilles Dartiguelongue (RETIRED) gentoo-dev 2009-04-22 23:11:31 UTC 
it feels like the problem comes from some inherit games functions. I'll have a deeper look later.
Comment 2 Mr. Bones. (RETIRED) gentoo-dev 2009-04-23 04:44:48 UTC 
Nothing to do with games.eclass.  It's a parallel make bug in the install.  Using MAKEOPTS=-j1 for example will always set the same 10 games to 2555.
Comment 3 Jeremy Guitton 2009-05-15 12:20:57 UTC 
I confirm, MAKEOPTS="-j1" solves the issue.

In this case, there isn't needed to be in the games group for access scores. The warn about games groups called by games_pkg_postinst in the ebuild can be removed with GAMES_SHOW_WARNING="no" before inherited files.

++'ll

Jeremy
Comment 4 Gilles Dartiguelongue (RETIRED) gentoo-dev 2009-05-31 12:46:35 UTC 
should be fixed in 2.26.2-r1. The cause was mixing data & exec rules paradigm in Makefile.am. Thanks for reporting.