Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 266937 - stabilise x11-wm/fvwm-2.5.27-r1
Summary: stabilise x11-wm/fvwm-2.5.27-r1
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: Desktop WM Team (OBSOLETE)
URL:
Whiteboard:
Keywords: STABLEREQ
: 276933 (view as bug list)
Depends on:
Blocks:
 
Reported: 2009-04-21 05:08 UTC by Kingsly John
Modified: 2009-10-02 17:37 UTC (History)
6 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
checks if imlib was compiled with USE=gtk (fvwm-2.5.26.ebuild,4.73 KB, text/plain)
2009-07-07 15:54 UTC, Jesús Guerrero Botella (RETIRED)
Details
proposal of ebuild for 2.5.27 with the right keywords + imlib[gtk] fix (fvwm-2.5.27.ebuild,4.83 KB, text/plain)
2009-07-28 14:16 UTC, Jesús Guerrero Botella (RETIRED)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Kingsly John 2009-04-21 05:08:44 UTC
fvwm-2.5.26 has been in portage for almost a year now and there are no open bugs
(also most of the open bugs against fvwm seem to be outdated/invalid/unrelated)

14 May 2008; David Shakaryan <omp@gentoo.org> +fvwm-2.5.26.ebuild:
Version bump; copied from my subversion repository.

While new versions of FVWM seem to be added to portage regularly, they aren't being stabilised.

The last version that was marked stable was released over 2.5 years ago ( http://fvwm.org/news/#2.5.18 )

Fvwm 2.5.18 released by upstream on 11-Sep-2006 and stabilised in portage from 14th to 20th Nov. 2006 for various arch.


Reproducible: Always

Steps to Reproduce:
1. emerge fvwm
2.
3.

Actual Results:  
installs a 2.5 year old release of fvwm 2.5.18-r1 http://fvwm.org/news/#2.5.18 / 

Expected Results:  
should install  2.5.26 which has been in portage for almost a year now
Comment 1 Jesús Guerrero Botella (RETIRED) gentoo-dev 2009-04-22 21:35:44 UTC
I've requested this many times myself, and right now, the only version marked stable in portage is 2.5.18, which is, whithout any doubt the less stable of the versions around that lives in the tree.

2.5.18 was released 2006-09-11. Lots of bugs have been resolved since then and there's absolutely no sense in recommending .18 as the stable version. If because of the gentoo policy we can't get .27 stabilized yet (it's not even in the tree), we should at least stabilize .26, and include .27, I already opened another bug for that some time ago.

http://bugs.gentoo.org/show_bug.cgi?id=261301
Comment 2 Jeremy Olexa (darkside) (RETIRED) archtester gentoo-dev Security 2009-07-07 15:37:39 UTC
*** Bug 276933 has been marked as a duplicate of this bug. ***
Comment 3 Jeremy Olexa (darkside) (RETIRED) archtester gentoo-dev Security 2009-07-07 15:39:00 UTC
Looks like a simple use dep is needed in the ebuild to avoid bug 238905
Comment 4 Jesús Guerrero Botella (RETIRED) gentoo-dev 2009-07-07 15:54:31 UTC
Created attachment 197087 [details]
checks if imlib was compiled with USE=gtk

Fixes bug #238905
Comment 5 Jesús Guerrero Botella (RETIRED) gentoo-dev 2009-07-07 15:56:55 UTC
(In reply to comment #3)
> Looks like a simple use dep is needed in the ebuild to avoid bug 238905
> 

Hopefully it's fixed now. Thanks for the quick response to #276933.
Comment 6 Christian Faulhammer (RETIRED) gentoo-dev 2009-07-08 06:42:56 UTC
I will request stabilisation of a fixed 2.5.27 ebuild in August.  Please remind me if it slips me. :)
Comment 7 Jeremy Olexa (darkside) (RETIRED) archtester gentoo-dev Security 2009-07-08 13:11:13 UTC
(In reply to comment #6)
> I will request stabilisation of a fixed 2.5.27 ebuild in August.  Please remind
> me if it slips me. :)
> 

Jesús: Scrap what we talked about in email then. Christian already did everything. I've edited metadata.xml to reflect reality now though ;)

Thanks Christian ;)
Comment 8 Jesús Guerrero Botella (RETIRED) gentoo-dev 2009-07-08 15:12:51 UTC
(In reply to comment #7)
> (In reply to comment #6)
> > I will request stabilisation of a fixed 2.5.27 ebuild in August.  Please remind
> > me if it slips me. :)
> > 
> 
> Jesús: Scrap what we talked about in email then. Christian already did
> everything. I've edited metadata.xml to reflect reality now though ;)
> 
> Thanks Christian ;)

Ok then, one or another way, which count is to get it done. 

Thanks to both of you.
Comment 9 Jesús Guerrero Botella (RETIRED) gentoo-dev 2009-07-08 16:56:11 UTC
(In reply to comment #6)
> I will request stabilisation of a fixed 2.5.27 ebuild in August.  Please remind
> me if it slips me. :)
> 

I shall.

Just to keep all the pieces together (even for myself since my memory isn't the best), I link here the two related bugs that we need to consider when stabilizing this critter.

xlockmore needs stabilization as well:
http://bugs.gentoo.org/show_bug.cgi?id=277043

fvwm needs some cleaning in the keywords:
http://bugs.gentoo.org/show_bug.cgi?id=277004

I also filled this one in my way to stabilize xlockmore, take a look since segfaults are never a good thing when you are planning on stabilization:
http://bugs.gentoo.org/show_bug.cgi?id=277061

Comment 10 Jesús Guerrero Botella (RETIRED) gentoo-dev 2009-07-12 20:21:19 UTC
(In reply to comment #9)
> (In reply to comment #6)
> > I will request stabilisation of a fixed 2.5.27 ebuild in August.  Please remind
> > me if it slips me. :)
> > 
> 
> I shall.
> 
> Just to keep all the pieces together (even for myself since my memory isn't the
> best), I link here the two related bugs that we need to consider when
> stabilizing this critter.
> 
> xlockmore needs stabilization as well:
> http://bugs.gentoo.org/show_bug.cgi?id=277043
> 
> fvwm needs some cleaning in the keywords:
> http://bugs.gentoo.org/show_bug.cgi?id=277004
> 
> I also filled this one in my way to stabilize xlockmore, take a look since
> segfaults are never a good thing when you are planning on stabilization:
> http://bugs.gentoo.org/show_bug.cgi?id=277061
> 

Just to keep track of the things, xlockmore has been fixed by removing the unicode support, and it has been stabilized for amd64 as well.

So, now there's nothing stopping us from stabilizing fvwm 2.5.27 once the time to do so comes.
Comment 11 Jesús Guerrero Botella (RETIRED) gentoo-dev 2009-07-28 14:16:28 UTC
Created attachment 199432 [details]
proposal of ebuild for 2.5.27 with the right keywords + imlib[gtk] fix

Since it is coming the time to stabilize it in some days, I submit the ebuild with keywords corrected, this also includes the imlib[gtk] fix of the previous ebuild, so marking it as deprecated in favor of this new one.
Comment 12 Jeremy Olexa (darkside) (RETIRED) archtester gentoo-dev Security 2009-07-28 14:52:06 UTC
(In reply to comment #11)
> Created an attachment (id=199432) [edit]
> proposal of ebuild for 2.5.27 with the right keywords + imlib[gtk] fix
> 
> Since it is coming the time to stabilize it in some days, I submit the ebuild
> with keywords corrected, this also includes the imlib[gtk] fix of the previous
> ebuild, so marking it as deprecated in favor of this new one.
> 

arch teams must stabilize the package and change keywords, not the maintainer. :)
Comment 13 Christian Faulhammer (RETIRED) gentoo-dev 2009-08-07 16:40:45 UTC
Please stabilise.
Comment 14 Christian Faulhammer (RETIRED) gentoo-dev 2009-08-08 23:09:18 UTC
x86 stable
Comment 15 nixnut (RETIRED) gentoo-dev 2009-08-09 11:33:39 UTC
ppc stable
Comment 16 Jesús Guerrero Botella (RETIRED) gentoo-dev 2009-08-09 12:34:33 UTC
(In reply to comment #15)
> ppc stable
> 

Please, stabilize amd64.
Comment 17 Tobias Klausmann (RETIRED) gentoo-dev 2009-08-10 15:11:01 UTC
That xlockmore bug (#277043) should've included alpha since it's a dep there, too. Another unmentioned dep is >=ftgl-2.1.3_rc5, so I tested and added that.

In summary: stabilized ftgl-2.1.3_rc5, xlockmore-5.28 and fvwm-2.5.27 on alpha.
Comment 18 Brent Baude (RETIRED) gentoo-dev 2009-09-05 00:28:59 UTC
ppc64 done
Comment 19 Markus Meier gentoo-dev 2009-09-05 22:13:36 UTC
amd64 stable
Comment 20 Tiago Cunha (RETIRED) gentoo-dev 2009-09-11 19:57:43 UTC
In the install phase, x11-wm/fvwm-2.5.27 gives the following warning:

chmod: cannot access `/var/tmp/portage/x11-wm/fvwm-2.5.27/image//etc/X11/Sessions/fvwm': No such file or directory
>>> Completed installing fvwm-2.5.27 into /var/tmp/portage/x11-wm/fvwm-2.5.27/image/

Apparently, the ebuild needs to issue the command dodir /etc/X11/Sessions before creating the file (and probably add || die to the echo call while there to prevent things like this in the future).

Should I proceed and mark it stable?
Comment 21 Christian Faulhammer (RETIRED) gentoo-dev 2009-09-11 20:51:53 UTC
(In reply to comment #20)
> Apparently, the ebuild needs to issue the command dodir /etc/X11/Sessions
> before creating the file (and probably add || die to the echo call while there
> to prevent things like this in the future).

 Thanks for the note, it has been fixed with a revbump (stable keywords transferred).
 
> Should I proceed and mark it stable?

 Yes, please.

Comment 22 Tiago Cunha (RETIRED) gentoo-dev 2009-09-11 22:05:10 UTC
(In reply to comment #21)
>  Thanks for the note, it has been fixed with a revbump (stable keywords
> transferred).

Thanks for the quick reply. However, dodir shouldn't try to create a directory called fvwm under /etc/X11/Sessions.
Comment 23 Jeremy Olexa (darkside) (RETIRED) archtester gentoo-dev Security 2009-09-11 23:40:14 UTC
+  11 Sep 2009; Jeremy Olexa <darkside@gentoo.org> fvwm-2.5.27-r1.ebuild:
+  Fix dodir call, Comment #22 bug 266937
Comment 24 Tiago Cunha (RETIRED) gentoo-dev 2009-09-12 00:01:19 UTC
sparc stable
Comment 25 Peter King 2009-09-12 01:23:29 UTC
(In reply to comment #23)
> +  11 Sep 2009; Jeremy Olexa <darkside@gentoo.org> fvwm-2.5.27-r1.ebuild:
> +  Fix dodir call, Comment #22 bug 266937

Still won't build on amd64 or x86 at the dodir call in the ebuild, during the install phase; dies with the message that fvwm is already a directory in /etc/X11/Sessions.
Comment 26 Christian Faulhammer (RETIRED) gentoo-dev 2009-09-12 10:04:27 UTC
(In reply to comment #25)
> (In reply to comment #23)
> > +  11 Sep 2009; Jeremy Olexa <darkside@gentoo.org> fvwm-2.5.27-r1.ebuild:
> > +  Fix dodir call, Comment #22 bug 266937
> 
> Still won't build on amd64 or x86 at the dodir call in the ebuild, during the
> install phase; dies with the message that fvwm is already a directory in
> /etc/X11/Sessions.

 No problems here.
Comment 27 Peter King 2009-09-12 20:42:23 UTC
> > Still won't build on amd64 or x86 at the dodir call in the ebuild, during the
> > install phase; dies with the message that fvwm is already a directory in
> > /etc/X11/Sessions.
> 
>  No problems here.

It builds successfully now, with the new dodir line:
    dodir /etc/X11/Sessions
in place of the old offending line:
    dodir /etc/X11/Sessions/${PN}
Thanks!
Comment 28 Raúl Porcel (RETIRED) gentoo-dev 2009-10-02 17:37:50 UTC
ia64 stable, closing