Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 266292 - media-libs/libsdl: confusing use flag descriptions for 'video', 'audio', 'joystick'
Summary: media-libs/libsdl: confusing use flag descriptions for 'video', 'audio', 'joy...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High trivial (vote)
Assignee: Gentoo Games
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-04-15 18:24 UTC by Patrick De Pinguin
Modified: 2009-04-24 23:35 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick De Pinguin 2009-04-15 18:24:45 UTC
Currently, the 'video', 'audio' and 'joystick' use flags to media-libs/libsdl are described as follows:
audio: Allow users to disable audio support completely (at their own risk)
joystick: Allow users to disable joystick support completely (at their own risk)
video: Allow users to disable video support completely (at their own risk)

To me, these use flags descriptions are confusing: they give me the impression that I have to *enable* the audio flag to allow users to disable audio support. However, the flag exists so that you can *disable* it to *remove* audio support.

The flag descriptions thus tell what will happen when disabling the flag, while other ('normal') use flags are described in wordings like "... adds support for": the description explains what will happen when enabling the flag.

My suggestion for the descriptions are:
audio: Adds audio support (disable at your own risk)
joystick: Adds joystick support (disable at your own risk)
video: Adds video support (disable at your own risk)


Reproducible: Always

Steps to Reproduce:
Comment 1 Mr. Bones. (RETIRED) gentoo-dev 2009-04-15 21:26:16 UTC
Well, they're turned on by default with + in the IUSE so the only change the user can make is to disable them.  So the use flag really does exist for the purpose of turning off those setting.
Comment 2 Mr. Bones. (RETIRED) gentoo-dev 2009-04-21 16:31:01 UTC
ok, removed the disable sense from the use flag description. 
Comment 3 Patrick De Pinguin 2009-04-22 15:58:34 UTC
Thanks for the fix.

I was wondering why what you said in comment #1 did not hold for me, but now I know: in /etc/make.conf I start with an empty USE flag with 
USE="-*". Apparently, this has preference over the ebuild IUSE...
Comment 4 SpanKY gentoo-dev 2009-04-24 23:35:38 UTC
-* has preference (by design) over everything else.  -* says you want everything turned off by default.