Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 263891 - [PATCHES][gnome-overlay] gnome-extra/gnome-power-manager-2.26 cpufreq regression
Summary: [PATCHES][gnome-overlay] gnome-extra/gnome-power-manager-2.26 cpufreq regression
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] GNOME (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Gentoo Linux Gnome Desktop Team
URL: http://bugzilla.gnome.org/show_bug.cg...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-03-26 19:13 UTC by Romain Perier (RETIRED)
Modified: 2009-03-31 10:34 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
import from http://bugs.gentoo.org/show_bug.cgi?id=263078 (gnome-power-manager-2.26.0-warn-flags.patch,3.40 KB, patch)
2009-03-26 19:14 UTC, Romain Perier (RETIRED)
Details | Diff
libhal-glib API patch (gnome-power-manager-2.26.0-cpufreq-libhal-glib.patch,21.14 KB, patch)
2009-03-26 19:15 UTC, Romain Perier (RETIRED)
Details | Diff
daemon and gnome-power-preferences patch (gnome-power-manager-2.26.0-cpufreq-support.patch,25.62 KB, patch)
2009-03-26 19:16 UTC, Romain Perier (RETIRED)
Details | Diff
glade sheet gnome-power-preference patch (gnome-power-manager-2.26.0-cpufreq-ui.patch,3.92 KB, patch)
2009-03-26 19:17 UTC, Romain Perier (RETIRED)
Details | Diff
translation updates (bz2) (gnome-power-manager-2.26.0-cpufreq-po.patch.bz2,627.17 KB, application/octet-stream)
2009-03-26 19:54 UTC, Romain Perier (RETIRED)
Details
new ebuild including patches (gnome-power-manager-2.26.0-r1.ebuild,3.05 KB, text/plain)
2009-03-26 19:55 UTC, Romain Perier (RETIRED)
Details
new translation patch (thanks to eva) (gnome-power-manager-2.26.0-cpufreq-po.patch,266.25 KB, patch)
2009-03-31 10:13 UTC, Romain Perier (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Romain Perier (RETIRED) gentoo-dev 2009-03-26 19:13:57 UTC
Hi,
This bug is a import from bug https://bugs.gentoo.org/show_bug.cgi?id=247614, to gpm-2.26. I needed to write new patches because gpm-2.26 code has changed since 2.24 version (especially about "notification" into gconf which was treated has signal in 2.24 and by gconf_client_notify_add directly in 2.26, and somes modules like gpm-conf have been removed implies some function renames etc...), so 2.24 patches are not compatibles (see the code for more details).

You will find in attachment 5 [details] patches and the new ebuild (version bump) including them :

- gnome-power-manager-2.26.0-warn-flags.patch : This patch i just import from bug http://bugs.gentoo.org/show_bug.cgi?id=263078 because without it the ebuild merge fails. (and i'm not unable to post an ebuild which doesn't work :p)

-gnome-power-manager-2.26.0-cpufreq-libhal-glib.patch: Add news module in libhal-glib API named "hal-cpufreq" for high level control of hal with dbus , and including Makefile.am update.

- gnome-power-manager-2.26.0-cpufreq-support.patch : Add two modules named gpm-cpufreq and egg-gconf (written by myself to simply factorize code because these functions has been removed due to gpm-conf deletion) , gpm-cpufreq is a module whose provide a gpm object for treat cpufreq in daemon (it treats changes in gconf tables and apply the correct policy depending of the profile too). This patch update the gpm-prefs-core module too for gui cpufreq interaction (~70 same as previous patches), and to finish make changes in gpm-manager module to add a instance of GpmCpufreq in the daemon.

- gnome-power-manager-2.26.0-cpufreq-ui.patch: update the gpm-prefs glade sheet for gnome-power-preferences gui (exactly the same as previous version)

- gnome-power-manager-2.26.0-cpufreq-po.patch : Translations import from gpm-2.22 for cpufreq gui combobox and hbox translations (need some testing)

and to finish the ebuild in a bump version :)

mrpouet.

Reproducible: Always
Comment 1 Romain Perier (RETIRED) gentoo-dev 2009-03-26 19:14:57 UTC
Created attachment 186341 [details, diff]
import from http://bugs.gentoo.org/show_bug.cgi?id=263078
Comment 2 Romain Perier (RETIRED) gentoo-dev 2009-03-26 19:15:36 UTC
Created attachment 186342 [details, diff]
libhal-glib API patch
Comment 3 Romain Perier (RETIRED) gentoo-dev 2009-03-26 19:16:40 UTC
Created attachment 186346 [details, diff]
daemon and gnome-power-preferences patch
Comment 4 Romain Perier (RETIRED) gentoo-dev 2009-03-26 19:17:13 UTC
Created attachment 186347 [details, diff]
glade sheet gnome-power-preference patch
Comment 5 Romain Perier (RETIRED) gentoo-dev 2009-03-26 19:54:58 UTC
Created attachment 186351 [details]
translation updates (bz2)
Comment 6 Romain Perier (RETIRED) gentoo-dev 2009-03-26 19:55:52 UTC
Created attachment 186353 [details]
new ebuild including patches
Comment 7 Romain Perier (RETIRED) gentoo-dev 2009-03-26 19:57:20 UTC
Please be careful about gnome-power-manager-2.26.0-cpufreq-po.patch because it's compressed in bzip2 (the original piece was too big for update on the server)
Comment 8 Tommaso Pasini 2009-03-27 11:18:55 UTC
Good work.
Please, try to launch the command 'gconftool-2 /apps/gnome-power-manager/ui/cpufreq_show' as stated on the ebuild and look if it works: here nothing happens.

Moreover, set this bug to block the tracker for gnome 2.26.
Comment 9 Romain Perier (RETIRED) gentoo-dev 2009-03-27 11:34:00 UTC
if you didn't use my patches it's normal, because the entire feature cpufreq in gpm has been completely removed and combobox in the gnome-power-preferences too, this command can't have any effect because show_cpufreq in gconf table is treated only in this patches and was removed before (see prefs_setup_ac function in gpm-prefs-core.c), it was a forget by myself (this postinst comment was in the previous ebuild, don't pay attention for this ebuild if you use these patches).
Comment 10 Gilles Dartiguelongue (RETIRED) gentoo-dev 2009-03-29 22:02:39 UTC
added to the overlay. You might want to take a look at the slimmed down po patch.
Thanks for reporting and porting patches.
Comment 11 Romain Perier (RETIRED) gentoo-dev 2009-03-31 10:13:20 UTC
Created attachment 186861 [details, diff]
new translation patch (thanks to eva)
Comment 12 Romain Perier (RETIRED) gentoo-dev 2009-03-31 10:22:25 UTC
the bug was upstream http://bugzilla.gnome.org/show_bug.cgi?id=577434