Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 263666 - games-strategy/wesnoth-1.6.1 installs invalid .desktop files
Summary: games-strategy/wesnoth-1.6.1 installs invalid .desktop files
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Games (show other bugs)
Hardware: All Linux
: High minor (vote)
Assignee: Gentoo Games
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-03-24 21:10 UTC by Alexandre Rostovtsev (RETIRED)
Modified: 2009-04-16 06:23 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Patch for wesnoth-1.6.1 (wesnoth-1.6.1-fix-desktop-entries.patch,3.44 KB, patch)
2009-04-13 23:40 UTC, Ulrich Müller
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexandre Rostovtsev (RETIRED) gentoo-dev 2009-03-24 21:10:59 UTC
games-strategy/wesnoth-1.6a ebuild does not install any .desktop files, forcing the user to launch the game from a terminal.

Previous versions of the package (e.g. wesnoth-1.4.7-r1) properly installed wesnoth.desktop and wesnoth_editor.desktop
Comment 1 Mr. Bones. (RETIRED) gentoo-dev 2009-03-24 21:34:12 UTC
fixed.  thanks for the bug report.
Comment 2 Ulrich Müller gentoo-dev 2009-04-13 22:58:35 UTC
Now it installs desktop files, but they have a wrong category ("GameStrategyGame", some semicolons missing?), so it doesn't appear in the menu under "Games".

$ desktop-file-validate wesnoth.desktop
wesnoth.desktop: error: value "1.6" for key "Version" in group "Desktop Entry" is not a known version
wesnoth.desktop: warning: value "wesnoth-icon.png" for key "Icon" in group "Desktop Entry" is an icon name with an extension, but there should be no extension as described in the Icon Theme Specification if the value is not an absolute path
wesnoth.desktop: error: value "GameStrategyGame" for string list key "Categories" in group "Desktop Entry" does not have a semicolon (';') as trailing character
Comment 3 Ulrich Müller gentoo-dev 2009-04-13 23:40:24 UTC
Created attachment 188274 [details, diff]
Patch for wesnoth-1.6.1

Looks like CMake is eating the semicolons. Attached patch will fix it. (I took an easy solution, assuming that we don't need any BINARY_SUFFIX for the name of the executable.)
Comment 4 Mr. Bones. (RETIRED) gentoo-dev 2009-04-16 06:23:41 UTC
worked around the mess from upstream.