Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 262511 - Ant 1.7.1 has a bug when building packages with pkg-info.class annotation data
Summary: Ant 1.7.1 has a bug when building packages with pkg-info.class annotation data
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Java (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Java team
URL: https://issues.apache.org/bugzilla/sh...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-03-15 08:21 UTC by John W Eckhart
Modified: 2009-03-17 12:54 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Ebuild containing a backported fix for ant-core to correct pkg-config.class problems (ant-core-1.7.1-r3.ebuild,2.79 KB, text/plain)
2009-03-15 08:23 UTC, John W Eckhart
Details
Backported patch for ant-core to correct pkg-info.class problems (ant-core-1.7.1-pkg-info.patch,9.95 KB, patch)
2009-03-15 08:24 UTC, John W Eckhart
Details | Diff
Patch fixed for Java 1.4 (1.7.1-pkg-info.patch,9.11 KB, patch)
2009-03-17 07:50 UTC, Martin von Gagern
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description John W Eckhart 2009-03-15 08:21:54 UTC
Apache has confirmed and fixed this problem, however, pending a new release of ant, I think this is important enough to patch within the gentoo tree. I've created an ebuild and patch to deal specifically with this and installed it in my overlay. Additionally, I've attached both ebuild and patch to the bug.

The patch was taken from ant's svn:
svn diff -r 672109:743910 http://svn.apache.org/repos/asf/ant/core/trunk/src/main/org/apache/tools/ant/taskdefs/Javac.java

Where 672109 is the revision of the 1.7.1 release tag and 743910 is the revision of the fix. The two prereq changes that get pulled in to JAvac.java are self-contained and need no other changes to the tree.


Reproducible: Always

Steps to Reproduce:
1. One such example of the error occurs when building JBoss Seam 2.1.1 GA from source. See https://jira.jboss.org/jira/browse/JBSEAM-3386 for more details.
2. See Apache's Bugzilla for more details: https://issues.apache.org/bugzilla/show_bug.cgi?id=43114
Comment 1 John W Eckhart 2009-03-15 08:23:25 UTC
Created attachment 185029 [details]
Ebuild containing a backported fix for ant-core to correct pkg-config.class problems
Comment 2 John W Eckhart 2009-03-15 08:24:04 UTC
Created attachment 185031 [details, diff]
Backported patch for ant-core to correct pkg-info.class problems
Comment 3 Petteri Räty (RETIRED) gentoo-dev 2009-03-15 12:17:23 UTC
Patch added. Thanks for reporting. In the future there's no need to attach full ebuild files if you are only adding a single epatch line. All developers or users taking patches from bugzilla should know where to put the epatch lines. Adding epatch yourself is faster than having to diff etc.
Comment 4 Martin von Gagern 2009-03-17 07:50:22 UTC
Created attachment 185284 [details, diff]
Patch fixed for Java 1.4

(In reply to comment #2)
> Backported patch for ant-core to correct pkg-info.class problems

That patch breaks compatibility with Java 1.4 due to its use of java.lang.Long.valueOf(long). Upstream realized and addressed this problem as well: http://fisheye6.atlassian.com/changelog/ant/?cs=744132

The attached patch backports only changesets 743910 and 744132, without the pretty unrelated changesets 693732 and 738761 included in the patch from comment #2. In case you would rather have them as well, creating a corresponding diff is even easier.

References:
http://fisheye6.atlassian.com/browse/ant/core/trunk/src/main/org/apache/tools/ant/taskdefs/Javac.java?r1=738761&r2=744132
http://fisheye6.atlassian.com/browse/ant/core/trunk/src/main/org/apache/tools/ant/taskdefs/Javac.java
Comment 5 Petteri Räty (RETIRED) gentoo-dev 2009-03-17 12:54:43 UTC
Patch updated.