Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 260920 - media-video/ogmrip: uses -Werror during build
Summary: media-video/ogmrip: uses -Werror during build
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Olivier Rolland
URL: http://blog.flameeyes.eu/2009/02/25/f...
Whiteboard:
Keywords:
Depends on:
Blocks: werror
  Show dependency tree
 
Reported: 2009-03-02 14:41 UTC by Diego Elio Pettenò (RETIRED)
Modified: 2009-03-22 13:21 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
ogmrip-werror.patch (ogmrip-werror.patch,426 bytes, patch)
2009-03-22 13:00 UTC, Olivier Rolland
Details | Diff
ogmrip-0.12.3.ebuild (ogmrip-0.12.3.ebuild,2.19 KB, text/plain)
2009-03-22 13:01 UTC, Olivier Rolland
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Diego Elio Pettenò (RETIRED) gentoo-dev 2009-03-02 14:41:15 UTC
Hello,

you're receiving this canned bug because the package in summary uses the flag -Werror during build, which transforms warnings in errors, and is prone to break software when new GCC releases are added to Gentoo.

Please make sure your package does not use -Werror during build, so that it can be more future-proof for the new GCC releases.

Thanks,
Diego
Comment 1 Olivier Rolland 2009-03-22 13:00:40 UTC
Created attachment 185850 [details, diff]
ogmrip-werror.patch

This patch removes -Werror.
Comment 2 Olivier Rolland 2009-03-22 13:01:13 UTC
Created attachment 185852 [details]
ogmrip-0.12.3.ebuild

This ebuild applies the -werror patch.
Comment 3 Peter Alfredsen (RETIRED) gentoo-dev 2009-03-22 13:21:24 UTC
Since this is an EAPI=2 ebuild, I used src_prepare instead of src_unpack to apply the patch

+  22 Mar 2009; Peter Alfredsen <loki_val@gentoo.org>
+  +files/ogmrip-werror.patch, ogmrip-0.12.3.ebuild:
+  Fix bug 260920, ogmrip uses -Werror. Proxy-commit for Olivier Rolland
+  <billl@users.sf.net>. Thanks to Diego E. 'Flameeyes' Pettenò
+  <flameeyes@gentoo.org> for the report.
+