Bug 260308 – net-misc/ssh-askpass-fullscreen-0.4-r1 cannot grab keyboard

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Ulrich Müller 2009-02-25 22:10:51 UTC]

When ssh-askpass-fullscreen is executed, a dialog box with the following warning message appears:
,----
| Could not grab keyboard. A malicious client may be eavesdropping on your
| session.
`----
After dismissing the dialog box, the passphrase can be entered.


Adding -Wall to CFLAGS shows the culprit:
ssh-askpass-fullscreen.c:250: warning: 'grab_tries' may be used uninitialized in this function

[Comment 1 Ulrich Müller 2009-02-25 22:15:43 UTC]

Created attachment 183198 [details, diff]
ssh-askpass-fullscreen-0.4-fix-grab.patch

[Comment 2 Ulrich Müller 2009-02-25 22:27:48 UTC]

Fixed in -r2 as discussed on IRC.

[Comment 3 Jeremy Olexa (darkside) (RETIRED) 2009-02-26 00:50:39 UTC]

(In reply to comment #1)
> Created an attachment (id=183198) [edit]
> ssh-askpass-fullscreen-0.4-fix-grab.patch
> 

Oh, one line patch nice. Do you know how to fix this warning too?:

ssh-askpass-fullscreen.c: In function 'passphrase_dialog':
ssh-askpass-fullscreen.c:275: warning: passing argument 1 of 'gdk_pixbuf_new_from_xpm_data' from incompatible pointer type

[Comment 4 Ulrich Müller 2009-02-26 06:33:09 UTC]

> Do you know how to fix this warning too?:
> 
> ssh-askpass-fullscreen.c: In function 'passphrase_dialog':
> ssh-askpass-fullscreen.c:275: warning: passing argument 1 of
> 'gdk_pixbuf_new_from_xpm_data' from incompatible pointer type

-static char *ocean_stripes[] = {
+static const char *ocean_stripes[] = {

That's something for upstream, I would say.

[Comment 5 Jeremy Olexa (darkside) (RETIRED) 2009-02-26 23:16:26 UTC]

(In reply to comment #4)

> -static char *ocean_stripes[] = {
> +static const char *ocean_stripes[] = {
> 
> That's something for upstream, I would say.

There is no more upstream at this point. I fixed that warning and did a massive QA cleanup of the ebuild. Thanks for tracking the issue down!