Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 259860 - app-shells/bash: need info on bash-3.2-process-subst.patch
Summary: app-shells/bash: need info on bash-3.2-process-subst.patch
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Core system (show other bugs)
Hardware: All FreeBSD
: High normal (vote)
Assignee: Gentoo/BSD Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-02-21 23:05 UTC by SpanKY
Modified: 2009-02-24 19:09 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description SpanKY gentoo-dev 2009-02-21 23:05:45 UTC
we're carrying a one line patch against bash: bash-3.2-process-subst.patch

unfortunately, there's no info on how this works or any urls (mailing lists/bug reports/blah blah).  all i've got is this:

  02 Nov 2006; Roy Marples <uberlord@gentoo.org>
  +files/bash-3.2-process-subst.patch, +bash-3.2_p3-r1.ebuild:
  Add a patch to fix process substitution on BSD.

can someone give real info so we can push this upstream
Comment 1 Roy Marples 2009-02-22 20:43:39 UTC
I pushed it upstream ages ago and Chet implies he's fixed it already locally.

http://www.nabble.com/-PATCH--Fix--dev-fd-detection-on-FreeBSD-td8119355.html
Comment 2 SpanKY gentoo-dev 2009-02-22 20:53:53 UTC
that's a different patch (bash-3.2-dev-fd-test-as-user.patch) ;)

and yes, he has fixed that one in a different way in bash-4.0
Comment 3 Roy Marples 2009-02-22 21:00:10 UTC
Try this link instead :P

http://www.archivum.info/gnu.bash.bug/2006-11/msg00000.html

I was a good boy in Gentoo - all my patches pushed upstream.
Comment 4 SpanKY gentoo-dev 2009-02-22 21:05:26 UTC
the patch isnt documented with links/real info, so not good enough!

can you test bash-4.0 with that patch removed from the ebuild to make sure it still works ?  my reading of the thread is that because the /dev/fd test was breaking crap, this patch worked around the issue.  but with the /dev/fd test now fixed, this patch should no longer be needed.
Comment 5 Roy Marples 2009-02-22 21:20:26 UTC
I don't use any FreeBSD variant, right now, but I'm sure the Gentoo team can test it.
Comment 6 SpanKY gentoo-dev 2009-02-22 21:35:11 UTC
bsd is already in the assigned field ;)
Comment 7 SpanKY gentoo-dev 2009-02-24 17:17:37 UTC
actually, this seems to cause misbehavior with bash-4, so i'm dropping it there

$ sleep 60
^Z
[1]+  Stopped                 sleep 60
$ echo|cat
bash: warning: deleting stopped job 1 with process group 27967
$

that "bash: warning: ...." should not have occurred
Comment 8 Timothy Redaelli (RETIRED) gentoo-dev 2009-02-24 18:53:31 UTC
We don't need that patch anymore :)

localhost bash # uname -a
FreeBSD localhost 7.1-RELEASE FreeBSD Gentoo 7.1 #0: Mon Feb 23 23:18:24 CET 2009     root@livecd:/usr/src/sys-7.1-r0/i386/compile/GENERIC  i386
localhost bash # /var/tmp/portage/app-shells/bash-4.0/work/bash-4.0/bash -c 'cat < <(ls)'
ChangeLog
Manifest
<cut>
Comment 9 SpanKY gentoo-dev 2009-02-24 19:09:17 UTC
ok, thanks