Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 258187 - app-backup/bacula invalid use of logrotate USE flag
Summary: app-backup/bacula invalid use of logrotate USE flag
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High QA (vote)
Assignee: Thomas Beierlein
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 198901
  Show dependency tree
 
Reported: 2009-02-08 18:35 UTC by Thilo Bangert (RETIRED) (RETIRED)
Modified: 2013-05-01 15:10 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Thilo Bangert (RETIRED) (RETIRED) gentoo-dev 2009-02-08 18:35:06 UTC
Having a use flag for installing one plaintext file doesn't make sense.

- ebuilds don't handle this consistently (some just use this flag for
doins/newins a script to /etc/logrotate.d, some add app-admin/logrotate
dependency, some install the scripts unconditionally)

- users can use INSTALL_MASK if diskspace is an issue for them (extremely
unlikely), plus the installed scripts have no effect until you install
logrotate anyway, so if you don't want this functionality, just don't install
it, if you do, emerge logrotate and you don't have to care about anything else
and no need to re-emerge anything).

(BTW, the usage of this flag in net-proxy/squid really is special, don't quite
understand why not just use the rotate functionality squid itself has.)

So, please nuke the use flag and install the stuff unconditionally.

see #198901 and gentoo-dev for more info.
Comment 1 Wolfram Schlich (RETIRED) gentoo-dev 2009-09-09 07:45:43 UTC
Fixed in 3.0.2.
Comment 2 Jeroen Roovers (RETIRED) gentoo-dev 2010-11-04 19:50:21 UTC
It's still in =app-backup/bacula-2.4.1-r1:

    logrotate? ( app-admin/logrotate )
[..]
        # the logrotate configuration
        if useq logrotate; then
            diropts -m0755
            insinto /etc/logrotate.d
            insopts -m0644
            newins "${S}"/scripts/logrotate bacula
        fi


as well as in metadata.xml:

                <flag name='logrotate'>Install support files for logrotate</flag>
Comment 3 Thomas Beierlein gentoo-dev 2010-11-04 20:08:25 UTC
(In reply to comment #2)
> It's still in =app-backup/bacula-2.4.1-r1:
> 

Good timing, I was just about to drop the old versions :-). 

+  04 Nov 2010; Thomas Beierlein <tomjbe@gentoo.org>
+  -files/2.4.1/2.4.1-mount.patch, -files/2.4.1/2.4.1-mysql-timeout.patch,
+  -files/2.4.1/2.4.1-sd-crash.patch,
+  -files/2.4.1/bacula-default-configs.patch, -files/2.4.1/bacula-dir-conf,
+  -files/2.4.1/bacula-dir-init, -files/2.4.1/bacula-fd-conf,
+  -files/2.4.1/bacula-fd-init, -files/2.4.1/bacula-gnomesu2gksu.diff,
+  -files/2.4.1/bacula-sd-conf, -files/2.4.1/bacula-sd-init,
+  -files/3.0.3/bacula-3.0.3-openssl-1.patch,
+  -files/3.0.3/bacula-default-configs.patch, -files/3.0.3/bacula-dir-conf,
+  -files/3.0.3/bacula-dir-init, -files/3.0.3/bacula-fd-conf,
+  -files/3.0.3/bacula-fd-init, -files/3.0.3/bacula-gnomesu2gksu.diff,
+  -files/3.0.3/bacula-sd-conf, -files/3.0.3/bacula-sd-init,
+  -bacula-2.4.1-r1.ebuild, -bacula-3.0.3.ebuild, metadata.xml:
+  Cleanup old versions.
+
Comment 4 Ortwin Glueck 2013-04-27 09:47:42 UTC
Except when you do have logrotate installed (which is quite normal I think), then this removes the possibility to not install a logrotate script. And the one that is installed by this ebuild is broken. Just look at the path!
Comment 5 Thomas Beierlein gentoo-dev 2013-05-01 15:10:54 UTC
(In reply to comment #4)
> Except when you do have logrotate installed (which is quite normal I think),
> then this removes the possibility to not install a logrotate script. And the
> one that is installed by this ebuild is broken. Just look at the path!

Please next time add a new bug or reopen that bug at least. Thanks.

It would be helpful if you had put some more information about the version in question and your 'emerge --info' output in your comment.

Anyway... Thanks for pointing it out. Fixed ebuild for bacula-5.2.13 is in tree now.

+  01 May 2013; Thomas Beierlein <tomjbe@gentoo.org> bacula-5.2.13.ebuild:
+  Fix logrotate config file (bug 258187, comment #4). Thanks Ortwin.
+