Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 257489 - media-sound/audacity-1.3.7 fails to compile
Summary: media-sound/audacity-1.3.7 fails to compile
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Professional Audio Applications Maintainers
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-02-03 14:49 UTC by Patrick Lauer
Modified: 2009-02-19 07:53 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Completely remove debug flag (bug257489a.patch,959 bytes, patch)
2009-02-03 15:53 UTC, Martin von Gagern
Details | Diff
Only remove after space (bug257489b.patch,977 bytes, patch)
2009-02-07 10:39 UTC, Martin von Gagern
Details | Diff
Avoid overriding of debug and optimization flags (257489c.patch,1.07 KB, patch)
2009-02-10 12:22 UTC, Martin von Gagern
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick Lauer gentoo-dev 2009-02-03 14:49:40 UTC
make[2]: Entering directory `/var/tmp/portage/media-sound/audacity-1.3.7/work/audacity-src-1.3.7/lib-src/sbsms'                           
Making all in src                                                                                                                         
make[3]: Entering directory `/var/tmp/portage/media-sound/audacity-1.3.7/work/audacity-src-1.3.7/lib-src/sbsms/src'                       
make  all-am                                                                                                                              
make[4]: Entering directory `/var/tmp/portage/media-sound/audacity-1.3.7/work/audacity-src-1.3.7/lib-src/sbsms/src'                       
/bin/sh ../libtool --tag=CXX   --mode=compile x86_64-pc-linux-gnu-g++ -DHAVE_CONFIG_H -I.    -funroll-loops -I../include -fstrict-aliasing    -march=k8 -pipe gdb -O3 -fomit-frame-pointer -MT pitch.lo -MD -MP -MF .deps/pitch.Tpo -c -o pitch.lo pitch.cpp                        
libtool: compile:  x86_64-pc-linux-gnu-g++ -DHAVE_CONFIG_H -I. -funroll-loops -I../include -fstrict-aliasing -march=k8 -pipe gdb -O3 -fomit-frame-pointer -MT pitch.lo -MD -MP -MF .deps/pitch.Tpo -c pitch.cpp -o pitch.o                                                          
x86_64-pc-linux-gnu-g++: gdb: No such file or directory                                                                                   
make[4]: *** [pitch.lo] Error 1                                                                                                           
make[4]: Leaving directory `/var/tmp/portage/media-sound/audacity-1.3.7/work/audacity-src-1.3.7/lib-src/sbsms/src'                        
make[3]: *** [all] Error 2                                                                                                                
make[3]: Leaving directory `/var/tmp/portage/media-sound/audacity-1.3.7/work/audacity-src-1.3.7/lib-src/sbsms/src'                        
make[2]: *** [all-recursive] Error 1                                                                                                      
make[2]: Leaving directory `/var/tmp/portage/media-sound/audacity-1.3.7/work/audacity-src-1.3.7/lib-src/sbsms'                            
make[1]: *** [sbsms-recursive] Error 2                                                                                                    
make[1]: *** Waiting for unfinished jobs....                                                                                              
gtk/FileDialogPrivate.cpp: In function 'void gtk_filedialog_ok_callback(GtkWidget*, FileDialog*)':                                        
gtk/FileDialogPrivate.cpp:102: warning: ignoring return value of 'int chdir(const char*)', declared with attribute warn_unused_result     
/usr/bin/ar ruv FileDialog.a FileDialog.o gtk/FileDialogPrivate.o                                                                         
/usr/bin/ar: creating FileDialog.a                                                                                                        
a - FileDialog.o
a - gtk/FileDialogPrivate.o
x86_64-pc-linux-gnu-ranlib FileDialog.a
make[2]: Leaving directory `/var/tmp/portage/media-sound/audacity-1.3.7/work/audacity-src-1.3.7/lib-src/FileDialog'
make[1]: Leaving directory `/var/tmp/portage/media-sound/audacity-1.3.7/work/audacity-src-1.3.7/lib-src'
make: *** [audacity] Error 2
 *
 * ERROR: media-sound/audacity-1.3.7 failed.


Portage 2.2_rc23 (!..//usr/portage/profiles/default/linux/amd64/2008.0/desktop, gcc-4.3.3, glibc-2.9_p20081201-r1, 2.6.28 x86_64)
=================================================================                                                                
System uname: Linux-2.6.28-x86_64-AMD_Athlon-tm-_64_X2_Dual_Core_Processor_3800+-with-glibc2.2.5                                 
Timestamp of tree: Unknown                                                                                                       
ccache version 2.4 [enabled]                                                                                                     
app-shells/bash:     3.2_p48                                                                                                     
dev-java/java-config: 1.3.7-r1, 2.1.7                                                                                            
dev-lang/python:     2.5.4-r2                                                                                                    
dev-python/pycrypto: 2.0.1-r6                                                                                                    
dev-util/ccache:     2.4-r8                                                                                                      
dev-util/cmake:      2.6.2-r1                                                                                                    
sys-apps/baselayout: 2.0.0                                                                                                       
sys-apps/openrc:     0.4.2                                                                                                       
sys-apps/sandbox:    1.3.3                                                                                                       
sys-devel/autoconf:  2.13, 2.63                                                                                                  
sys-devel/automake:  1.5, 1.7.9-r1, 1.8.5-r3, 1.9.6-r2, 1.10.2                                                                   
sys-devel/binutils:  2.19                                                                                                        
sys-devel/gcc-config: 1.4.1                                                                                                      
sys-devel/libtool:   2.2.6a                                                                                                      
virtual/os-headers:  2.6.28-r1                                                                                                   
ACCEPT_KEYWORDS="amd64 ~amd64"                                                                                                   
CBUILD="x86_64-pc-linux-gnu"                                                                                                     
CFLAGS="-O2 -march=k8 -pipe -ggdb"                                                                                               
CHOST="x86_64-pc-linux-gnu"                                                                                                      
CONFIG_PROTECT="/etc /usr/kde/3.5/env /usr/kde/3.5/share/config /usr/kde/3.5/shutdown /usr/kde/4.1/env /usr/kde/4.1/share/config /usr/kde/4.1/shutdown /usr/kde/4.2/env /usr/kde/4.2/share/config /usr/kde/4.2/shutdown /usr/kde/live/env /usr/kde/live/share/config /usr/kde/live/shutdown /usr/share/config"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/env.d /etc/env.d/java/ /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo /etc/texmf/language.dat.d /etc/texmf/language.def.d /etc/texmf/updmap.d /etc/texmf/web2c /etc/udev/rules.d"
CXXFLAGS="-O2 -march=k8 -pipe -ggdb"
DISTDIR="/usr/portage/distfiles"
FEATURES="buildpkg ccache collision-protect distlocks fixpackages parallel-fetch preserve-libs protect-owned sandbox sfperms splitdebug strict unmerge-orphans userfetch"
GENTOO_MIRRORS="ftp://sunsite.informatik.rwth-aachen.de/pub/Linux/gentoo http://ftp.club-internet.fr/pub/mirrors/gentoo"
LDFLAGS="-Wl,-O1"
MAKEOPTS="-j3"
PKGDIR="/usr/portage/packages"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --compress --force --whole-file --delete --stats --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/home/pal/code/gentoo-x86/"
PORTDIR_OVERLAY="/home/pal/code/kde-testing"
SYNC="rsync://rsync.de.gentoo.org/gentoo-portage"
USE="3dnow 3dnowext X a52 aac acl acpi alsa amd64 berkdb bluetooth branding bzip2 cairo cdio cdparanoia cdr cli cracklib crypt cups curl dbus dga dri dts dv dvd dvdr dvdread eds emboss encode esd evo fam firefox flac fortran ftp gdbm ggi gif gpm iconv ipv6 isdnlog jack jpeg jpeg2k kde kdeenablefinal kdeprefix kpathsea ladspa libnotify lzo mad md5sum midi mikmod mmx mmxext mng mp2 mp3 mpeg mudflap multilib musepack nas ncurses nls nptl nptlonly ogg openal opengl openmp pam pcre pdf perl png pnm ppds pppd python qt3 qt3support qt4 quicktime rar readline reflection rtc sasl sdl session slang speex spell spl sqlite sse sse2 ssl startup-notification svg sysfs tcpd tga theora tiff truetype unicode usb vorbis webkit x264 xml xorg xv xvid xvmc zlib" ALSA_CARDS="ali5451 als4000 atiixp atiixp-modem bt87x ca0106 cmipci emu10k1x ens1370 ens1371 es1938 es1968 fm801 hda-intel intel8x0 intel8x0m maestro3 trident usb-audio via82xx via82xx-modem ymfpci" ALSA_PCM_PLUGINS="adpcm alaw asym copy dmix dshare dsnoop empty extplug file hooks iec958 ioplug ladspa lfloat linear meter mmap_emul mulaw multi null plug rate route share shm softvol" APACHE2_MODULES="actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" ELIBC="glibc" INPUT_DEVICES="keyboard mouse evdev" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" USERLAND="GNU" VIDEO_CARDS="vga vesa nv"
Unset:  CPPFLAGS, CTARGET, EMERGE_DEFAULT_OPTS, FFLAGS, INSTALL_MASK, LANG, LC_ALL, LINGUAS, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS
Comment 1 Martin von Gagern 2009-02-03 15:43:36 UTC
Same here. The aspect of the configuration which triggers this is the -ggdb flag in CXXFLAGS. The actual cause lies in lib-src/sbsms/configure{,.in}:

CXXFLAGS=`echo $CXXFLAGS | sed -e "s/-g//" -e "s/-O2//"`

This removes the "-g" of "-ggdb" without removing the "gdb". I'll write a patch.
Comment 2 Martin von Gagern 2009-02-03 15:53:48 UTC
Created attachment 180821 [details, diff]
Completely remove debug flag

This patch fixes the intention of the upstream configuration mechanism by completely removing the debug flag, even if it is "-ggdb" or similar instead of only "-g".

There is an un-Gentoo-ish feel to this manipulation of compiler flags. Maybe this whole line modifying the CXXFLAGS should be completely removed, so that the admin retains full control over compiler flags. But on the other hand, maybe there is a good reason for this line. I haven't investigated far enough to decide this yet.
Comment 3 Martin von Gagern 2009-02-03 16:19:57 UTC
Upstream changeset which introduced the CXXFLAGS modification: http://sbsms.svn.sourceforge.net/viewvc/sbsms?view=rev&revision=21

I just created a bug report for this upstream, maybe this can shed some light as to the intention of this CXXFLAGS modification as well: https://sourceforge.net/tracker2/?func=detail&aid=2561247&group_id=177794&atid=882654
Comment 4 emerald 2009-02-07 10:10:32 UTC
It screws around with any flag, that has a '-g' inside, such as --param 
max-gcse-passes=N
Comment 5 Martin von Gagern 2009-02-07 10:39:53 UTC
Created attachment 181233 [details, diff]
Only remove after space

(In reply to comment #3)
> I just created a bug report for this upstream, maybe this can shed some light
> as to the intention of this CXXFLAGS modification as well:
> https://sourceforge.net/tracker2/?func=detail&aid=2561247&group_id=177794&atid=882654

No reaction yet. Looks like that tracker2 URL might not open directly without some kind of cookie, so you might want to use this URL instead:
http://sourceforge.net/tracker/index.php?func=detail&aid=2561247&group_id=177794&atid=882654

(In reply to comment #4)
> It screws around with any flag, that has a '-g' inside, such as --param 
> max-gcse-passes=N

True. This patch might help to solve that problem. Not tested, though.
Comment 6 Martin von Gagern 2009-02-10 12:22:16 UTC
Created attachment 181538 [details, diff]
Avoid overriding of debug and optimization flags

I had another look at the configure script. With debug disabled, CXXFKAGS is set to include -O3, so this is not one of the packages allergic to heavy optimization. On the other hand, both with and without debug enabled, the CXXFLAGS will be modified in some crucial way, affecting both debug code generation and code optimization.

This kind of customization, where a package (or part of a package like here) imposes flags, overriding those chosen by the system admin, for no discernible reason, is not how things should be in the Gentoo world.

The attached patch will remove a block of CXXFLAGS modifications, leaving settings for debug code generation and optimization as make.conf specifies them. audacity builds all right here with this patch in place.
Comment 7 Martin von Gagern 2009-02-16 16:01:18 UTC
(In reply to comment #6)
> Created an attachment (id=181538) [edit]
> Avoid overriding of debug and optimization flags

I would consider that patch ready for inclusion into the portage tree. Unfortunately I'm not powerful enough to set the Inclusion keyword on this bug report here. Pleas include in any case.
Comment 8 Patrick Lauer gentoo-dev 2009-02-19 07:53:48 UTC
+  19 Feb 2009; Patrick Lauer <patrick@gentoo.org>
+  +files/audacity-1.3.7-cflags.patch:
+  Fixing bad CFLAG filtering by upstream. Patch by Martin von Gagern. Fixes
+  #257489

Thanks for the patch, upstream should be slapped for such broken CFLAG filtering.