Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 25665 - sys-apps/cpufreqd-1.0 doesn't work with sysfs
Summary: sys-apps/cpufreqd-1.0 doesn't work with sysfs
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Core system (show other bugs)
Hardware: x86 Linux
: High minor (vote)
Assignee: Michael Imhof (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-07-31 13:19 UTC by Gustavo Zacarias (RETIRED)
Modified: 2003-10-06 15:29 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
proposed patch to be put into sys-apps/cpufreqd/files (sysfs.diff,403 bytes, patch)
2003-10-06 09:58 UTC, Dominik Brodowski
Details | Diff
proposed replacement ebuild (cpufreqd-1.0.1-r1.ebuild,909 bytes, text/plain)
2003-10-06 09:59 UTC, Dominik Brodowski
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Gustavo Zacarias (RETIRED) gentoo-dev 2003-07-31 13:19:16 UTC
cpufreqd 1.0 doesn't work with the new sysfs-style interface, just uses the old
procfs-based one.


Reproducible: Always
Steps to Reproduce:
1. emerge cpufreqd
2. /etc/init.d/cpufreqd start

Actual Results:  
 * CPUFreq support has not been compiled into the kernel


Expected Results:  
Should work both ways. Sooner or later the procfs-style interface will be
dropped from 2.6 kernels (probably more sooner than later).


Ugly solution: enable old-style procfs interface in 2.6.0-* while it lasts.
Nice solution: we should upgrade to cpufreqd 1.0.1 which supports both methods :)
Comment 1 Michael Imhof (RETIRED) gentoo-dev 2003-08-01 16:33:35 UTC
Nice solution: we should upgrade to cpufreqd 1.0.1 which supports both methods :)

I decided to use the nice solution. Bumped the version to 1.0.1
I hope this resolves this bug.

If not then please reopen it.


Thanks for your help.
Comment 2 Gustavo Zacarias (RETIRED) gentoo-dev 2003-08-04 13:15:37 UTC
Requires additional fix in /etc/init.d/cpufreqd to allow the startup to work on sysfs-only interface.

" if [ ! -e /proc/cpufreq ] ; then "

should be 

" if [ ! -e /proc/cpufreq -a ! -e /sys/devices/system/cpu/cpu0/cpufreq ] ; then "

Sorry to have missed it before.
Comment 3 Michael Imhof (RETIRED) gentoo-dev 2003-08-04 13:55:32 UTC
Did you post that updwards?
Do the include a init.d file that includes this fix in the next release?
Comment 4 Gustavo Zacarias (RETIRED) gentoo-dev 2003-08-05 05:53:17 UTC
Contacted author (Mattia Dongili), told me he'll fix it tonight.
Comment 5 Michael Imhof (RETIRED) gentoo-dev 2003-08-06 02:05:08 UTC
Great!

As soon as he fixed it and i checked in the new ebuild i'll close this bug.
Thanks for your help!
Comment 6 Michael Imhof (RETIRED) gentoo-dev 2003-08-15 13:59:16 UTC
I can't find acorrected ebuild or bumped package (and i think the package should get bumped as the init-script is inside the package) on cpufreqd.sf.net.

Could you please check and ask him again?
Comment 7 Michael Imhof (RETIRED) gentoo-dev 2003-09-09 10:33:37 UTC
Gustavo Zacarias <gustavo@zacarias.com.ar>: Could you please remind the author of cpufreqd to provide a fixed version (as he told you so)?

I can't do anything on this bug if i'm not getting a corrected version from upstream.
Comment 8 Gustavo Zacarias (RETIRED) gentoo-dev 2003-09-17 10:47:41 UTC
We should probably close this since the freq interface isn't completely defined on 2.6.x kernels yet. Also it should be ~x86.
Sorry for the delay.
Comment 9 Dominik Brodowski 2003-10-05 16:41:10 UTC
> ------- Additional Comment #8 From Gustavo Zacarias 2003-09-17 10:47 PST
-------
> We should probably close this since the freq interface isn't completely
defined 
> on 2.6.x kernels yet. 
After many sysfs shuffles during 2.5., the _current_ cpufreq sysfs interface
[2.6-testX] will most likely be what's in 2.6.x, too.

So, can you apply the "patch" of comment #2 and push cpufreqd-1.0.1-r1, please?
If not, I'll contact Mattia and ask him for the updated "upstream" release.
Comment 10 Dominik Brodowski 2003-10-06 09:58:25 UTC
Created attachment 18858 [details, diff]
proposed patch to be put into sys-apps/cpufreqd/files

MD5 823074606ab9025af1210226fd2a626a sysfs.diff 403
updated ebuild will follow in a moment
Comment 11 Dominik Brodowski 2003-10-06 09:59:24 UTC
Created attachment 18859 [details]
proposed replacement ebuild

MD5 3d408991f66e9b7b8ce858e30e970b54 cpufreqd-1.0.1-r1.ebuild 909
Comment 12 Michael Imhof (RETIRED) gentoo-dev 2003-10-06 15:29:11 UTC
I checked in the new ebuild and the patch.
I think as a long time solution it would be good to get this fixed upstream.

Thanks for your submission and your help.