Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 256034 - x11-base/xorg-server-1.5.3-r1: patch to support --enable-debug
Summary: x11-base/xorg-server-1.5.3-r1: patch to support --enable-debug
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Matt Turner
URL: http://bugs.freedesktop.org/show_bug....
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2009-01-22 19:27 UTC by Martin Mokrejš
Modified: 2017-01-26 05:20 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
xorg-server-1.5.3-r2.ebuild (xorg-server-1.5.3-r2.ebuild,16.41 KB, text/plain)
2009-01-28 16:41 UTC, Martin Mokrejš
Details
xorg-server-1.11.0.ebuild.patch (xorg-server-1.11.0.patch,892 bytes, text/plain)
2011-09-21 20:58 UTC, Martin Mokrejš
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Mokrejš 2009-01-22 19:27:22 UTC
The package x11-base/xorg-server-1.5.3-r1 cannot be compiled with debug info, see http://bugs.freedesktop.org/show_bug.cgi?id=19691 also for a link to the official patch.
Comment 1 Rémi Cardona (RETIRED) gentoo-dev 2009-01-25 17:57:42 UTC
Fixed without a revbump, as the patch has been proposed upstream for inclusing in 1.5.4.

Thanks
Comment 2 Martin Mokrejš 2009-01-27 23:12:14 UTC
The ebuild should respect USE=debug and pass --enable-debug as well.
Comment 3 Martin Mokrejš 2009-01-27 23:13:15 UTC
... and append-flags "-DDEBUG -DNDEBUG" as well.
Comment 4 Martin Mokrejš 2009-01-27 23:15:36 UTC
# CFLAGS="-O0 -ggdb -DDEBUG -DNDEBUG" CXXFLAGS="-O0 -ggdb -DDEBUG -DNDEBUG" USE=debug FEATURES="nostrip debug" emerge xorg-server
[cut]
>>> Compiling source in /var/tmp/portage/x11-base/xorg-server-1.5.3-r1/work/xorg-server-1.5.3 ...
 * econf: updating xorg-server-1.5.3/config.guess with /usr/share/gnuconfig/config.guess
 * econf: updating xorg-server-1.5.3/config.sub with /usr/share/gnuconfig/config.sub
./configure --prefix=/usr --host=i686-pc-linux-gnu --mandir=/usr/share/man --infodir=/usr/share/info --datadir=/usr/share --sysconfdir=/etc --localstatedir=/var/lib --prefix=/usr --datadir=/usr/share --disable-ipv6 --disable-dmx --disable-kdrive --disable-tslib --enable-xvfb --enable-xnest --enable-xtrap --enable-record --enable-xfree86-utils --enable-install-libxf86config --enable-dri --enable-glx --enable-xorg --disable-glx-tls --enable-xorgcfg --enable-config-dbus --enable-config-hal --disable-dri2 --sysconfdir=/etc/X11 --localstatedir=/var --enable-install-setuid --with-fontdir=/usr/share/fonts --with-xkb-output=/var/lib/xkb --with-default-font-path=built-ins --disable-xsdl --build=i686-pc-linux-gnu
[cut]
# CFLAGS="-O0 -ggdb -DDEBUG -DNDEBUG" CXXFLAGS="-O0 -ggdb -DDEBUG -DNDEBUG" \
USE=debug FEATURES="nostrip debug" emerge --info
 
Portage 2.1.6.7 (default/linux/x86/2008.0/desktop, gcc-4.3.2, glibc-2.9_p20081201-r1, 2.6.29-rc2-git1 i686)
=================================================================
System uname: Linux-2.6.29-rc2-git1-i686-Mobile_Intel-R-_Pentium-R-_4_-_M_CPU_1.80GHz-with-glibc2.0
Timestamp of tree: Mon, 26 Jan 2009 14:45:01 +0000
distcc 3.1 i686-pc-linux-gnu [disabled]
app-shells/bash:     3.2_p48
dev-java/java-config: 1.3.7-r1, 2.1.6-r1
dev-lang/python:     2.5.2-r8
dev-python/pycrypto: 2.0.1-r6
dev-util/cmake:      2.6.2
sys-apps/baselayout: 2.0.0
sys-apps/openrc:     0.4.2
sys-apps/sandbox:    1.3.2
sys-devel/autoconf:  2.13, 2.63
sys-devel/automake:  1.4_p6, 1.5, 1.6.3, 1.7.9-r1, 1.8.5-r3, 1.9.6-r2, 1.10.2
sys-devel/binutils:  2.19
sys-devel/gcc-config: 1.4.0-r4
sys-devel/libtool:   2.2.6a
virtual/os-headers:  2.6.28-r1
ACCEPT_KEYWORDS="x86 ~x86"
CBUILD="i686-pc-linux-gnu"
CFLAGS="-O0 -ggdb -DDEBUG -DNDEBUG"
CHOST="i686-pc-linux-gnu"
CONFIG_PROTECT="/etc /var/bind /var/qmail/alias /var/qmail/control /var/spool/torque /var/vpopmail/etc"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/env.d /etc/env.d/java/ /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo /etc/texmf/web2c /etc/udev/rules.d"
CXXFLAGS="-O0 -ggdb -DDEBUG -DNDEBUG"
DISTDIR="/usr/portage/distfiles"
FEATURES="debug distlocks fixpackages metadata-transfer nostrip parallel-fetch protect-owned sandbox sfperms splitdebug strict unmerge-orphans userfetch"
GENTOO_MIRRORS="http://gentoo.mirror.web4u.cz"
LDFLAGS="-Wl,-O1"
LINGUAS="en cs cz"
PKGDIR="/usr/portage/packages"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --compress --force --whole-file --delete --stats --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY="/usr/local/portage/layman/sunrise /usr/local/portage/layman/java-overlay /usr/local/portage/layman/science /usr/local/portage /usr/local/java-experimental /usr/local/portage/layman/java-overlay"
SYNC="rsync://rsync.europe.gentoo.org/gentoo-portage"
USE="7zip R X Xaw3d a52 aac aalib ace acl acpi alsa amr amrnb amrwb apache2 audacious audiofile bash-completion bcmath berkdb blas bluetooth boost branding bzip2 cairo cblas cddb cdparanoia cdr clamav cli colordiff compress cpio cracklib crypt cscope css ctype cups curl curlwrappers cxx dbus debug dga dia directfb djbfft dri dts dv dvb dvd dvdr dvdread eds emacs emboss emf enblend encode enscript exif expat fam fame fat fbcon ffmpeg fftw firefox flac flash foomaticdb fortran fpx ftp gcj gd gdbm ggi gif gimp gimpprint glibc-compat20 glibc-omitfp glitz glut gmp gnuplot gnutls gpgme gphoto2 gpm graphviz gs gsl gstreamer gtk gtkhtml hal hdf hdf5 hp2xx i8x0 icc iconv icu id3 ieee1394 ifc imagemagick imlib inifile innodb isdnlog ithreads jack java javascript jbig jce jikes jpeg jpeg2k kdtree kerberos lame lapack laptop lcms leim libcaca libedit libnotify libwww live lzo lzw mad maildir matroska mhash midi mikmod mime ming mjpeg mmap mmx mng mod_python modperl modplug motif mozilla moznoirc mp2 mp3 mp4 mpeg mpi mpi_njtree mpich2 mplayer mudflap mule musepack mxdatetime mysql mysqli ncurses netcdf netpbm network nls nntp nptl nptlonly nsplugin ntfs numeric ogg opengl openmp pam pango pcmcia pcntl pcre pdf perl plotutils plugin png pnm postproc postscript ppds pppd procmail pymol python qt3 qt3support qt4 quicktime rar raw readline recode reflection reiserfs rpm samba sasl scanner scp seamonkey server session sftp sift slp smime sndfile soap sockets spell spl sqlite srt sse sse2 ssl startup-notification subtitles subversion svg svgz sysfs sysvipc t1lib tcl tcpd tetex theora threads tidy tiff tk transcode truetype unicode urandom usb userlocales uuencode v4l v4l2 vcd vhook vim-syntax vim-with-x vorbis wifi win32codecs wmf wxwindows x264 x86 xanim xcf xfs xft xinerama xinetd xml xorg xpm xprint xsl xslt xulrunner xv xvid xvmc yv12 zip zlib" ALSA_CARDS="intel-8x0m" ALSA_PCM_PLUGINS="adpcm alaw asym copy dmix dshare dsnoop empty extplug file hooks iec958 ioplug ladspa lfloat linear meter mmap_emul mulaw multi null plug rate route share shm softvol" APACHE2_MODULES="actions alias auth_basic auth_digest authn_anon authn_dbd authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache dbd deflate dir disk_cache env expires ext_filter file_cache filter headers ident imagemap include info log_config mem_cache mime mime_magic rewrite setenvif speling status unique_id userdir usertrack vhost_alias negotiation" ELIBC="glibc" INPUT_DEVICES="keyboard mouse evdev" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LINGUAS="en cs cz" USERLAND="GNU" VIDEO_CARDS="radeon vesa"
Unset:  CPPFLAGS, CTARGET, EMERGE_DEFAULT_OPTS, FFLAGS, INSTALL_MASK, LANG, LC_ALL, MAKEOPTS, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS
Comment 5 Rémi Cardona (RETIRED) gentoo-dev 2009-01-28 10:25:27 UTC
Please provide a patch to the current ebuild.

Thanks
Comment 6 Martin Mokrejš 2009-01-28 16:41:28 UTC
Created attachment 179974 [details]
xorg-server-1.5.3-r2.ebuild

Working ebuild handling USE=debug. User is supposed to have CFLAGS="-O0 0ggdb" or whatever to actually get the debug symbols in the generated binaries. But even without them, the extra -DDEBUG -DNDEBUG CFLAGs will ensure Xorg generates extra debug messages during its run. For example, http://bugs.gentoo.org/attachment.cgi?id=179913 .
Comment 7 Rémi Cardona (RETIRED) gentoo-dev 2009-01-28 19:17:11 UTC
A couple things :

1) please always provide patches instead of full ebuilds, it's easier for us to review changes
2) no need to add "debug" to IUSE, the eclass already takes care of it
3) src_compile is wrong, it should use the function provided by the eclass.
4) Actually, the append-flags call should be done in pkg_setup instead.
5) and the append-flags call should be done only when USE="debug"

Thanks
Comment 8 Rémi Cardona (RETIRED) gentoo-dev 2009-01-28 21:55:08 UTC
Martin contacted me privately to tell me he can't write the ebuild for now.

I'm not against this sort of change, but since I very much want this ebuild to go stable in the near future, I'll avoid changing it now.

We can of course revisit the issue at a later time.

Thanks
Comment 9 Martin Mokrejš 2009-10-17 11:54:58 UTC
Remi, is there a chance to have the debug with 1.6 series ebuilds?
Comment 10 Rémi Cardona (RETIRED) gentoo-dev 2009-10-17 13:33:46 UTC
It's a bit late for 1.6, but if you provide a patch for xorg-server-9999 (in the x11 overlay, it'll probably be included for 1.7).

Thanks
Comment 11 Martin Mokrejš 2009-10-17 22:07:29 UTC
Patch is provided for 1.5.3-r2.
Comment 12 Rémi Cardona (RETIRED) gentoo-dev 2009-10-18 09:03:22 UTC
(In reply to comment #11)
> Patch is provided for 1.5.3-r2.

And I'm asking for an updated patch since _you_ want the feature.

Thanks
Comment 13 Martin Mokrejš 2011-09-21 20:55:13 UTC
(In reply to comment #12)
> (In reply to comment #11)
> > Patch is provided for 1.5.3-r2.
> 
> And I'm asking for an updated patch since _you_ want the feature.
> 
> Thanks
Comment 14 Martin Mokrejš 2011-09-21 20:58:20 UTC
Created attachment 287365 [details]
xorg-server-1.11.0.ebuild.patch

The patch adds IUSE=debug otherwise emerge complains. Confusingly enough, it complains now again but I believe that is a false alarm (we can ignore that --enable-debug) will not be added to configure line after Oct 15). ;)
Comment 15 Matt Turner gentoo-dev 2017-01-26 05:20:36 UTC
Fixed by

commit bde82bf5f446004ca9bead3ce995b99d6e893d0e
Author: Matt Turner <mattst88@gentoo.org>
Date:   Wed Jan 25 21:06:20 2017 -0800

    x11-base/xorg-server: Add IUSE=debug.