Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 255560 - Mercurial eclass should use hg clone instead of rsync to create ${WORKDIR}/${module}
Summary: Mercurial eclass should use hg clone instead of rsync to create ${WORKDIR}/${...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Eclasses (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Krzysztof Pawlik (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on: 259898
Blocks:
  Show dependency tree
 
Reported: 2009-01-19 22:00 UTC by Arne Babenhauserheide
Modified: 2009-03-09 20:11 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
mercurial.eclass.diff (mercurial.eclass.diff,2.60 KB, text/plain)
2009-01-19 22:00 UTC, Arne Babenhauserheide
Details
mercurial.eclass (mercurial.eclass,3.09 KB, text/plain)
2009-01-30 08:47 UTC, Arne Babenhauserheide
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Arne Babenhauserheide 2009-01-19 22:00:03 UTC
I just hacked on the Mercurial eclass to allow Mercurials setup.py to extract
the version from the repo. 

Changes: 
- The initial clone to distfiles doesn't have a working copy anymore
- Copying to workdir is done via cloning. 

Other than allowing Mercurials setup.py to get the exact hg version this should
also speed up the build process if both distfiles and tmp/portage are on the
same filesystem, because in that case the cloning of the .hg repo is done
locally via hardlinks and so we only create the current files once instead
of creating them in distfiles and then rsyncing them to the workdir. 

Also it saves space in distfiles :)

I'll attach it as diff in a blink (this is just a simple diff file1 file2. If
you want another diff format, please tell me!). 

Would you review it? 


Reproducible: Always
Comment 1 Arne Babenhauserheide 2009-01-19 22:00:47 UTC
Created attachment 179038 [details]
mercurial.eclass.diff
Comment 2 Arne Babenhauserheide 2009-01-19 22:02:43 UTC
Sidenote: I also adapted my local the mercurial.eclass to fix #238314 and #160565 - should I also attach that instead of creating several diffs which depend on each other? 
Comment 3 Matthias Schwarzott gentoo-dev 2009-01-26 15:01:49 UTC
Why do I get this bug? I also just use it from my v4l-dvb-hg ebuild and have no stronger relation to that eclass.
Comment 4 Matthias Schwarzott gentoo-dev 2009-01-26 15:05:04 UTC
Only thing I could do would be: Apply patch, emerge v4l-dvb-hg and in case it does not error: commit

So someone with time should review it and commit if it works
Comment 5 Arne Babenhauserheide 2009-01-26 18:23:27 UTC
Should I also attach the version which fixes #238314 and #160565? 

Or should I create patches one by one? 
Comment 6 Donnie Berkholz (RETIRED) gentoo-dev 2009-01-27 06:22:38 UTC
You got it because the only person ever to commit to it retired in 2006, and one of his commits said this:

revision 1.2
date: 2006-06-08 08:47:17 -0700;  author: agriffis;  state: Exp;  lines: +22 -17;  commitid: f11448846844567;
Update mercurial.eclass per conversation with zzam, http://article.gmane.org/gmane.linux.gentoo.devel/38465

Do you want to take responsibility for this eclass or leave it orphaned?
Comment 7 Jeroen Roovers (RETIRED) gentoo-dev 2009-01-27 15:42:29 UTC
Adding dev-util/mercurial maintainer. :)
Comment 8 Arne Babenhauserheide 2009-01-30 08:47:22 UTC
Created attachment 180242 [details]
mercurial.eclass

Supports #251163 and fixes #238314 and #160565. 

This version contains changes from all three bugs, since I worked on all three parts together. I'm sorry that I don't have three clean patches instead. 

I can turn it into three patches, if it help you. 

It will take me a bit, though.
Comment 9 Krzysztof Pawlik (RETIRED) gentoo-dev 2009-02-22 13:50:21 UTC
CC cleanup.
Comment 10 Krzysztof Pawlik (RETIRED) gentoo-dev 2009-02-22 14:32:23 UTC
Could you please test patch against mercurial.eclass from bug 259898 ?
Comment 11 Jeroen Roovers (RETIRED) gentoo-dev 2009-02-25 06:24:28 UTC
(In reply to comment #9)
> CC cleanup.

Please, don't do that. And if you do, make notes that the involved persons explicitly stated they wanted their CC removed.
Comment 12 Krzysztof Pawlik (RETIRED) gentoo-dev 2009-03-09 20:11:11 UTC
Fixed by bug #259898.