Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 25517 - kbd-1.08 fails to compile on sparc
Summary: kbd-1.08 fails to compile on sparc
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: Sparc Linux
: High normal (vote)
Assignee: Martin Schlemmer (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-07-29 09:43 UTC by Todd Sunderlin (RETIRED)
Modified: 2006-02-04 06:05 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
kbd-1.08-sparc-fixes.patch (kbd-1.08-sparc-fixes.patch,2.01 KB, patch)
2003-07-30 14:17 UTC, Martin Schlemmer (RETIRED)
Details | Diff
Generic fixup for kd kernel changes (kbd-1.08-version-fixes.patch,4.04 KB, patch)
2003-08-01 21:40 UTC, Keith M Wesolowski (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Todd Sunderlin (RETIRED) gentoo-dev 2003-07-29 09:43:54 UTC
When attempting to build, this error comes up every time.  Multiple machines,
multiple people.

gcc -s  psfxtable.o psffontop.o xmalloc.o utf8.o   -o psfxtable
gcc -c -Wall -Wmissing-prototypes -Wstrict-prototypes -O2 -pipe
-DDATADIR=\"/usr/usr/share\" kbdrate.c
kbdrate.c: In function `KIOCSRATE_ioctl_ok':
kbdrate.c:167: structure has no member named `period'
kbdrate.c:169: structure has no member named `period'
kbdrate.c:170: structure has no member named `period'
kbdrate.c:180: structure has no member named `period'
make[1]: *** [kbdrate.o] Error 1
make[1]: Leaving directory `/var/tmp/portage/kbd-1.08/work/kbd-1.08/src'
make: *** [all] Error 1

!!! ERROR: sys-apps/kbd-1.08 failed.
!!! Function src_compile, Line 39, Exitcode 2
!!! (no error message)


Reproducible: Always
Steps to Reproduce:
1.  emerge kbd-1.08.ebuild
2.
3.




2x Sun Ultra5

Tried with some generic flags, not using distcc.
Comment 1 Martin Schlemmer (RETIRED) gentoo-dev 2003-07-30 14:17:06 UTC
Created attachment 15243 [details, diff]
kbd-1.08-sparc-fixes.patch

This should fix it, please test and let me know.
Comment 2 Martin Schlemmer (RETIRED) gentoo-dev 2003-07-30 21:29:51 UTC
Added patch to CVS.
Comment 3 Joshua Kinard gentoo-dev 2003-07-30 23:17:15 UTC
The sparc patched applied correctly, but it still fails:

gcc -c -Wall -Wmissing-prototypes -Wstrict-prototypes -mcpu=ultrasparc -mtune=ultrasparc -O3 -pipe -fomit-frame-pointer -freorder-blocks -falign-functions=4 -fstack-protector -DDATADIR=\"/usr/share\" kbdrate.c
kbdrate.c: In function `KDKBDREP_ioctl_ok':
kbdrate.c:113: structure has no member named `rate'
kbdrate.c:133: structure has no member named `rate'
kbdrate.c:139: structure has no member named `rate'
kbdrate.c:144: structure has no member named `rate'
kbdrate.c:149: structure has no member named `rate'
kbdrate.c:164: structure has no member named `rate'
kbdrate.c:171: structure has no member named `rate'
make[1]: *** [kbdrate.o] Error 1
make[1]: Leaving directory `/usr/obj/portage/kbd-1.08-r1/work/kbd-1.08/src'
make: *** [all] Error 1

!!! ERROR: sys-apps/kbd-1.08-r1 failed.
!!! Function src_compile, Line 46, Exitcode 2
!!! (no error message)
Comment 4 Martin Schlemmer (RETIRED) gentoo-dev 2003-07-31 13:52:48 UTC
Sparc or sparc64 ?
Comment 5 Joshua Kinard gentoo-dev 2003-07-31 14:31:18 UTC
sparc64, a.k.a. Sun Blade 100.  500MHz UltraSparc IIe
Comment 6 Martin Schlemmer (RETIRED) gentoo-dev 2003-08-01 15:41:07 UTC
Check for following entry, and please try again on sparc64:

------------------------------------------------------
  02 Aug 2003; Martin Schlemmer <azarah@gentoo.org>
  files/kbd-1.08-sparc-fixes.patch:
  Sparc64 fixes, bug #25517 again.
Comment 7 Joshua Kinard gentoo-dev 2003-08-01 15:49:49 UTC
That is the version I tried.

# emerge kbd
Calculating dependencies ...done!
>>> emerge (1 of 1) sys-apps/kbd-1.08-r1 to /
>>> md5 src_uri ;-) kbd-1.08.tar.gz
>>> Unpacking source...
>>> Unpacking kbd-1.08.tar.gz to /usr/obj/portage/kbd-1.08-r1/work
 * Applying kbd-1.08-sparc-fixes.patch...                                                                                                 [ ok ]
>>> Source unpacked.



# cat /usr/portage/sys-apps/kbd/ChangeLog
# ChangeLog for sys-apps/kbd
# Copyright 2002-2003 Gentoo Technologies, Inc.; Distributed under the GPL v2
# $Header: /home/cvsroot/gentoo-x86/sys-apps/kbd/ChangeLog,v 1.14 2003/07/31 04:37:05 azarah Exp $

  31 Jul 2003; Martin Schlemmer <azarah@gentoo.org> kbd-1.08-r1.ebuild:
  Fix struct kbd_rate not being fixed for sparc to use 'period' and not 'rate',
  bug #25517.
Comment 8 Martin Schlemmer (RETIRED) gentoo-dev 2003-08-01 16:01:53 UTC
Check the date ... I changed the patch.
Comment 9 Joshua Kinard gentoo-dev 2003-08-01 18:18:10 UTC
The changelog reflects a second update to the patch, but the patch still fails with the same error I posted in comment #3
Comment 10 Keith M Wesolowski (RETIRED) gentoo-dev 2003-08-01 21:40:22 UTC
Created attachment 15356 [details, diff]
Generic fixup for kd kernel changes

The changes made between 1.06 and 1.08 were bogus.  This reverts most of those
changes to kbdrate.c and instead uses configure to determine whether we have
2.4-style ("rate") or 2.6-style ("period") structs.  The sparc ioctl uses
"rate" in all versions of the kernel thus far.	If and when this changes, it's
a simple matter to use the configure fragment again to detect it.

Tested on x86 and sparc64.
Comment 11 Martin Schlemmer (RETIRED) gentoo-dev 2003-08-02 06:00:03 UTC
Ok, in -r2, keep it close this time :P
Comment 12 Todd Sunderlin (RETIRED) gentoo-dev 2003-08-02 07:22:45 UTC
Fixed in kbd-1.08-r2
Comment 13 Jason Wever (RETIRED) gentoo-dev 2003-11-03 15:58:56 UTC
Back in kbd-1.08-r4

gcc -c -Wall -Wmissing-prototypes -Wstrict-prototypes -O2 -pipe -DDATADIR=\"/usr/share\"
kbdrate.c
kbdrate.c: In function `KIOCSRATE_ioctl_ok':
kbdrate.c:173: structure has no member named `period'
kbdrate.c:175: structure has no member named `period'
kbdrate.c:176: structure has no member named `period'
kbdrate.c:186: structure has no member named `period'
kbdrate.c: In function `main':
kbdrate.c:203: warning: unused variable `value'
kbdrate.c:206: warning: unused variable `fd'
kbdrate.c:207: warning: unused variable `data'
kbdrate.c:209: warning: unused variable `i'
version.h: At top level:
kbdrate.c:96: warning: `valid_rates' defined but not used
kbdrate.c:102: warning: `valid_delays' defined but not used
make[1]: *** [kbdrate.o] Error 1
make[1]: Leaving directory `/var/tmp/portage/kbd-1.08-r4/work/kbd-1.08/src'
make: *** [all] Error 1
Comment 14 Martin Schlemmer (RETIRED) gentoo-dev 2003-11-03 20:15:07 UTC
Should be fixed again, just give some time to sync.
Comment 15 Martin Schlemmer (RETIRED) gentoo-dev 2003-11-04 12:16:13 UTC
Can we get confirmation that it is indeed fixed, and this closed ?  Thanks.
Comment 16 Jason Wever (RETIRED) gentoo-dev 2003-11-04 13:20:58 UTC
Works for me here on two systems.
Comment 17 Martin Schlemmer (RETIRED) gentoo-dev 2003-11-06 11:29:05 UTC
Thanks Jason.