Home | Docs | Forums | Lists | Bugs | Planet | Store | GMN | Get Gentoo!
Not eligible to see or edit group visibility for this bug.
View Bug Activity | Format For Printing | XML | Clone This Bug
guitarix is a simple Linux amplifier for jack with one input and two outputs Reproducible: Always
Created an attachment (id=178277) [details] guitarix-0.03.ebuild
thanks for the ebuild, but i have to do some review first :) DESCRIPTION="guitarix is a simple Linux amplifier for jack with one input and two outputs" better if it would be only "A simple ..." SRC_URI="http://downloads.sourceforge.net/${PN}/${P}.a.tar.bz2" please use mirror://sourceforge/ HOMEPAGE="www.brummer.de.hm/unstable.html" missing the http:// I suppose and its probably not the real homepage https://brain.kicks-ass.org/~hermann/guitarfx.html seems better DEPEND="${RDEPEND}" the build process appears to use pkgconfig, so you need to DEPEND on it src_unpack() { srcdir="${DISTDIR}/" einfo "Unpacking ${A} to ${WORDIR}" tar xf ${srcdir}${A} -C "${WORKDIR}" } unneeded or if the file is broken better repackage it src_compile() { cd ${S} emake } ditto src_install() { cd ${S} mkdir -p ${D}/usr/bin emake DESTDIR=${D} install } src_install starts in $S, don't use mkdir but dodir, quote $D moreover, the build system completely ignores C(XX)FLAGS, LDFLAGS and seems flawed with as-needed
(In reply to comment #2) > > better if it would be only "A simple ..." > Probably, but I don't have the material to test it :) > SRC_URI="http://downloads.sourceforge.net/${PN}/${P}.a.tar.bz2" > > please use mirror://sourceforge/ no problemo > HOMEPAGE="www.brummer.de.hm/unstable.html" > > missing the http:// I suppose > and its probably not the real homepage > https://brain.kicks-ass.org/~hermann/guitarfx.html seems better you are welcome :) > DEPEND="${RDEPEND}" > > the build process appears to use pkgconfig, so you need to DEPEND on it > > > src_unpack() { > srcdir="${DISTDIR}/" > > einfo "Unpacking ${A} to ${WORDIR}" > tar xf ${srcdir}${A} -C "${WORKDIR}" > > } > > unneeded or if the file is broken better repackage it the file is broken, unpack() doesn't like it. It is an uncompressed tar file > src_compile() { > cd ${S} > emake > } > > > ditto > > > src_install() { > cd ${S} > > mkdir -p ${D}/usr/bin > emake DESTDIR=${D} install > } > > src_install starts in $S, don't use mkdir but dodir, quote $D > Please, redirect me to an official up-to-date portage doc and I will stop reading other ebuild to build one :) > > moreover, the build system completely ignores C(XX)FLAGS, LDFLAGS and seems > flawed with as-needed > Weird, I'm using as-needed too.
Created an attachment (id=178925) [details] guitarix-0.03.ebuild
Also, the author should improve a bit its makefile
(In reply to comment #3) > > DEPEND="${RDEPEND}" > > > > the build process appears to use pkgconfig, so you need to DEPEND on it > > > > > > src_unpack() { > > srcdir="${DISTDIR}/" > > > > einfo "Unpacking ${A} to ${WORDIR}" > > tar xf ${srcdir}${A} -C "${WORKDIR}" > > > > } > > > > unneeded or if the file is broken better repackage it > > the file is broken, unpack() doesn't like it. It is an uncompressed tar file yes, you can use the 0.03.3-1 tarball > > > > moreover, the build system completely ignores C(XX)FLAGS, LDFLAGS and seems > > flawed with as-needed > > > > Weird, I'm using as-needed too. it doesnt fail because it *ignores* it more review: RDEPEND=" media-sound/jack-audio-connection-kit media-sound/lame x11-libs/gtk+ media-libs/ladspa-sdk media-sound/vorbis-tools" I see a depend on gtk2 (so you might want to use gtk+:2 and EAPI=1), jack and ladspa which are fine but also libsndfile however i see no dep on lame and vorbis-tools src_unpack() { unpack ${A} } thats still more or less the default src_compile() { append-ldflags "-Wl,--no-as-needed" emake } never ever append --no-as-needed unless its a weird issue that cant easily be fixed like the c++ issue with static initalisers; that's better to let it fail with as-needed than hiding the bug like that. if you remove the append-ldflags, that's again the default. I get things like that when building: g++ -fPIC -shared -O3 -march=native -mfpmath=sse -ffast-math -Dmydsp=guitarix guitarix-ladspa.cpp -o guitarix.so That's definitely not my cxxflags nor ldflags, so the makefiles need to be patched upstream or in the ebuild to get into the portage tree Also it shouldn't call g++ directly but x86_64-pc-linux-gnu-g++ here in order to allow cross compilations. use tc-getCXX or tc-export CXX from toolchain-funcs eclass. src_install() { dodir /usr/bin emake DESTDIR=${D} install } I think the dodir isn't needed (at least with 0.03.3-1) > Please, redirect me to an official up-to-date portage doc and I will stop > reading other ebuild to build one :) http://devmanual.gentoo.org/ or the pms: http://dev.gentoo.org/~ferdy/pms/pms-head.pdf
Thx for your explanation. I will take a look at the manual for the next ebuild... and improve the Makefile in case upstream doesn't do it.
Created an attachment (id=191021) [details] A bit polished ebuild Hope this works better. Some polishing done, nothing big.
Created an attachment (id=191022) [details] Add "bin" directory Without this patch, you get /usr/bin as a file, and it should be /usr/bin/guitarix. Will send to upstream, too.
Created an attachment (id=191023) [details] HOMEPAGED changed
Created an attachment (id=196262) [details] guitarix-0.04.6.ebuild guitarix-0.04.6 uses waf build tool. So the ebuild is adjusted for waf. Also now using eapi2. And some cleanup.
Created an attachment (id=199266) [details] guitarix-0.04.6.ebuild Added missing dev-libs/boost and media-libs/libsndfile to the RDEPEND.
Created an attachment (id=200008) [details] guitarix-0.05.0.ebuild Actually this is just a version bump by renaming. Nothing new.
Hello, will this ebuild be included in the official portage tree ? If it's not the case, it may be possible to include it in the pro-audio overlay (http://proaudio.tuxfamily.org/). Thanks for the work :) !
