Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 254674 - sys-power/hibernate-script sdhci module needs to be blacklisted
Summary: sys-power/hibernate-script sdhci module needs to be blacklisted
Status: RESOLVED NEEDINFO
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Core system (show other bugs)
Hardware: AMD64 Linux
: High enhancement (vote)
Assignee: Krzysztof Pawlik (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-01-12 20:11 UTC by Maciej Józiewicz
Modified: 2009-08-03 09:28 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Maciej Józiewicz 2009-01-12 20:11:30 UTC
I use my built in card reader very rarely so I don't know if the issue appeared after the last kernel upgrade or was already there when I bought the laptop. Anyway, my SD card didn't get mounted after hibernation so I built sdhci as a module and two others below it need to be modules as well. I just checked that reloading the sdhci module is all it takes to get the functionality back after resume form hibernation. So I blacklisted it and now it all seems to work.

I have a Lenovo 300 N200 0769-EAG and that's the relevant part of lspci output:
08:06.0 FireWire (IEEE 1394): Ricoh Co Ltd R5C832 IEEE 1394 Controller
08:06.1 SD Host controller: Ricoh Co Ltd R5C822 SD/SDIO/MMC/MS/MSPro Host Adapter (rev 19)
08:06.2 System peripheral: Ricoh Co Ltd Device 0843 (rev 0a)
08:06.3 System peripheral: Ricoh Co Ltd R5C592 Memory Stick Bus Host Adapter (rev 05)
08:06.4 System peripheral: Ricoh Co Ltd xD-Picture Card Controller (rev ff)

I don't have any other cards or a firewire device so I can't check if the other functionality provided by this device works fine.

Reproducible: Always

Steps to Reproduce:
Comment 1 Krzysztof Pawlik (RETIRED) gentoo-dev 2009-01-14 19:36:02 UTC
sdhci{,_pci} added to black list.
Comment 2 Maciej Józiewicz 2009-01-14 23:20:25 UTC
But sdhci is enough. No need (unless tested and proven otherwise) to reload the sdhci_pci aswell.

After all it's precious time ;] (I guess...)
Comment 3 Alon Bar-Lev 2009-01-15 16:44:57 UTC
Please don't add to blacklist without notifying upstream, especially if added due to regression.

Mainline drivers should not be blacked listed these days.

Also please note the version so that only affected versions will be blacked listed.
Comment 4 Krzysztof Pawlik (RETIRED) gentoo-dev 2009-01-15 18:51:06 UTC
Alon: Nigel (maintainer of TOI and hibernate-script) has been notified.

Maciej: sdhci_pci needs sdhci.
Comment 5 Alon Bar-Lev 2009-01-15 18:52:55 UTC
Hi!
Upstream is the kernel module originator... :)
Comment 6 Krzysztof Pawlik (RETIRED) gentoo-dev 2009-01-15 18:57:01 UTC
Maciej: what kernel are you running? I've assumed TOI -- in which case it's better to wait for Nigel to determine whenever it's in vanilla or TOI related.
Comment 7 Maciej Józiewicz 2009-01-16 20:55:29 UTC
Yes, I'm running tuxonice-sources-2.6.28.

If you think that it is necessary to reload sdhci_pci aswell then I'm sure you have valid reasons and know a lot more about this. Just wanted to notify that I tested it and for me blacklisting just the sdhci module was enough for it to work flawlessly.
Comment 8 Alon Bar-Lev 2009-01-16 21:00:59 UTC
Hello Maciej,

As linux developers try harder these days to make Linux safe to suspend, it would be great if you could have reported the problem upstream.

The problem is that tuxonice additions are unsupported. And may cause the problem.

In order to solve this (blacklist is not a solution), it would be great if you could reproduce this using vanilla kernel using uswsusp. Then the module maintainer may be more willing to help.

BTW: Is there any good reason for you to use tuxonice and not uswsusp?
Comment 9 Maciej Józiewicz 2009-01-16 21:55:24 UTC
I just tested the vanilla-sources (2.6.28) and it also suffers from this problem. So where should I report it?

BTW. I use TOI because it looks better ;] and I think that it's faster because of compression...didn't notice though.
Comment 10 Alon Bar-Lev 2009-01-16 22:02:39 UTC
SECURE DIGITAL HOST CONTROLLER INTERFACE (SDHCI) DRIVER
P:      Pierre Ossman
M:      drzeus-sdhci@drzeus.cx
L:      sdhci-devel@list.drzeus.cx
S:      Maintained

Send to the list and CC the maintainer, provide full description and how to reproduce.

What do you mean TOI looks better? I have added fbsplash support into uswsusp, so it looks the same... And uswsusp also uses compression... The main difference between the two is that TOI stores the caches while uswsusp drops them, so after TOI resume the system is somewhat more responsive (In theory).
Comment 11 Maciej Józiewicz 2009-01-16 22:26:07 UTC
I just sent it there.

Will your fbsplash patch for uswsusp get included in the Gentoo patchset? Then I would be glad to start using gentoo-sources again. I actually prefer the caches to be flushed - I get to my desktop faster and I prefer all the needed files get loaded back to caches at this point.
Comment 12 Alon Bar-Lev 2009-01-17 08:44:35 UTC
It all in upstream uswsusp ready for you to use.
Just emerge suspend with fbsplash USE.
Set splash = y in /etc/suspend.conf
Comment 13 Maciej Józiewicz 2009-01-17 17:40:38 UTC
I can't get uswsusp to use fbsplash. I don't want to write any more OT here, so when you have some time please take a look here:
http://forums.gentoo.org/viewtopic-t-728222.html
Comment 14 Krzysztof Pawlik (RETIRED) gentoo-dev 2009-08-03 09:28:15 UTC
Maciej: if/when you get more from upstream feel free to reopen the bug.