Hi arches, had to drop keywords due to new dependency. Please rekeyword, kthx: =net-wireless/aircrack-ng-1.0_rc1 =net-wireless/iw-0_p20080605
(In reply to comment #0) > Hi arches, > > had to drop keywords due to new dependency. Please rekeyword, kthx: > =net-wireless/aircrack-ng-1.0_rc1 > =net-wireless/iw-0_p20080605 any chance to drop/make optional the libnl dep or iw dep in aircrack-ng ? because libnl appears to require a linux kernel which of course we don't have on bsd :)
True... the iw binary is only used in airmon-ng, and that also has a fallback on managing via /sys/class/ieee80211/ -- does that work on BSD? If so, I'd simply add a use kernel_linux? () around iw. Otherwise, we can just not install the airmon-ng script.
(In reply to comment #2) > True... the iw binary is only used in airmon-ng, and that also has a fallback > on managing via /sys/class/ieee80211/ -- does that work on BSD? /sys is linux only too :( we used to mask the wifi useflag for older aircrack-ng versions though, which apparently did control the airmon-ng installation > If so, I'd simply add a use kernel_linux? () around iw. Otherwise, we can just > not install the airmon-ng script. yep or add back the (misleading?) wifi useflag anyway, this seems to work fine with fbsd ports patches: http://www.freebsd.org/cgi/cvsweb.cgi/ports/net-mgmt/aircrack-ng/files/ the patch-src_airserv-ng.c and patch-src_osdep_network.c patches are needed to build on fbsd (7.1 here) otherwise they try to include some linux kernel headers; I didn't try patch-src_osdep_freebsd.c but this may be needed for fbsd < 7 support. Otherwise, it seems to work fine with the two patches applied.
Alexis, I pulled in the patches for FreeBSD, made iw a linux-only dep and removed the airmon application as well. Please test the with the latest version. other arches, please retest and rekeyword as well. Thanks!
~arm done
Marked ~ppc.
BSD: ping
Haven't touched iw in over a year, removing myself as maintainer.
BSD team: Older versions will be masked / removed due to bug #311797.
bump: This looks like it is resolved to me, anyone still need this open? Closing in 7 days.
It doesn't build on FreeBSD-9.0 yet. i686-gentoo-freebsd9.0-gcc -O2 -march=native -pipe -fomit-frame-pointer -D_FILE_OFFSET_BITS=64 -D_REVISION=0 -I/usr/local/include -DHAVE_SQLITE -D_FILE_OFFSET_BITS=64 -D_REVISION=0 -I/usr/local/include -DHAVE_SQLITE -Iinclude -c -o osdep/radiotap/radiotap-parser.o osdep/radiotap/radiotap-parser.c In file included from osdep/radiotap/ieee80211_radiotap.h:41:0, from osdep/radiotap/radiotap-parser.h:32, from airdecloak-ng.c:44: /usr/include/sys/types.h:55:24: error: duplicate 'unsigned' /usr/include/sys/types.h:55:24: error: duplicate 'short' /usr/include/sys/types.h:56:22: error: duplicate 'unsigned' /usr/include/sys/types.h:56:22: error: two or more data types in declaration specifiers gmake[1]: *** [airdecloak-ng.o] Error 1 These line in /usr/include/sys/types.h collide with ... > typedef unsigned short ushort; /* Sys V compatibility */ > typedef unsigned int uint; /* Sys V compatibility */ this define's in aircrack-ng-1.1/src/pcap.h > #define ushort unsigned short > #define uint unsigned int
(In reply to comment #11) > It doesn't build on FreeBSD-9.0 yet. > > i686-gentoo-freebsd9.0-gcc -O2 -march=native -pipe -fomit-frame-pointer > -D_FILE_OFFSET_BITS=64 -D_REVISION=0 -I/usr/local/include -DHAVE_SQLITE > -D_FILE_OFFSET_BITS=64 -D_REVISION=0 -I/usr/local/include -DHAVE_SQLITE > -Iinclude -c -o osdep/radiotap/radiotap-parser.o > osdep/radiotap/radiotap-parser.c > In file included from osdep/radiotap/ieee80211_radiotap.h:41:0, > from osdep/radiotap/radiotap-parser.h:32, > from airdecloak-ng.c:44: > /usr/include/sys/types.h:55:24: error: duplicate 'unsigned' > /usr/include/sys/types.h:55:24: error: duplicate 'short' > /usr/include/sys/types.h:56:22: error: duplicate 'unsigned' > /usr/include/sys/types.h:56:22: error: two or more data types in declaration > specifiers > gmake[1]: *** [airdecloak-ng.o] Error 1 Notice that osdep/radiotap/ieee80211_radiotap.h is patched to include sys/types.h by us. Is this patch still necessary? I could build aircrack-ng without this patch.
(In reply to comment #12) > Notice that osdep/radiotap/ieee80211_radiotap.h is patched to include > sys/types.h by us. Is this patch still necessary? I could build aircrack-ng > without this patch. ping. I was able to build net-wireless/aircrck-ng-1.1 both on Linux and FreeBSD.
I believe this falls to the arch teams now, I'd be really happy to see the keywords added, stable if possible (not really sure the rules on that as I don't really do any bsd stuff). Thanks!
Sorry, I guess my words were a bit confusing. Status is - Unmodified ebuild cannot get build on FreeBSD due to error on comment 11 - Our patch (files/aircrack-ng-1.0_rc4-fix_build.patch) cause this error because it include unnecessary sys/types.h - I can build it without the patch both on FreeBSD and Linux So I'd like to ask if the patch is still necessary. If not, please drop it. Then I can add ~x86-fbsd. Thanks.
(In reply to comment #15) > Sorry, I guess my words were a bit confusing. Status is > > - Unmodified ebuild cannot get build on FreeBSD due to error on comment 11 > - Our patch (files/aircrack-ng-1.0_rc4-fix_build.patch) cause this error > because it include unnecessary sys/types.h > - I can build it without the patch both on FreeBSD and Linux > > So I'd like to ask if the patch is still necessary. If not, please drop it. > Then I can add ~x86-fbsd. > Thanks. Build fine without this patch on my amd64 box, but adding ppc team to CC, not sure, maybe bug #280573 is ppc-specific problem...
(In reply to comment #16) > (In reply to comment #15) > > Sorry, I guess my words were a bit confusing. Status is > > > > - Unmodified ebuild cannot get build on FreeBSD due to error on comment 11 > > - Our patch (files/aircrack-ng-1.0_rc4-fix_build.patch) cause this error > > because it include unnecessary sys/types.h > > - I can build it without the patch both on FreeBSD and Linux > > > > So I'd like to ask if the patch is still necessary. If not, please drop it. > > Then I can add ~x86-fbsd. > > Thanks. > > Build fine without this patch on my amd64 box, but adding ppc team to CC, > not sure, maybe bug #280573 is ppc-specific problem... 1) Bug #280573 is about the efika, which is an arm device. 2) I tested =net-wireless/aircrack-ng-1.1 and =net-wireless/iw-3.7 on ppc and they're fine. They are already keyworded, so nothing to do. I'm removing ppc.
(In reply to comment #17) > 1) Bug #280573 is about the efika, which is an arm device. Sorry it is ppc. Apparently there are different models.
(In reply to comment #17) > (In reply to comment #16) > > (In reply to comment #15) > > > Sorry, I guess my words were a bit confusing. Status is > > > > > > - Unmodified ebuild cannot get build on FreeBSD due to error on comment 11 > > > - Our patch (files/aircrack-ng-1.0_rc4-fix_build.patch) cause this error > > > because it include unnecessary sys/types.h > > > - I can build it without the patch both on FreeBSD and Linux > > > > > > So I'd like to ask if the patch is still necessary. If not, please drop it. > > > Then I can add ~x86-fbsd. > > > Thanks. > > > > Build fine without this patch on my amd64 box, but adding ppc team to CC, > > not sure, maybe bug #280573 is ppc-specific problem... > > 1) Bug #280573 is about the efika, which is an arm device. > > 2) I tested =net-wireless/aircrack-ng-1.1 and =net-wireless/iw-3.7 on ppc > and they're fine. They are already keyworded, so nothing to do. I'm > removing ppc. What we want to know is that they works without files/aircrack-ng-1.0_rc4-fix_build.patch or not...
(In reply to comment #19) > What we want to know is that they works without > files/aircrack-ng-1.0_rc4-fix_build.patch or not... working here on ppc as is in the tree
please test 1.2_rc1 in the tree and I'll add keywords to it.
if anyone wants to test 1.2 I'll be happy to add keywords to it
