Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 253399 - rednotebook-0.6.9 needs multiple fixes
Summary: rednotebook-0.6.9 needs multiple fixes
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: Markos Chandras (RETIRED)
URL: http://digitaldump.wordpress.com/proj...
Whiteboard:
Keywords: EBUILD
Depends on:
Blocks:
 
Reported: 2009-01-02 01:27 UTC by Adam Zajac
Modified: 2009-05-10 22:13 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
rednotebook-0.4.0.ebuild (rednotebook-0.4.0.ebuild,633 bytes, text/plain)
2009-01-02 01:28 UTC, Adam Zajac
Details
rednotebook-0.4.0.ebuild (rednotebook-0.4.0.ebuild,591 bytes, text/plain)
2009-01-03 03:08 UTC, Adam Zajac
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Zajac 2009-01-02 01:27:48 UTC
From the author's website:
"RedNotebook is a Desktop Diary that makes it very easy for you to keep track of the stuff you do and the thoughts you have. This journal software helps you to write whole passages or just facts and does so in style."

I'm new to ebuild writing, but there's nothing complex to this one.

Reproducible: Always
Comment 1 Adam Zajac 2009-01-02 01:28:34 UTC
Created attachment 177048 [details]
rednotebook-0.4.0.ebuild
Comment 2 Serkan Kaba (RETIRED) gentoo-dev 2009-01-02 05:16:34 UTC
(In reply to comment #1)
> Created an attachment (id=177048) [edit]
> rednotebook-0.4.0.ebuild
> 

Please use mirror:// syntax for the sourceforge. There are infinitely many examples in the tree. Other than that it looks fine to me. You can also take another step and consider contacting sunrise project on #gentoo-sunrise @ FreeNode (best around evening in Europe) and reading their documentation[1][2]. And please be patient and give them some time to review.

1: http://www.gentoo.org/proj/en/sunrise/
2: http://overlays.gentoo.org/proj/sunrise/wiki
Comment 3 Adam Zajac 2009-01-03 03:08:20 UTC
Created attachment 177185 [details]
rednotebook-0.4.0.ebuild

Changed to the mirror:// syntax for sourceforge.
Comment 4 Markos Chandras (RETIRED) gentoo-dev 2009-01-03 09:19:56 UTC
Thanks for posting this ebuild. I might commit it on sunrise. First I must review it and do some fixes.

JUst for the record, you dont need to specify the src_unpack function , since the one you specified is the default one. Other than that , I dont see any obvious mistakes :)
Comment 5 Serkan Kaba (RETIRED) gentoo-dev 2009-01-03 10:43:10 UTC
(In reply to comment #4)
> Thanks for posting this ebuild. I might commit it on sunrise. First I must
> review it and do some fixes.
> 
> JUst for the record, you dont need to specify the src_unpack function , since
> the one you specified is the default one. Other than that , I dont see any
> obvious mistakes :)
> 

And probably src_install as well. I missed those in my initial review. Thanks to both of you.
Comment 6 Markos Chandras (RETIRED) gentoo-dev 2009-01-03 23:13:57 UTC
This package is now maintained on sunrise overlay. Thanks for posting it
Comment 7 Markos Chandras (RETIRED) gentoo-dev 2009-05-10 12:10:29 UTC
+*rednotebook-0.6.9 (10 May 2009)
+
+  10 May 2009; Markos Chandras <hwoarang@gentoo.org>
+  +rednotebook-0.6.9.ebuild, +metadata.xml:
+  Moved from sunrise. Fixes bug 253399 . Thanks to Adam Zajac
+  <strider1551@gmail.com> for the initial ebuild.
+

Moved to tree. Thanks for your contribution
Comment 8 nm (RETIRED) gentoo-dev 2009-05-10 21:46:25 UTC
Reopening. The ebuild put into the tree is *entirely incorrect.*

1. Someone did not bother to check the correct ebuild depends
2. Nor did anyone bother to read the package's README for what's needed to run
3. The LICENSE is incorrect
4. The DESCRIPTION must be improved
5. Wrong category

1. Package explicitly states it needs:
- Python (2.5) (www.python.org)
- PyYaml (3.05) (www.yaml.org)
- PyGTK (2.13) (www.pygtk.org)

2. It has not used WxWidgets since before .5.x.

3. It is not GPL-3, it is GPL-2, as the LICENSE in the package clearly states.

4. DESCRIPTION is completely useless; it is not at all helpful. I have a better DESCRIPTION in the ebuild I wrote myself some months ago; see below.

5. This package really should *not* be in app-misc/, but instead in x11-misc/, with the other *graphical* journal and writing-type applications.

Please see the ebuild available in my devspace, which I've been maintaining for months now. I have the only correct version of .6.9; please transfer mine to the tree.
- http://dev.gentoo.org/~nightmorph/misc/ebuilds/x11-misc/rednotebook/

I really am glad to have rednotebook in the tree at last, but it must be brought up to the standards of the correct ebuild I wrote myself some time ago. :)
Comment 9 nm (RETIRED) gentoo-dev 2009-05-10 21:47:31 UTC
Assigning to maintainer. Also, I offer to act as proxy-maintainer, as I closely follow upstream releases, and can report version bumps/package changes in a timely manner. If you want the help, that is. :)
Comment 10 Markos Chandras (RETIRED) gentoo-dev 2009-05-10 22:09:19 UTC
Apparently I did the bump without checking all those major changes . Stupid by my side

 Josh, please feel free to be proxy maintainer. Contact me if necessary

+*rednotebook-0.6.9 (10 May 2009)
+
+  10 May 2009; Markos Chandras <hwoarang@gentoo.org>
+  +rednotebook-0.6.9.ebuild, +metadata.xml:
+  Moved from sunrise. Thanks to Adam Zajac. Changed category to x11-misc.
+  Thanks
+  to Josh Saddler for improved ebuild. Fixes bug 253399
+


Fixed on cvs . Resolving as FIXED ( again... )

 Thank you :)