Bug List: (This bug is not in your last search results)   Show last search results      Search page      Enter new bug
Bug#: 25055
Alias:
Product:
Component:
Status: RESOLVED
Resolution: FIXED
Assigned To: Gentoo Games <games@gentoo.org>
Hardware:
OS:
Version:
Priority:
Severity:
Reporter: kyberneticist@yahoo.com
Add CC:
CC:
URL:
Summary:
Status Whiteboard:
Keywords:

Filename Description Type Creator Created Size Actions
frozen-bubble.patch ebuild patch patch Ian Leitch (RETIRED) 2003-07-22 10:48 0000 641 bytes Details | Diff
usr-games-bin-gentoo.patch usr-games-bin-gentoo.patch patch Ian Leitch (RETIRED) 2003-07-22 10:49 0000 586 bytes Details | Diff
frozen-bubble-1.0.0-r2.ebuild frozen-bubble-1.0.0-r2.ebuild text/plain TGL 2003-07-23 17:26 0000 1.67 KB Details
Create a New Attachment (proposed patch, testcase, etc.) View All

Bug 25055 depends on: Show dependency tree
Bug 25055 blocks:
Votes: 0    Show votes for this bug    Vote for this bug

Additional Comments: (this is where you put emerge --info)


Not eligible to see or edit group visibility for this bug.






View Bug Activity   |   Format For Printing   |   XML   |   Clone This Bug

Description:   Opened: 2003-07-22 07:05 0000 
By which I mean it does not place the binary under /usr/games/bin with group
and/or user of games and permissions of 750

Most other games do this and I happen to like it for organization and restriction.

Reproducible: Always
Steps to Reproduce:

------- Comment #1 From Ian Leitch (RETIRED) 2003-07-22 09:40:56 0000 ------- 
frozen-bubble uses a make file to handle is installation. The correct way to do
what you are asking is to patch the make file. I'll look into it.

------- Comment #2 From Chris Gianelloni (RETIRED) 2003-07-22 10:22:06 0000 ------- 
Actually, there should be no need to change anything in the Makefile, but
rather to use the functions in the games.eclass to modify the destination
locations.  Also, simply overriding variables works quite a bit cleaner than
patching the Makefile.  It also keeps us from having to maintain patches that
are not necessary.

------- Comment #3 From Ian Leitch (RETIRED) 2003-07-22 10:29:18 0000 ------- 
If we override a variable (${BINDIR}) we end up with frozen-bubble-editor in
/usr/games/bin aswell. IMO frozen-bubble-editor should stay in /usr/bin.

------- Comment #4 From Ian Leitch (RETIRED) 2003-07-22 10:48:11 0000 ------- 
Created an attachment (id=14874) [details]
ebuild patch

------- Comment #5 From Ian Leitch (RETIRED) 2003-07-22 10:49:40 0000 ------- 
Created an attachment (id=14875) [details]
usr-games-bin-gentoo.patch

This patch creates a new variable for the installation location of
frozen-bubble. It still makes use of ${PREFIX}.

------- Comment #6 From Chris Gianelloni (RETIRED) 2003-07-22 11:19:37 0000 ------- 
The purpose of the games.eclass stuff is actually to keep all parts of the game
in /usr/games, as it should be.  The editor is no exception.  We therefore need
no patch whatsoever to the original sources of the game.

I am updating the ~arch version of the ebuild in CVS.  It should be on the
mirrors shortly.  Since I am not changing a stable version, I am not going to
bump the revision.  If you wish to use the updated ebuild, simply emerge sync
&& emerge frozen-bubble again.

------- Comment #7 From kyberneticist@yahoo.com 2003-07-23 07:35:02 0000 ------- 
Thanks guys!
That was fast :)

------- Comment #8 From TGL 2003-07-23 17:26:05 0000 ------- 
Created an attachment (id=14942) [details]
frozen-bubble-1.0.0-r2.ebuild

The current ebuild is not perfect yet: "games.eclass" specifies
/usr/share/games for data files, whereas they were installed in
/usr/games/share. Here is a corrected version.
Bug List: (This bug is not in your last search results)   Show last search results      Search page      Enter new bug