Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 250328 - net-misc/keychain -q should suppress "Identity added" output
Summary: net-misc/keychain -q should suppress "Identity added" output
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High trivial (vote)
Assignee: Jeremy Olexa (darkside) (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-12-08 23:44 UTC by Richard Laager
Modified: 2009-10-27 17:06 UTC (History)
5 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Richard Laager 2008-12-08 23:44:18 UTC
As reported here: https://bugs.launchpad.net/ubuntu/+source/keychain/+bug/38808

When I run keychain as follows, I still see "Identity added" output.

eval `keychain -q --eval id_dsa`

Reproducible: Always

Steps to Reproduce:
Comment 1 Daniel Robbins 2009-07-18 02:30:18 UTC
I can't replicate this with version 2.6.8.
Comment 2 Greg Fitzgerald 2009-07-18 16:24:57 UTC
(In reply to comment #1)
> I can't replicate this with version 2.6.8.
> 

I couldn't at first either. It seems to only display Identity Added on the first run. Once your key is stored rerunning it does not produce the message.
Comment 3 Daniel Robbins 2009-08-12 18:02:15 UTC
OK, yes, I can reproduce this. But how exactly is this a bug? If you are being interactively prompted for your passphrase, I think you should have some kind of confirmation afterwards that it was added correctly. If you enter a bad passphrase, you will also be informed and prompted again.
 
Comment 4 Richard Laager 2009-08-13 02:20:00 UTC
This is a bug because the script has been told to be quiet and it isn't.

My key has no passphrase. For keys that do, the general trend for Unix tools is to be silent on success, only printing on failure. Whether or not that's the default for keychain, it seems like a good behavior for keychain -q.
Comment 5 Daniel Robbins 2009-09-30 01:52:52 UTC
Richard, thanks for the input on this. I will look into optimizing this for situations where private keys are not encrypted.
Comment 6 Daniel Robbins 2009-09-30 02:10:58 UTC
OK, I should be able to get this in 2.6.10 (out soon)
Comment 8 Jeremy Olexa (darkside) (RETIRED) archtester gentoo-dev Security 2009-10-27 17:06:00 UTC
2.7.0 is in the tree. thx