Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 248849 - net-analyzer/munin-1.3.4-r1 samba plugin - has incorrect format of 'max' value
Summary: net-analyzer/munin-1.3.4-r1 samba plugin - has incorrect format of 'max' value
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High minor (vote)
Assignee: Robin Johnson
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-11-26 07:51 UTC by Krzysztof Kozlowski
Modified: 2009-08-10 20:49 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
munin-1.3.4 samba plugin patch, fix for 'max' warning/critical values (munin-1.3.4-samba_plugin.patch,468 bytes, patch)
2008-11-26 07:52 UTC, Krzysztof Kozlowski 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Krzysztof Kozlowski 2008-11-26 07:51:19 UTC 
Samba plugin with 'config' prints:
  max.warning 900
  max.critical 960
but id does not have any 'max' value (instead it has 'proc', 'lock' and 'share'). This results in fake munin-limit alerts:
  samba;max;unknown Value is unknown.
  samba;max;state unknown


Reproducible: Always

Steps to Reproduce:
1. Add samba plugin to munin-node configuration.
2. Run /usr/libexec/munin/munin-limits
3. Check file /var/lib/munin/limits
Comment 1 Krzysztof Kozlowski 2008-11-26 07:52:02 UTC 
Created attachment 173411 [details, diff]
munin-1.3.4 samba plugin patch, fix for 'max' warning/critical values

A fix.
Comment 2 Hans de Graaff gentoo-dev Security 2009-08-10 20:49:16 UTC 
Fixed in munin-1.3.4-r2. Thanks for providing the patch. Verified that this already got fixed upstream.