Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 246865 - app-crypt/md5deep: fails with forced --as-needed
Summary: app-crypt/md5deep: fails with forced --as-needed
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Tristan Heaven (RETIRED)
URL: http://www.gentoo.org/proj/en/qa/asne...
Whiteboard:
Keywords:
Depends on:
Blocks: as-needed
  Show dependency tree
 
Reported: 2008-11-15 13:55 UTC by Diego Elio Pettenò (RETIRED)
Modified: 2008-12-10 11:39 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Build log (app-crypt:md5deep-3.0:20081114-214658.log,11.04 KB, text/plain)
2008-11-15 13:55 UTC, Diego Elio Pettenò (RETIRED)
Details
md5deep-3.1-as-needed.patch (md5deep-3.1-as-needed.patch,747 bytes, patch)
2008-12-09 13:03 UTC, Tristan Heaven (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Diego Elio Pettenò (RETIRED) gentoo-dev 2008-11-15 13:55:09 UTC
I'm reporting this bug because the package in summary fails to build when forcing --as-needed on through spec files (check out http://blog.flameeyes.eu/2008/11/14/problems-and-mitigation-strategies-for-as-needed for details).

Check the attached build log.

Thanks,
Diego
Comment 1 Diego Elio Pettenò (RETIRED) gentoo-dev 2008-11-15 13:55:24 UTC
Created attachment 171814 [details]
Build log
Comment 2 Tristan Heaven (RETIRED) gentoo-dev 2008-12-07 14:10:02 UTC
Should be fixed in 3.1.
Comment 3 Vlastimil Babka (Caster) (RETIRED) gentoo-dev 2008-12-09 10:54:59 UTC
Hashdeep seems to be still broken in 3.1:

x86_64-pc-linux-gnu-gcc  -O2 -march=athlon64 -msse3 -pipe  -Wl,--as-needed -o hashdeep main.o audit.o match.o multihash.o display.o hashtable.o hash.o dig.o cycles.o ui.o helpers.o md5.o sha1.o sha256.o tiger.o whirlpool.o
hash.o: In function `compute_hash':
hash.c:(.text+0x1a7): undefined reference to `floor'
collect2: ld returned 1 exit status
make[2]: *** [hashdeep] Error 1
make[2]: Leaving directory `/var/tmp/portage/app-crypt/md5deep-3.1/work/md5deep-3.1/hashdeep'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/var/tmp/portage/app-crypt/md5deep-3.1/work/md5deep-3.1'
make: *** [all] Error 2

The Makefile seems to be using some hashdeep_LDADD variable instead of the LDADD you fixed with your patch :/
Comment 4 Tristan Heaven (RETIRED) gentoo-dev 2008-12-09 13:03:27 UTC
Created attachment 174714 [details, diff]
md5deep-3.1-as-needed.patch

Maybe this?
Comment 5 Vlastimil Babka (Caster) (RETIRED) gentoo-dev 2008-12-10 10:24:27 UTC
Works, thanks!
Comment 6 Tristan Heaven (RETIRED) gentoo-dev 2008-12-10 11:39:23 UTC
Fixed, thanks.