Bug 246017 – net-misc/rsync with use flags for all the patches

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Nicholas Fiorentini 2008-11-07 22:39:50 UTC]

Could be very nice if those patches can be directly applied with emerge, without making personal ebuild every time.

Reproducible: Always

Steps to Reproduce:
1. emerge rsync

Actual Results:  
When you emerge rsync, it install the base version. You have to manually install the patches you need.

Expected Results:  
The possibility to select the patches to apply with use flags. This could help the installation of rsync.

I posted an example ebuild based on rsync-3.0.4. This show my idea. This is not completed with all possible patches. Also, It is not fully tested. I used this ebuild for my own version of rsync with the patches I needed.

Note: you have to extract the http://samba.anu.edu.au/ftp/rsync/rsync-patches-3.0.4.tar.gz into the file directory in the locale portage.

[Comment 1 Nicholas Fiorentini 2008-11-07 22:43:31 UTC]

Created attachment 171054 [details, diff]
This is an example patch for the proposal.

This ebuild is made for the rsync-3.0.4
It's is only an example with few patches.

[Comment 2 Wormo (RETIRED) 2008-11-09 05:24:32 UTC]

Thanks for the suggestion and example ebuild, assigning to maintainers.

[Comment 3 SpanKY 2008-11-09 07:19:57 UTC]

people expect support if we were to add that and they certainly wouldnt get any

you can apply custom patches now using this:
http://sources.gentoo.org/net-misc/rsync/rsync-3.0.4.ebuild?r1=1.1&r2=1.2

[Comment 4 Nicholas Fiorentini 2008-11-09 11:18:08 UTC]

(In reply to comment #3)
> you can apply custom patches now using this:
> http://sources.gentoo.org/net-misc/rsync/rsync-3.0.4.ebuild?r1=1.1&r2=1.2


Thanks, I didn't know this solution. Thanks, I didn't know this solution. I'm pretty new to ebuilds.

[Comment 5 SpanKY 2008-11-09 11:18:55 UTC]

well, it didnt exist before you asked for it ;)

[Comment 6 Peter Volkov (RETIRED) 2008-11-10 11:08:38 UTC]

Mike this was discussed many times that having such code in ebuild is stupid.

1. It'll be hard to maintain: this is general programming paradigm the same code snippets should be moved into function, and if function is used in many places in the different files to the library.
2. It's easy to do this thing with bashrc and then ALL ebuilds will have this feature automatically.

Please, drop this code from ebuild start suggesting to use bashrc.

[Comment 7 SpanKY 2008-11-10 14:28:35 UTC]

if you wanted it implemented generally then go for it.  i dont feel like dealing with the whiny QA people.