First Last Prev Next    No search results available      Search page      Enter new bug
Bug#: 245973
Alias:
Product:
Component:
Status: RESOLVED
Resolution: FIXED
Assigned To: Gentoo wxWidgets Herd <wxwidgets@gentoo.org>
Hardware:
OS:
Version:
Priority:
Severity:
Reporter: Martin von Gagern <Martin.vGagern@gmx.net>
Add CC:
CC:
URL:
Summary:
Status Whiteboard:
Keywords:

Filename Description Type Creator Created Size Actions
wxGTK-2.8.9-BOOL.patch Use and keep already defined BOOL patch Martin von Gagern 2008-11-07 15:34 0000 773 bytes Details | Diff
Create a New Attachment (proposed patch, testcase, etc.) View All

Bug 245973 depends on: Show dependency tree
Bug 245973 blocks:
Votes: 0    Show votes for this bug    Vote for this bug

Additional Comments: (this is where you put emerge --info)


Not eligible to see or edit group visibility for this bug.






View Bug Activity   |   Format For Printing   |   XML   |   Clone This Bug

Description:   Opened: 2008-11-07 15:33 0000 
I encountered this while trying to compile truecrypt-6.1 from bug 245322. The
build process there calls g++ with -DBOOL=int, but still I get errors like this
"error: ‘BOOL’ does not name a type". I traced this to wx/db.h which
defines BOOL, includes some other headers, and then unconditionally undefines
it again.

The inclusion path is the following:
<wx/wx.h> -> "wx/window.h" -> "wx/colour.h" -> "wx/variant.h" -> "wx/db.h"

Bug 210024 worked around this for previous truecrypt releases, and including
that workaround again would be easy. On the other hand, I consider it bad
behaviour for a header file to undefine any macros, especially such common
ones. Therefore I'd prefer wxGTK to address this issue. I'll attach a patch.

------- Comment #1 From Martin von Gagern 2008-11-07 15:34:59 0000 ------- 
Created an attachment (id=171002) [edit]
Use and keep already defined BOOL

This patch only defines and undefines BOOL if it hasn't already been defined.
If it already is defined, it is assumed to be compatible with int, or that the
application won't use that part of the wxGTK interface. No further checks made.

------- Comment #2 From Ryan Hill 2008-11-07 22:41:13 0000 ------- 
makes sense to me.  http://trac.wxwidgets.org/ticket/10167

------- Comment #3 From Vadim Zeitlin 2008-11-07 22:46:58 0000 ------- 
Patch applied to wx sources, will be in 2.8.10, thanks.

------- Comment #4 From Ryan Hill 2008-11-07 23:34:54 0000 ------- 
Thanks for the quick response.  Fixed in wxGTK-2.8.9.1-r2 and -r3.
First Last Prev Next    No search results available      Search page      Enter new bug