First Last Prev Next    No search results available      Search page      Enter new bug
Bug#: 24391
Alias:
Product:
Component:
Status: RESOLVED
Resolution: FIXED
Assigned To: Seemant Kulleen (RETIRED) <seemant@gentoo.org>
Hardware:
OS:
Version:
Priority:
Severity:
Reporter: CJ Kucera <pez@apocalyptech.com>
Add CC:
CC:
Remove selected CCs
URL:
Summary:
Status Whiteboard:
Keywords:

Filename Description Type Creator Created Size Actions
realplayer-8-r6.ebuild.diff realplayer-8-r6.ebuild.diff patch CJ Kucera 2003-07-13 09:32 0000 1.45 KB Details | Diff
digest-realplayer-8-r6 digest-realplayer-8-r6 text/plain CJ Kucera 2003-07-13 09:33 0000 357 bytes Details
realplayer-8-r6.ebuild realplayer-8-r6.ebuild text/plain CJ Kucera 2003-07-13 09:33 0000 3.31 KB Details
Create a New Attachment (proposed patch, testcase, etc.) View All

Bug 24391 depends on: Show dependency tree
Bug 24391 blocks:
Votes: 0    Show votes for this bug    Vote for this bug

Additional Comments: (this is where you put emerge --info)


Not eligible to see or edit group visibility for this bug.






View Bug Activity   |   Format For Printing   |   XML   |   Clone This Bug


Description:   Opened: 2003-07-13 09:31 0000
The ebuilds for realplayer aren't doing fetch restriction properly.  See bug
#10347 and bug #24296 for details about this.  I'll attach a patch to the
realplayer-8-r5 momentarily which fixes the problem.  Another nice side-effect
of this is that Portage can actually store digests of the realplayer files, too.
 Because of the way the ebuild is structured, that means there's a few extra
steps to create the digest.

The ebuild currently sets ${A} based on which arch is selected.  In my ebuild
(about to be attached), SRC_URI looks like this:

SRC_URI="x86? http://docs.real.com/docs/playerpatch/unix/rv9_libc6_i386_cs2.tgz
        ${A}"

If you try and generate a digest from this SRC_URI, you'll only get a digest
which includes the arch you're running the digest on.  So, in order to correctly
generate a digest, you'll have to change SRC_URI to look like this before
generating the digest:

SRC_URI="x86? http://docs.real.com/docs/playerpatch/unix/rv9_libc6_i386_cs2.tgz
    rp8_linux20_libc6_i386_cs2.bin
    rp8_linux_powerpc_cs1.bin
    rp8_linux_sparc_cs1.bin
    rp8_linux_alpha_rh62_cs1.bin"

It's an extra step, yes, but I think the benefits far outweigh the downsides. 
I'll attach the digest file as well.

Reproducible: Always
Steps to Reproduce:

------- Comment #1 From CJ Kucera 2003-07-13 09:32:28 0000 -------
Created an attachment (id=14433) [edit]
realplayer-8-r6.ebuild.diff

Here's a patch to include proper fetch restriction handling.

------- Comment #2 From CJ Kucera 2003-07-13 09:33:14 0000 -------
Created an attachment (id=14434) [edit]
digest-realplayer-8-r6

Here's the complete digest file.

------- Comment #3 From CJ Kucera 2003-07-13 09:33:46 0000 -------
Created an attachment (id=14435) [edit]
realplayer-8-r6.ebuild

And, just for good measure, here's the ebuild itself (not a diff)

------- Comment #4 From CJ Kucera 2003-07-13 09:44:34 0000 -------
Come to think of it, before this is checked in, it would probably be a good
idea to put some text in the ebuild descbing how to properly re-generate the
digest file.  Otherwise someone could end up checking in a digest file which
only contained one arch in it...

------- Comment #5 From Seemant Kulleen (RETIRED) 2003-07-13 15:25:51 0000 -------
actually, the extra steps are not necessary on a dev box, because devs have
"cvs" in FEATURES.

------- Comment #6 From Seemant Kulleen (RETIRED) 2003-07-13 15:35:22 0000 -------
fetch restriction not turned on, because there is ONE file to fetched for at
least x86.

Please rsync and recheck (no revision bump, so still -r5)

------- Comment #7 From CJ Kucera 2003-07-14 08:05:12 0000 -------
Whoa, heh, yeah, neglected to notice that one file that *can* be downloaded. 
Thanks!

First Last Prev Next    No search results available      Search page      Enter new bug