Bug List: (This bug is not in your last search results)   Show last search results      Search page      Enter new bug
Bug#: 243200
Alias:
Product:
Component:
Status: RESOLVED
Resolution: FIXED
Assigned To: Freedesktop bugs <freedesktop-bugs@gentoo.org>
Hardware:
OS:
Version:
Priority:
Severity:
Reporter: Daniel Vergien <daniel.vergien@googlemail.com>
Add CC:
CC:
Remove selected CCs
URL:
Summary:
Status Whiteboard:
Keywords:

Filename Description Type Creator Created Size Actions
libopenraw-0.0.5.ebuild ebuild text/plain Daniel Vergien 2008-10-22 11:57 0000 961 bytes Details
libopenraw-0.0.5-ljpegdcompressor.patch adds #include<strings.h> to ljpegdecompressor.cpp patch Daniel Vergien 2008-10-22 11:57 0000 459 bytes Details | Diff
libopenraw-0.0.5-ljpegdcompressor.patch updated patch to use cstring instead of strings.h text/plain Jeremy Olexa (darkside) 2008-10-27 14:20 0000 457 bytes Details
Create a New Attachment (proposed patch, testcase, etc.) View All

Bug 243200 depends on: Show dependency tree
Bug 243200 blocks:
Votes: 0    Show votes for this bug    Vote for this bug

Additional Comments: (this is where you put emerge --info)


Not eligible to see or edit group visibility for this bug.






View Bug Activity   |   Format For Printing   |   XML   |   Clone This Bug


Description:   Opened: 2008-10-22 11:56 0000
Added --with-boost=${EPREFIX}/usr to the econf call. Else boost is not found.
At least on Solaris #include<strings.> in lib/ljpegdecompressor.cpp is needed
to find bcopy.

------- Comment #1 From Daniel Vergien 2008-10-22 11:57:17 0000 -------
Created an attachment (id=169400) [details]
ebuild

------- Comment #2 From Daniel Vergien 2008-10-22 11:57:59 0000 -------
Created an attachment (id=169402) [details]
adds #include<strings.h> to ljpegdecompressor.cpp

------- Comment #3 From Jeremy Olexa (darkside) 2008-10-22 14:31:36 0000 -------
added to the tree, thanks!

------- Comment #4 From Jeremy Olexa (darkside) 2008-10-22 14:36:52 0000 -------
(In reply to comment #2)
> Created an attachment (id=169402) [edit] [details]
> adds #include<strings.h> to ljpegdecompressor.cpp
> 

Hi freedesktop team,
Would you consider this patch for the gentoo-x86 tree? I have tested it on
amd64-linux and it does not cause any problems (and it is needed for
x86-solaris). One of the Gentoo Prefix goals is to have as little as possible
changes compared to the gentoo-x86 tree. Thanks for your time. (Of course, if
you are *strongly* against this patch, that is fine as well. But it is a pretty
trivial patch)

------- Comment #5 From Rémi Cardona 2008-10-23 09:20:36 0000 -------
Hum, you should probably use <cstring> instead of <strings.h>

Could you also report the bug upstream and send them your patch?

Thanks

------- Comment #6 From Jeremy Olexa (darkside) 2008-10-23 12:56:22 0000 -------
(In reply to comment #5)
> Hum, you should probably use <cstring> instead of <strings.h>

Yea, that was already pointed out, slipped my mind.. ;)

> Could you also report the bug upstream and send them your patch?

bugs.fd.o seems down and I won't be able to work on Gentoo stuff until next
week (busy weekend), I won't be offended if someone else gets to it =D

------- Comment #7 From Jeremy Olexa (darkside) 2008-10-27 14:20:47 0000 -------
Created an attachment (id=170006) [details]
updated patch to use cstring instead of strings.h

------- Comment #8 From Jeremy Olexa (darkside) 2008-10-27 14:23:22 0000 -------
Upstream report: https://bugs.freedesktop.org/show_bug.cgi?id=18243

------- Comment #9 From Jeremy Olexa (darkside) 2008-10-27 16:25:10 0000 -------
(In reply to comment #8)
> Upstream report: https://bugs.freedesktop.org/show_bug.cgi?id=18243
> 

Upstream has applied this to the git master branch. Could it be applied to
gentoo-x86 now? TIA.

------- Comment #10 From Rémi Cardona 2008-10-29 08:54:38 0000 -------
Committed without a revbump.

@Daniel, epatch goes into src_unpack, not src_compile. Just letting you know :)

Thanks to the both of you.

Bug List: (This bug is not in your last search results)   Show last search results      Search page      Enter new bug