Bugzilla Bug 242342

media-libs/svgalib-1.9.25 failes to compile 

Reproducible: Always

Steps to Reproduce:
1.emerge media-libs/svgalib-1.9.25


Actual Results:  
  CC [M] 
/var/tmp/portage/media-libs/svgalib-1.9.25/work/svgalib-1.9.25/kernel/svgalib_helper/displaystart.o
/var/tmp/portage/media-libs/svgalib-1.9.25/work/svgalib-1.9.25/kernel/svgalib_helper/main.c:
In function ‘init_module’:
/var/tmp/portage/media-libs/svgalib-1.9.25/work/svgalib-1.9.25/kernel/svgalib_helper/main.c:660:
error: too few arguments to function ‘device_create’
/var/tmp/portage/media-libs/svgalib-1.9.25/work/svgalib-1.9.25/kernel/svgalib_helper/main.c:708:
error: too few arguments to function ‘device_create’
make[2]: ***
[/var/tmp/portage/media-libs/svgalib-1.9.25/work/svgalib-1.9.25/kernel/svgalib_helper/main.o]
Error 1
make[1]: ***
[_module_/var/tmp/portage/media-libs/svgalib-1.9.25/work/svgalib-1.9.25/kernel/svgalib_helper]
Error 2
make[1]: Leaving directory `/usr/src/linux-2.6.27-gentoo'
make: *** [default] Error 2
 *
 * ERROR: media-libs/svgalib-1.9.25 failed.
 * Call stack:
 *               ebuild.sh, line   49:  Called src_compile
 *             environment, line 3464:  Called linux-mod_src_compile
 *             environment, line 2638:  Called die
 * The specific snippet of code:
 *               eval "emake HOSTCC=\"$(tc-getBUILD_CC)\"                      
                   CC=\"$(get-KERNEL_CC)\"                                     
    LDFLAGS=\"$(get_abi_LDFLAGS)\"     ${BUILD_FIXES}                          
                ${BUILD_PARAMS}                            ${BUILD_TARGETS} "
|| die "Unable to emake HOSTCC="$(tc-getBUILD_CC)" CC="$(get-KERNEL_CC)"
LDFLAGS="$(get_abi_LDFLAGS)" ${BUILD_FIXES} ${BUILD_PARAMS} ${BUILD_TARGETS}";
 *  The die message:
 *   Unable to emake HOSTCC=i686-pc-linux-gnu-gcc CC=i686-pc-linux-gnu-gcc
LDFLAGS=  KDIR=/usr/src/linux default
 *
 * If you need support, post the topmost build error, and the call stack if
relevant.
 * A complete build log is located at
'/var/tmp/portage/media-libs/svgalib-1.9.25/temp/build.log'.
 * The ebuild environment file is located at
'/var/tmp/portage/media-libs/svgalib-1.9.25/temp/environment'.
 *


Expected Results:  
media-libs/svgalib-1.9.25 should compile find

Created an attachment (id=168668) [details]
emerge --info

Created an attachment (id=168754) [details]
kernel-2.6.27.patch

Possible patch.

(In reply to comment #2)
> Created an attachment (id=168754) [edit] [details]
> kernel-2.6.27.patch
> 
> Possible patch.
> 

It compiles. Haven't tried to execute svgalib, though.

However, it's very important that this patch should be applied the last (this
is, after the other patches in the ebuild), like this:

        epatch "${FILESDIR}"/${PN}-1.9.25-linux2.6.patch
        epatch "${FILESDIR}"/${PN}-1.9.19-pic.patch #51698
        epatch "${FILESDIR}"/${PN}-1.9.25-build.patch
        epatch "${FILESDIR}"/${P}-linux-2.6.27.patch

As you can see, the patch posted here is the last (I changed the name for easy
to identify to me).

The svgalib package compiles successfully with the patch applied. I can also
confirm expected functionality of the svgalib_helper module.

I can't seem to compile svgalib even with the attached patch, my problem is
that portage complains $EPATCH_SOURCE is not defined, I'm not a newbie in
linux, but I just recently started using gentoo and can't seem to find any info
about this.

(In reply to comment #3)
> (In reply to comment #2)
> > Created an attachment (id=168754) [edit] [details]
> > kernel-2.6.27.patch
> > 
> > Possible patch.
> > 
> 
> It compiles. Haven't tried to execute svgalib, though.
> 
> However, it's very important that this patch should be applied the last (this
> is, after the other patches in the ebuild), like this:
> 
>         epatch "${FILESDIR}"/${PN}-1.9.25-linux2.6.patch
>         epatch "${FILESDIR}"/${PN}-1.9.19-pic.patch #51698
>         epatch "${FILESDIR}"/${PN}-1.9.25-build.patch
>         epatch "${FILESDIR}"/${P}-linux-2.6.27.patch
> 
> As you can see, the patch posted here is the last (I changed the name for easy
> to identify to me).
> 

Nevermind that, I figured it out, I had improperly named the patch...
Sorry for the stupid mistake, you should ignore my previous comment.

Patch works for me.

(In reply to comment #5)
> I can't seem to compile svgalib even with the attached patch, my problem is
> that portage complains $EPATCH_SOURCE is not defined, I'm not a newbie in
> linux, but I just recently started using gentoo and can't seem to find any info
> about this.
> 
> (In reply to comment #3)
> > (In reply to comment #2)
> > > Created an attachment (id=168754) [edit] [details]
> > > kernel-2.6.27.patch
> > > 
> > > Possible patch.
> > > 
> > 
> > It compiles. Haven't tried to execute svgalib, though.
> > 
> > However, it's very important that this patch should be applied the last (this
> > is, after the other patches in the ebuild), like this:
> > 
> >         epatch "${FILESDIR}"/${PN}-1.9.25-linux2.6.patch
> >         epatch "${FILESDIR}"/${PN}-1.9.19-pic.patch #51698
> >         epatch "${FILESDIR}"/${PN}-1.9.25-build.patch
> >         epatch "${FILESDIR}"/${P}-linux-2.6.27.patch
> > 
> > As you can see, the patch posted here is the last (I changed the name for easy
> > to identify to me).
> > 
> 

Thanks for the patch. I've added it to the ebuild, and things should work now
until the next time the kernel changes something.