Bugzilla Bug 24182

The /etc/conf.d/setiathome config file has the SETIATHOME_DIR defined twice,
pointing to two 
different locations.  According to the notes after installing the Ebuild, it
should be set to 
/var/lib/setiathome, not /opt/setiathome, which it is not. (/opt/setiathome is
the last one defined in 
the file. It would probably be wiser  to just put the executables in /usr/bin,
and the user specific 
data in /var/lib/setiathome. and not worry about using OPT. 

The seti-init.d-r1 from the setiathome-3.08-r1 ebuild (files dir) has a bug on
line number 30,  there 
is an extra "fi" on the line that copies the user_info.sah file into a thread
subdir.  Most users who 
only have one CPU will never see this error, those of us with more than one and
setup setiathome 
to use more than one thread will have a problem.. 

Solution:  remove the extra "fi" at the end of the line: 

cp "${SETIATHOME_DIR}/user_info.sah" "${SETIATHOME_DIR}/thread${thread}"       
           fi 
                                                                               
              Problem------------------->^^^ 
(see end of line for the typo as it currently exists...) 
should be: 
cp "${SETIATHOME_DIR}/user_info.sah" "${SETIATHOME_DIR}/thread${thread}" 

Reproducible: Always
Steps to Reproduce:
1. edit /etc/rc.conf/setiathome, set number of threads to 2 
2. start setiathome via the init script (/etc/init.d/setiathome start) 
3. if you haven't setup seti yet, it'll request you to set it up, enter your
seti email acct 
4.  
Actual Results:  
cp: copying multiple files, but last argument `fi' is not a directory 
Try `cp --help' for more information. 
 * Starting SETI@home (2 threads)...                                      [ ok
] 

Expected Results:  
The CP error shouldn't have happened, as a side effect two threads do start,
but one is not "niced" 
to level 19 (lowest priority) 

the fixes defined above solve all bugs related to this report...

the conf file stuff could only be from your etc-update
a clean install shows only /var dir

fixed typo in initscript

I tried a clean install (3.08-r1) and got the two definitions of SETIATHOME_DIR
in 
/etc/conf.d/setiathome.  One pointed to /var/lib/setiathome/ the other pointed
to 
/opt/setiathome,  both were uncommented... 

That's why I reported it...  After a emerge unmerge setiathome, rm -rf 
/var/lib/setiathome /etc/conf.d/setiathome /etc/init.d/setiathome, followed by
an "emerge 
setiathome"  the contents of /etc/conf.d/setiathome are: 

dave@shrapnel dave $ more /etc/conf.d/setiathome  
# Config file for /etc/init.d/setiathome 

# specify the number of setiathome processes to start 
SETIATHOME_THREADS="1" 

# set up any options you want for setiathome here 
# for more info, `setiathome -h` 
SETIATHOME_OPTIONS="-nice 19" 

# this is the directory where setiathome's run-time 
# data files will be stored 
SETIATHOME_DIR=/var/lib/setiathome 
SETIATHOME_DIR=/opt/setiathome 


The last line should either be commented out, or NOT there.. 

oh i c

was set in ebuild

fixed in cvs