Bugzilla Bug 240676

Hi,

after upgrading from openrc-0.2.5 to openrc-0.3.0-r1 ntpd service from
net-misc/openntpd cannot be stopped anymore.

Reproducible: Always

Steps to Reproduce:
1. emerge -1 =openrc-0.3.0-r1 && emerge openntpd
2. /etc/init.d/ntpd start
3. /etc/init.d/ntpd stop

Actual Results:  
barcelona:~ # qfile -Cqv /etc/init.d/ntpd
net-misc/openntpd-3.9_p1-r1
barcelona:~ # qlist -CIve openrc
sys-apps/openrc-0.3.0-r1
barcelona:~ # /etc/init.d/ntpd start
 * Starting ntpd ...                                                      [ ok
]
barcelona:~ # /etc/init.d/ntpd stop
 * Stopping ntpd ...
 * start-stop-daemon: no matching processes found                         [ ok
]
barcelona:~ # ps -A | grep ntp
10817 ?        00:00:00 ntpd
10818 ?        00:00:00 ntpd
barcelona:~ #

Expected Results:  
barcelona:~ # qfile -Cqv /etc/init.d/ntpd
net-misc/openntpd-3.9_p1-r1
barcelona:~ # qlist -CIve openrc
sys-apps/openrc-0.2.5
barcelona:~ # /etc/init.d/ntpd start
 * Starting ntpd ...                                                      [ ok
]
barcelona:~ # /etc/init.d/ntpd stop
 * Stopping ntpd ...                                                      [ ok
]
barcelona:~ # ps -A | grep ntp
barcelona:~ #

barcelona:~ # emerge --info
Portage 2.1.5.6 (default/linux/amd64/2008.0/desktop, gcc-4.3.2, glibc-2.7-r2,
2.6.26.6 x86_64)
=================================================================
System uname: 2.6.26.6 x86_64 Quad-Core AMD Opteron(tm) Processor 2354
Timestamp of tree: Thu, 09 Oct 2008 06:00:01 +0000
ccache version 2.4 [disabled]
app-shells/bash:     3.2_p39
dev-java/java-config: 1.3.7, 2.1.6-r1
dev-lang/python:     2.5.2-r8
dev-util/ccache:     2.4-r8
sys-apps/baselayout: 2.0.0
sys-apps/openrc:     0.3.0-r1
sys-apps/sandbox:    1.2.18.1-r3
sys-devel/autoconf:  2.13, 2.63
sys-devel/automake:  1.5, 1.7.9-r1, 1.8.5-r3, 1.9.6-r2, 1.10.1-r1
sys-devel/binutils:  2.18-r3
sys-devel/gcc-config: 1.4.0-r4
sys-devel/libtool:   2.2.6a
virtual/os-headers:  2.6.25-r4
ACCEPT_KEYWORDS="amd64 ~amd64"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-march=barcelona -mtune=barcelona -O2 -finline-functions -pipe"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/kde/3.5/env /usr/kde/3.5/share/config
/usr/kde/3.5/shutdown /usr/share/config"
CONFIG_PROTECT_MASK="/etc/X11/Sessions /etc/X11/app-defaults /etc/X11/xinit
/etc/bash_completion.d /etc/bonobo-activation /etc/ca-certificates.conf
/etc/cups /etc/dbus-1 /etc/env.d /etc/env.d/java/ /etc/eselect/compiler
/etc/fish /etc/fonts /etc/fonts/fonts.conf /etc/foomatic /etc/gconf
/etc/gentoo-release /etc/gimp /etc/gnome-vfs-2.0 /etc/gtk /etc/gtk-2.0
/etc/hotplug /etc/hotplug.d /etc/imlib /etc/init.d /etc/iproute2 /etc/nas
/etc/ntop /etc/pam.d /etc/pango /etc/profile.d /etc/revdep-rebuild /etc/sasl2
/etc/sgml /etc/ssl /etc/ssmtp /etc/t1lib /etc/terminfo /etc/udev/rules.d
/etc/xinetd.d /etc/xml /etc/zsh"
CXXFLAGS="-march=barcelona -mtune=barcelona -O2 -finline-functions -pipe"
DISTDIR="/usr/portage/distfiles"
EMERGE_DEFAULT_OPTS="--alphabetical --with-bdeps=y"
FEATURES="collision-protect distlocks parallel-fetch sandbox sfperms strict
unmerge-orphans userfetch userpriv usersandbox"
GENTOO_MIRRORS="ftp://linux.rz.ruhr-uni-bochum.de/gentoo-mirror
ftp://ftp.tu-clausthal.de/pub/linux/gentoo http://distfiles.gentoo.org
http://www.ibiblio.org/pub/Linux/distributions/gentoo"
LDFLAGS="-Wl,-O1,--hash-style=gnu,--sort-common,--as-needed"
LINGUAS="de"
MAKEOPTS="-j7"
PKGDIR="/usr/portage/packages"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --compress
--force --whole-file --delete --stats --timeout=180 --exclude=/distfiles
--exclude=/local --exclude=/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY="/usr/local/portage"
SYNC="rsync://192.168.0.254/gentoo-portage"
USE="3dnow 3dnowext X a52 aac acpi alsa amd64 amd64codecs asf avi berkdb
branding bzip2 cairo cdparanoia cdr cli cracklib crypt cups dvd dvdr dvdread
emboss encode fam ffmpeg flac gdbm gif gnutls gpg gtk gtk2 iconv idn
imagemagick imlib isdnlog jpeg kde kdehiddenvisibility lame libwww mad midi
mikmod mjpeg mmx mmxext mp3 mpeg mudflap multilib ncurses nls nptl nptlonly
nsplugin ogg oggvorbis opengl pam pcre pdf png pppd qt3 qt3support quicktime
readline reflection sdl session silc slang smp spell spl sse sse2 ssl
startup-notification svg sysfs tga theora threads tiff truetype usb v4l2 vcd
vorbis x264 xcomposite xml xml2 xorg xprint xulrunner xv xvid zlib"
ALSA_CARDS="emu10k1 hda-intel" ALSA_PCM_PLUGINS="adpcm alaw asym copy dmix
dshare dsnoop empty extplug file hooks iec958 ioplug ladspa lfloat linear meter
mmap_emul mulaw multi null plug rate route share shm softvol" ELIBC="glibc"
INPUT_DEVICES="keyboard mouse" KERNEL="linux" LINGUAS="de" USERLAND="GNU"
VIDEO_CARDS="nv nvidia"
Unset:  CPPFLAGS, CTARGET, FFLAGS, INSTALL_MASK, LANG, LC_ALL,
PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS

Created an attachment (id=167726) [details]
openntpd.rc.diff

When I tweak openntpd's init script like this, I can stop the service with
openrc-0.3.0-r1 again.

I have the same issue, I'll test the patch asap.
Btw, is "--user root" necessary?

(In reply to comment #3)
> Btw, is "--user root" necessary?
> 

When you look into process list, you will find two processes of ntpd:

# ps aux | grep -v grep | grep ntp
root     17680  0.0  0.0  17920   520 ?        Ss   14:48   0:00 ntpd
ntp      17681  0.0  0.0  17920  1000 ?        S    14:48   0:00 ntpd

I'd like to have the process owned by root stopped as this seems to be the
"master" process. But it seems like start-stop-daemon would stop both processes
without "--user root" as well.

Created an attachment (id=167802) [details]
Improves the init script for OpenRC

Lars's patch works for me.

However I propose this patch instead, which uses some newer OpenRC features,
thus both improving and simplifying the script.

(From update of attachment 167726 [details])
Indeed, your patch looks better.

(From update of attachment 167726 [details])
dont obsolete this one just yet.

(From update of attachment 167802 [details])
good idea. however openrc is not stable yet, so i need a solution which works
with both openrc and the older baselayout...
thanks. this can be reconsidered, when openrc goes stable...

fixed in cvs. thanks

davide: could i ask you to open a new bug report with your patch attached? i'm
still interested...

(In reply to comment #9)
> davide: could i ask you to open a new bug report with your patch attached? i'm
> still interested...
> 

Of course! Thank you for quickly taking care of this issue.