Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 240648 - media-gfx/gimp-2.6.6: gimptool-2.0 does not respect DESTDIR (dcraw with USE=gimp - ACCESS DENIED)
Summary: media-gfx/gimp-2.6.6: gimptool-2.0 does not respect DESTDIR (dcraw with USE=g...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Hanno Böck
URL: http://bugzilla.gnome.org/show_bug.cg...
Whiteboard:
Keywords:
: 250862 267119 302996 306177 (view as bug list)
Depends on:
Blocks:
 
Reported: 2008-10-09 07:44 UTC by Kerie
Modified: 2010-02-24 10:37 UTC (History)
37 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
gimp-2.6.4-alt-gimptool.patch (gimp-2.6.4-alt-gimptool.patch,1.57 KB, patch)
2009-04-11 12:24 UTC, Peter Volkov (RETIRED)
Details | Diff
patch to make rawphoto plugin install into sandbox (dcraw-sandbox-violation.patch,764 bytes, patch)
2009-09-02 17:10 UTC, Edward Middleton
Details | Diff
use pkg-config instead of gimptool (dcraw-8.86.ebuild.use-pkg-config.patch,1.52 KB, patch)
2009-11-29 05:21 UTC, Andrew Savchenko
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kerie 2008-10-09 07:44:56 UTC
emerge of media-gfx/dcraw-8.86 fails when the gimp use flag is enabled. This also occurs with dcraw-8.73. The version of GIMP that I'm using: media-gfx/gimp-2.6.0

Log of the merge:
>>> Unpacking source...
>>> Unpacking dcraw-8.86.tar.bz2 to /var/tmp/portage/media-gfx/dcraw-8.86/work
>>> Source unpacked.
>>> Compiling source in /var/tmp/portage/media-gfx/dcraw-8.86/work/dcraw-8.86 ...
x86_64-pc-linux-gnu-gcc -march=athlon64 -O2 -pipe -fomit-frame-pointer -g -Wall -I/usr/include -DNO_LCMS -Wl,-O1 -o dcraw dcraw.c -lm -ljpeg
x86_64-pc-linux-gnu-gcc -march=athlon64 -O2 -pipe -fomit-frame-pointer -g -Wall -I/usr/include -DNO_LCMS -Wl,-O1 -o dcparse parse.c
x86_64-pc-linux-gnu-gcc -march=athlon64 -O2 -pipe -fomit-frame-pointer -I/usr/include/gimp-2.0 -I/usr/include/gtk-2.0 -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/lib64/gtk-2.0/include -I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/pango-1.0 -I/usr/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/libpng12   -o rawphoto rawphoto.c -Wl,-O1 -lgimpui-2.0 -lgimpwidgets-2.0 -lgimpmodule-2.0 -lgimp-2.0 -lgimpmath-2.0 -lgimpconfig-2.0 -lgimpcolor-2.0 -lgimpbase-2.0 -lgtk-x11-2.0 -lgdk-x11-2.0 -latk-1.0 -lgio-2.0 -lpangoft2-1.0 -lgdk_pixbuf-2.0 -lpangocairo-1.0 -lcairo -lpango-1.0 -lfreetype -lz -lfontconfig -lgobject-2.0 -lgmodule-2.0 -lglib-2.0   
>>> Source compiled.
>>> Test phase [not enabled]: media-gfx/dcraw-8.86

>>> Install dcraw-8.86 into /var/tmp/portage/media-gfx/dcraw-8.86/image/ category media-gfx
/usr/bin/install -d /var/tmp/portage/media-gfx/dcraw-8.86/image//usr/bin
/usr/bin/install dcraw /var/tmp/portage/media-gfx/dcraw-8.86/image//usr/bin
/usr/bin/install dcparse /var/tmp/portage/media-gfx/dcraw-8.86/image//usr/bin
/usr/bin/install -d /var/tmp/portage/media-gfx/dcraw-8.86/image//usr/share/man/man1
/usr/bin/install dcraw.1 /var/tmp/portage/media-gfx/dcraw-8.86/image//usr/share/man/man1
cp rawphoto /usr/lib/gimp/2.0/plug-ins
ACCESS DENIED  open_wr:   /usr/lib/gimp/2.0/plug-ins/rawphoto
cp: cannot create regular file `/usr/lib/gimp/2.0/plug-ins/rawphoto': Permission denied
>>> Completed installing dcraw-8.86 into /var/tmp/portage/media-gfx/dcraw-8.86/image/

--------------------------- ACCESS VIOLATION SUMMARY ---------------------------
LOG FILE = "/var/log/sandbox/sandbox-3505.log"

open_wr:   /usr/lib/gimp/2.0/plug-ins/rawphoto (symlink to /usr/lib64/gimp/2.0/plug-ins/rawphoto)
--------------------------------------------------------------------------------


Reproducible: Always

Steps to Reproduce:
1. emerge dcraw with gimp useflag enabled
2.
3.

Actual Results:  
Fails to install

Expected Results:  
Install dcraw
Comment 1 Tony iVanz 2008-10-09 14:29:05 UTC
I have the same error, but on ~x86 profile.
gimp-2.6.0
dcraw-8.86 and 8.73

As a workaroud, emerged dcraw without gimp plugin
Comment 2 Simon Zilliken 2008-10-10 09:43:21 UTC
Changelog excerpt:

2007-11-16  Tor Lillqvist  <tml@novell.com>

    Use the gimptool program on Unix, too, instead of the gimptool
    script.

    * configure.in
    * Makefile.am: Drop gimptool script and gimptool-win32.c(.in)

    * tools/gimptool.c
    * tools/Makefile.am: Move gimptool-win32.c.in here and call it
    just gimptool.c. Build and install on all platforms.

Looks like the support for the DESTDIR prefix is lost because of this move, so one has to find another way for installing the plugin, maybe something like proposed here: http://bugs.gentoo.org/show_bug.cgi?id=222635
Comment 3 David Davidson 2008-10-22 01:30:28 UTC
While trying to install dcraw-8.86 on ~amd64

[ebuild  N    ] media-gfx/dcraw-8.86  USE="gimp jpeg lcms" 0 kB

I encountered a similar error:

cp rawphoto /usr/lib/gimp/2.0/plug-ins                                                     
ACCESS DENIED  open_wr:   /usr/lib/gimp/2.0/plug-ins/rawphoto                              
cp: cannot create regular file `/usr/lib/gimp/2.0/plug-ins/rawphoto': Permission denied

Manually applying the patch from the bug mentioned above, in comment 2, allowed dcraw to install properly.
Comment 4 Martin von Gagern 2008-12-26 13:04:14 UTC
(In reply to comment #2)
> maybe something like proposed in bug #222635

Confirmed to work for me on ~x86, media-gfx/gimp-2.6.3, media-gfx/dcraw-8.86.
Thnaks for the pointer to that patch! Can we please get it included?
Comment 5 Benjamin Bannier 2009-03-21 19:03:44 UTC
Hi,

Ping. The problem is still there and the patch from http://bugs.gentoo.org/attachment.cgi?id=153539 works for me in 8.86, too.

Please include the patch.

Cheers,

Benjamin
Comment 6 Rutger van Bergen 2009-03-26 00:20:38 UTC
Issue and patch confirmed for dcraw-8.86 on ~amd64.

Thanks in advance for including it! ;p
Comment 7 Gordon Malm (RETIRED) gentoo-dev 2009-04-04 13:31:15 UTC
*** Bug 250862 has been marked as a duplicate of this bug. ***
Comment 8 Gordon Malm (RETIRED) gentoo-dev 2009-04-04 13:33:15 UTC
Hit this today as well.  ebuild change from bug 222635 works.
Comment 9 Paolo Pedroni 2009-04-06 06:55:55 UTC
Same problem. Proposed solution works for me as well. Please include the patch in your ebuild.
Comment 10 Peter Volkov (RETIRED) gentoo-dev 2009-04-11 12:24:07 UTC
Created attachment 187978 [details, diff]
gimp-2.6.4-alt-gimptool.patch

This is bug in gimp, not in dcraw. Hanno, please, apply the following patch or tell me to go ahead: http://sisyphus.ru/srpm/Sisyphus/gimp/patches/0

With this patch dcraw works.
Comment 11 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2009-04-13 20:15:16 UTC
Confirming bug with gimp-2.6.6, dcraw-0.86 on amd64.
Comment 12 Peter Volkov (RETIRED) gentoo-dev 2009-04-27 19:19:39 UTC
This bug was reported upstream but it occurs that patch have to be rewritten without regressions, upstream mentioned:

http://bugzilla.gnome.org/show_bug.cgi?id=578695

If somebody has time to do it earlier then me, please, go ahead and help us to fix this problem.
Comment 13 Neil 2009-05-11 06:23:02 UTC
Just encountered this too on ~x86 / gimp-2.6.6 / dcraw-8.86.


Does the patch need to be applied to gimp or dcraw?
Comment 14 Ed Tomlinson 2009-05-14 22:21:40 UTC
Happening here too.

---
>>> Install dcraw-8.86 into /var/tmp/portage/media-gfx/dcraw-8.86/image/ category media-gfx
make -j4 DESTDIR=/var/tmp/portage/media-gfx/dcraw-8.86/image/ install                      
/usr/bin/install -d /var/tmp/portage/media-gfx/dcraw-8.86/image//usr/bin                   
/usr/bin/install dcraw /var/tmp/portage/media-gfx/dcraw-8.86/image//usr/bin                
/usr/bin/install dcparse /var/tmp/portage/media-gfx/dcraw-8.86/image//usr/bin              
/usr/bin/install -d /var/tmp/portage/media-gfx/dcraw-8.86/image//usr/share/man/man1        
/usr/bin/install dcraw.1 /var/tmp/portage/media-gfx/dcraw-8.86/image//usr/share/man/man1   
cp rawphoto /usr/lib/gimp/2.0/plug-ins                                                     
ACCESS DENIED  open_wr:      /usr/lib/gimp/2.0/plug-ins/rawphoto                           
cp: cannot create regular file `/usr/lib/gimp/2.0/plug-ins/rawphoto': Permission denied    
>>> Completed installing dcraw-8.86 into /var/tmp/portage/media-gfx/dcraw-8.86/image/      

--------------------------- ACCESS VIOLATION SUMMARY ---------------------------
LOG FILE "/var/log/sandbox/sandbox-24952.log"                                   

VERSION 1.0
FORMAT: F - Function called
FORMAT: S - Access Status  
FORMAT: P - Path as passed to function
FORMAT: A - Absolute Path (not canonical)
FORMAT: R - Canonical Path               
FORMAT: C - Command Line                 

F: open_wr
S: deny   
P: /usr/lib/gimp/2.0/plug-ins/rawphoto
A: /usr/lib/gimp/2.0/plug-ins/rawphoto
R: /usr/lib64/gimp/2.0/plug-ins/rawphoto
C: cp rawphoto /usr/lib/gimp/2.0/plug-ins 
--------------------------------------------------------------------------------

>>> Failed to emerge media-gfx/dcraw-8.86, Log file:

>>>  '/var/tmp/portage/media-gfx/dcraw-8.86/temp/build.log'
grover ed # emerge --info                                  
Portage 2.1.6.13 (default/linux/amd64/2008.0, gcc-4.3.3, glibc-2.9_p20081201-r2, 2.6.30-rc5-crc x86_64)
=================================================================                                      
System uname: Linux-2.6.30-rc5-crc-x86_64-AMD_Phenom-tm-_8450_Triple-Core_Processor-with-glibc2.2.5    
Timestamp of tree: Wed, 13 May 2009 21:45:01 +0000                                                     
app-shells/bash:     3.2_p39                                                                           
dev-java/java-config: 2.1.7                                                                            
dev-lang/python:     2.5.4-r2                                                                          
dev-python/pycrypto: 2.0.1-r8                                                                          
dev-util/cmake:      2.6.4                                                                             
sys-apps/baselayout: 1.12.11.1
sys-apps/sandbox:    1.9
sys-devel/autoconf:  2.13, 2.63
sys-devel/automake:  1.5, 1.7.9-r1, 1.8.5-r3, 1.9.6-r2, 1.10.2
sys-devel/binutils:  2.18-r3
sys-devel/gcc-config: 1.4.0-r4
sys-devel/libtool:   1.5.26
virtual/os-headers:  2.6.29
ACCEPT_KEYWORDS="amd64"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-march=amdfam10 -O2 -pipe"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/kde/4.2/env /usr/kde/4.2/share/config /usr/kde/4.2/shutdown /usr/lib64/fax /usr/share/config /var/spool/fax/etc"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/env.d /etc/env.d/java/ /etc/fonts/fonts.conf /etc/gconf /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo /etc/texmf/language.dat.d /etc/texmf/language.def.d /etc/texmf/updmap.d /etc/texmf/web2c /etc/udev/rules.d"
CXXFLAGS="-march=amdfam10 -O2 -pipe"
DISTDIR="/usr/portage/distfiles"
FEATURES="distlocks fixpackages parallel-fetch protect-owned sandbox sfperms strict unmerge-orphans userfetch"
GENTOO_MIRRORS="http://gentoo.osuosl.org/ http://adelie.polymtl.ca/ ftp://cs.ubishops.ca/pub/gentoo ftp://distro.ibiblio.org/pub/linux/distributions/gentoo/ http://www.gtlib.gatech.edu/pub/gentoo ftp://mirror.iawnet.sandia.gov/pub/gentoo/ "
LC_ALL="en_CA.utf8"
LDFLAGS="-Wl,-O1"
MAKEOPTS="-j4"
PKGDIR="/usr/portage/packages"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --compress --force --whole-file --delete --stats --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY="/usr/portage/local/layman/sunrise /usr/portage/local/layman/x11 /usr/portage/local/layman/ruby /usr/local/portage"
SYNC="rsync://rsync.ca.gentoo.org/gentoo-portage"
USE="3dnow 3dnowext X aac acl alsa amd64 arts artswrappersuid asf berkdb bluetooth bzip2 cdr cli cracklib crypt cups divx4linux doc dri dts dvd dvdread enable-jingle fam fat ffmpeg firefox gdbm gnome gpm gstreamer gtk iconv ipv6 isdnlog jpeg kde kdeprefix mad matroska midi mmx mmxext mudflap multilib ncurses nls nptl nptlonly ntfs ogg opengl openmp pam pcre pdf perl png pppd python qt qt-copy quicktime readline reflection reiser4 reiserfs ruby samba sdl session smb spl sse sse2 ssl sysfs tcpd theora threads truetype unicode vorbis wavpack wma xcb xcomposite xfs xinerama xorg xv xvid xvmc zlib" ALSA_CARDS="intel8x0" ALSA_PCM_PLUGINS="adpcm alaw asym copy dmix dshare dsnoop empty extplug file hooks iec958 ioplug ladspa lfloat linear meter mmap_emul mulaw multi null plug rate route share shm softvol" APACHE2_MODULES="actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" ELIBC="glibc" INPUT_DEVICES="keyboard mouse" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" USERLAND="GNU" VIDEO_CARDS="ati radeon radeonhd vesa fbdev"
Unset:  CPPFLAGS, CTARGET, EMERGE_DEFAULT_OPTS, FFLAGS, INSTALL_MASK, LANG, LINGUAS, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS
---
Comment 15 Johannes Bauer 2009-06-12 14:15:19 UTC
So it's been 8 months (!) since this bug was reported and it still is there in its very original form. This is truly pathetic and embarassing. Who is maintaining this package - anyone?

I won't send in my bug report because it is absolutely identical to all the other ones and appearently they're all ignored anyways.

Regards,
Johannes
Comment 16 Neil 2009-06-12 14:26:02 UTC
(In reply to comment #15)
> So it's been 8 months (!) since this bug was reported and it still is there in
> its very original form. This is truly pathetic and embarassing. Who is
> maintaining this package - anyone?
> 
You can find this out by looking in the ebuild's ChangeLog itself and you will find details of people who have modified the ebuild recently.  If its really rankling then perhaps contact them directly.

> I won't send in my bug report because it is absolutely identical to all the
> other ones and appearently they're all ignored anyways.
> 

There are a LOT of bugs reported for ALL ebuilds and only so many developers.  If you'd like to see this change then I politely suggest you start making efforts to become a developer yourself.  You can find out how by reading http://www.gentoo.org/proj/en/devrel/handbook/handbook.xml
Comment 17 Johannes Bauer 2009-06-26 14:15:45 UTC
(In reply to comment #16)

> > Who is
> > maintaining this package - anyone?
>
> You can find this out by looking in the ebuild's ChangeLog itself and you will
> find details of people who have modified the ebuild recently.  If its really
> rankling then perhaps contact them directly.

Actually the question was more rhetoric than not. By looking into the ChangeLog I might see who maintained it in the past - currently obviously *nobody* is maintaining it. The ChangeLog indicates that Wolfram Schlich <wschlich@gentoo.org> is more or less responsible for the packet - he is in the CCs, so he might follow this discussion. No need to mail him directly.

> > I won't send in my bug report because it is absolutely identical to all the
> > other ones and appearently they're all ignored anyways.
> 
> There are a LOT of bugs reported for ALL ebuilds and only so many developers. 
> If you'd like to see this change then I politely suggest you start making
> efforts to become a developer yourself.  You can find out how by reading
> http://www.gentoo.org/proj/en/devrel/handbook/handbook.xml

This is not something I would need to fix, because others have already done so in the past (see patch from March, which fixes the problem). The only thing keeping the patch from inclusion into mainline? Nobody knows.

Seriously, I know there are many bugs in need of fixing. But having a bug lying around for nine months for which a viable patch exists - that's just odd.

Kind regards,
Johannes

Comment 18 Hanno Böck gentoo-dev 2009-06-26 14:21:53 UTC
You can read the upstream bugreport to see why I won't apply the patch - I don't wanna add patches to an ebuild that are not suitable for upstream. Proper fix would be reworking the dcraw-ebuild to use pkg-config and deprecate the usage of gimptool.
Comment 19 Edward Middleton 2009-09-02 17:10:49 UTC
Created attachment 202979 [details, diff]
patch to make rawphoto plugin install into sandbox

This dcraw ebuild patch makes the rawphoto plugin install into the sandbox directory.  I tried using pkg-config to compile the plugin and determine the install path but that involves placing gimp plugin compile logic into the ebuild.  Instead I have just use gimptool to determine the plugin directory and install with doexe
Comment 20 Leonid Volnitsky 2009-10-14 05:52:14 UTC
So, my understanding of the problems is:

Good patch is not accepted because it is not politically correct. 
Politically correct way is to rewrite 
GIMP ebuild so, that it will provide pkg-config info for plugins.  
Comment 21 Beetle B. 2009-11-11 15:18:47 UTC
Yet another person with the same problem...
Comment 22 Andrew Savchenko gentoo-dev 2009-11-29 05:21:03 UTC
Created attachment 211499 [details, diff]
use pkg-config instead of gimptool

This patch makes use of pkg-config instead of gimptool.

Patch is rather trivial, I can't get it why so much time was spend on useless flame.
Comment 23 Frédéric COIFFIER 2009-12-08 14:02:48 UTC
This latest patch works fine in my case.

Is it possible to update the dcraw ebuild with this patch ? Or have we to create a new report and to close this one ?
Comment 24 Peter Volkov (RETIRED) gentoo-dev 2009-12-13 08:55:11 UTC
*** Bug 267119 has been marked as a duplicate of this bug. ***
Comment 25 Peter Volkov (RETIRED) gentoo-dev 2009-12-13 08:57:48 UTC
Fixed in dcraw-8.98. Since gimptool is actually deprecated (see upstream bug report) I've followed Andrew's solution and used pkg-config. BTW, Andrew note, that libraries should follow object files on the command line, since in other case linker will drop them (with LDFLAGS=--as-needed) and build fails.
Comment 26 Peter Volkov (RETIRED) gentoo-dev 2010-02-10 07:05:13 UTC
*** Bug 302996 has been marked as a duplicate of this bug. ***
Comment 27 Samuli Suominen (RETIRED) gentoo-dev 2010-02-24 10:37:50 UTC
*** Bug 306177 has been marked as a duplicate of this bug. ***