Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 239248 - ati-drivers: patch for upcoming 2.6.27
Summary: ati-drivers: patch for upcoming 2.6.27
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: Jeffrey Gardner (RETIRED)
URL:
Whiteboard:
Keywords:
: 241872 (view as bug list)
Depends on:
Blocks:
 
Reported: 2008-10-01 15:08 UTC by Rodolphe Rocca
Modified: 2009-01-14 22:57 UTC (History)
5 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Patch for 8.532 to compile against 2.6.27 (ati-drivers-2.6.27.patch,2.87 KB, patch)
2008-10-01 15:10 UTC, Rodolphe Rocca
Details | Diff
ati-drivers-8.542.ebuild (ati-drivers-8.542.ebuild,14.61 KB, text/plain)
2008-10-17 11:59 UTC, Rodolphe Rocca
Details
Patch for 8.542 to compile against 2.6.27 (ati-drivers-2.6.27.patch,2.86 KB, patch)
2008-10-17 12:01 UTC, Rodolphe Rocca
Details | Diff
Patch for the ebuild to support versions > 2.6.27 (i.e. 2.6.28) (ati-drivers-2.6.28.patch,410 bytes, patch)
2008-12-26 07:46 UTC, Daniel Nelson
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Rodolphe Rocca 2008-10-01 15:08:27 UTC
Hi guys, I found out a patch at phoronix (http://www.phoronix.com/forums/showthread.php?t=12546) that enables installation of ati-drivers-8.532 on 2.6.27*.

It is simple and works quite well at home (core2quad, Radeon4870, compiz w/ AIGLX).

I'm not sure if such a bug entry for a not-yet released kernel is acceptable for you. Feel free to close if it's not.

Reproducible: Always

Steps to Reproduce:
1.Emerge =sys-kernel/git-sources-2.6.27*
2.Emerge =x11-ati-drivers/ati-drivers-8.532
3.

Actual Results:  
Emerge fails.

Expected Results:  
Emerge succeeds.
Comment 1 Rodolphe Rocca 2008-10-01 15:10:38 UTC
Created attachment 166904 [details, diff]
Patch for 8.532 to compile against 2.6.27
Comment 2 Jan Boros 2008-10-10 18:40:45 UTC
please, how to modify ebuild to use this patch?

thanks
Comment 3 Volker Hemmann 2008-10-12 08:43:28 UTC
I would edit the patch too:


--- common/lib/modules/fglrx/build_mod/firegl_public.c.orig     2008-09-19 10:57:09.000000000 +0200
+++ common/lib/modules/fglrx/build_mod/firegl_public.c  2008-09-19 10:55:57.000000000 +0200

instead of:
--- firegl_public.c.orig	2008-09-19 10:57:09.000000000 +0200
+++ firegl_public.c	2008-09-19 10:55:57.000000000 +0200

and the ebuild something like this:
if  kernel_is 2 6 27; then
                 epatch "${FILESDIR}"/ati-drivers-2.6.27.patch
fi
(ebuild part untested)
Comment 4 Paul de Vrieze (RETIRED) gentoo-dev 2008-10-14 18:52:36 UTC
*** Bug 241872 has been marked as a duplicate of this bug. ***
Comment 5 nm (RETIRED) gentoo-dev 2008-10-16 21:53:07 UTC
Looks like 8.10 is out and fixes the 2.6.27 compilation issues, see the driver release page (for amd64):

http://ati.amd.com/support/drivers/linux64/linux64-radeon.html

Given this, is the patch still necessary?
Comment 6 nm (RETIRED) gentoo-dev 2008-10-16 22:28:53 UTC
(In reply to comment #5)
> Looks like 8.10 is out and fixes the 2.6.27 compilation issues, see the driver
> release page (for amd64):
> 
> http://ati.amd.com/support/drivers/linux64/linux64-radeon.html
> 
> Given this, is the patch still necessary?

Also, I tried bumping the driver to the newest version in my local overlay, and it installs & runs just fine.No patches needed except for what's already in FILESDIR. So except for xorg-server 1.5 support, it seems ATI has done a decent job with fixing 8.10 so that it works with .27 kernels.
Comment 7 Jeffrey Gardner (RETIRED) gentoo-dev 2008-10-17 03:43:02 UTC
8.542 is now in portage.
Enjoy!

Comment 8 Rodolphe Rocca 2008-10-17 07:05:25 UTC
Nop, the patch is still necessary for 2.6.27, otherwise I get :

/var/tmp/paludis/x11-drivers-ati-drivers-8.542/work/common/lib/modules/fglrx/build_mod/2.6.x/firegl_public.c:2352: error: too many arguments to function 'on_each_cpu'

Notice that it is the 8.543 driver (that only canonical owns at this time) that is compatible with kernel-2.6.27/xorg-1.5.

Please reopen the issue.
Comment 9 Thomas S. Howard 2008-10-17 11:33:31 UTC
(In reply to comment #8)
> Nop, the patch is still necessary for 2.6.27, otherwise I get :

Same here, but with portage (warnings snipped):

/var/tmp/portage/x11-drivers/ati-drivers-8.542/work/common/lib/modules/fglrx/build_mod/2.6.x/firegl_public.c: In function 'KCL_flush_tlb_onepage':
/var/tmp/portage/x11-drivers/ati-drivers-8.542/work/common/lib/modules/fglrx/build_mod/2.6.x/firegl_public.c:2352: error: too many arguments to function 'on_each_cpu'

/var/tmp/portage/x11-drivers/ati-drivers-8.542/work/common/lib/modules/fglrx/build_mod/2.6.x/firegl_public.c: In function '__ke_flush_cache':
/var/tmp/portage/x11-drivers/ati-drivers-8.542/work/common/lib/modules/fglrx/build_mod/2.6.x/firegl_public.c:2791: error: too many arguments to function 'smp_call_function'

/var/tmp/portage/x11-drivers/ati-drivers-8.542/work/common/lib/modules/fglrx/build_mod/2.6.x/firegl_public.c: In function 'KCL_enable_pat':
/var/tmp/portage/x11-drivers/ati-drivers-8.542/work/common/lib/modules/fglrx/build_mod/2.6.x/firegl_public.c:4063: error: too many arguments to function 'smp_call_function'

/var/tmp/portage/x11-drivers/ati-drivers-8.542/work/common/lib/modules/fglrx/build_mod/2.6.x/firegl_public.c: In function 'KCL_disable_pat':
/var/tmp/portage/x11-drivers/ati-drivers-8.542/work/common/lib/modules/fglrx/build_mod/2.6.x/firegl_public.c:4082: error: too many arguments to function 'smp_call_function'
Comment 10 Rodolphe Rocca 2008-10-17 11:59:57 UTC
Created attachment 168786 [details]
ati-drivers-8.542.ebuild

ati-drivers-8.542.ebuild
Comment 11 Rodolphe Rocca 2008-10-17 12:01:06 UTC
Created attachment 168788 [details, diff]
Patch for 8.542 to compile against 2.6.27
Comment 12 Rodolphe Rocca 2008-10-17 12:05:07 UTC
I just updated the patch and submitted ebuild for 8.542.
Thanx volker for your comments. 
The ebuild diff, compared to the official ebuild is :

@@ -167,6 +169,10 @@
 	ln -s "${ARCH_DIR}"/lib/modules/fglrx/build_mod/libfglrx_ip.a.GCC$(gcc-major-version) \
 		|| die "symlinking precompiled core failed"
 
+	if kernel_is 2 6 27; then
+		epatch "${FILESDIR}/ati-drivers-2.6.27.patch"
+	fi
+
 	convert_to_m 2.6.x/Makefile || die "convert_to_m failed"
Comment 13 Rodolphe Rocca 2008-10-17 14:08:58 UTC
Could someone with the right permission reopen this bug please ?
Comment 14 Rodolphe Rocca 2008-10-17 14:09:50 UTC
It seems I can do it myself :-) 

Reopened.
Comment 15 Jeffrey Gardner (RETIRED) gentoo-dev 2008-10-17 15:26:04 UTC
Just committed to CVS.
Thanks everyone!
Comment 16 Rodolphe Rocca 2008-10-25 13:13:40 UTC
Now in portage tree. Closing the bug.
Comment 17 Daniel Nelson 2008-12-26 07:46:19 UTC
Created attachment 176407 [details, diff]
Patch for the ebuild to support versions > 2.6.27 (i.e. 2.6.28)
Comment 18 Sean 2009-01-14 22:51:50 UTC
Is there any reason this patch should not be applied to previous versions of ati-drivers? All versions of ati-drivers > 8.532 seem to have removed support for mobility radeon 9600 M10(specifically chip id 0x4e50), so all versions of ati-drivers newer than 8.542 will not work for me(compiles, but will not load). This patch is not applied to versions < 8.542 in portage, which makes installation very difficult for anyone with a radeon with chipid 0x4e50 using kernel 2.6.27.(had the same problem in 2.6.26 as well)
Comment 19 Sean 2009-01-14 22:57:05 UTC
(In reply to comment #18)
> "ati-drivers newer than 8.542 will not work for me"

What I meant to say was "ati-drivers 8.542 or newer will not work for me"