Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 237897 - gnome-extra/gnome-screensaver-2.22.2.ebuild has incorrect test for concurrent xscreensaver install
Summary: gnome-extra/gnome-screensaver-2.22.2.ebuild has incorrect test for concurrent...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: Low minor (vote)
Assignee: Saleem Abdulrasool (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-09-17 06:11 UTC by Kundai Midzi
Modified: 2008-11-30 12:10 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
Patch sets correct xscreensaver package atom for has_version test in postinst (gnome-screensaver-2.22.2.ebuild.patch,524 bytes, patch)
2008-09-17 06:18 UTC, Kundai Midzi 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kundai Midzi 2008-09-17 06:11:51 UTC 
gnome-extra/gnome-screensaver/gnome-screensaver-2.22.2.ebuild postint tests for any version of x11-misc/xscreensaver and suggests setting -gnome USE flag if it is installed; However, the gnome USE flag does not exist for >=x11-misc/xscreensaver-4.22-r2, as it was removed in x11-misc/xscreensaver-4.22-r2.

Reproduce by running:

$> ebuild /usr/portage gnome-extra/gnome-screensaver/gnome-screensaver-2.22.2.ebuild clean && ebuild /usr/portage gnome-extra/gnome-screensaver/gnome-screensaver-2.22.2.ebuild postinst
Comment 1 Kundai Midzi 2008-09-17 06:18:27 UTC 
Created attachment 165615 [details, diff]
Patch sets correct xscreensaver package atom for has_version test in postinst

patch assumes a revision bump.
Comment 2 Gilles Dartiguelongue (RETIRED) gentoo-dev 2008-09-27 10:11:38 UTC 
why was the version check added in the first place ?
Comment 3 Gilles Dartiguelongue (RETIRED) gentoo-dev 2008-11-08 23:33:48 UTC 
I'm confused, the patch you propose is what's already in the tree. Do you mean the opposite ?
Comment 4 Pacho Ramos gentoo-dev 2008-11-10 12:24:58 UTC 
Maybe it's referring to the oposite because xscreensaver-5* don't have gnome USE flag (also note that there are no 4 version for xscreensaver in current tree)
Comment 5 Kundai Midzi 2008-11-15 19:27:05 UTC 
(In reply to comment #4)
> Maybe it's referring to the oposite because xscreensaver-5* don't have gnome
> USE flag (also note that there are no 4 version for xscreensaver in current
> tree)
> 

Yes that was my intention.
Comment 6 Gilles Dartiguelongue (RETIRED) gentoo-dev 2008-11-30 12:10:22 UTC 
fixed in all versions still in tree.