Bugzilla Bug 237071

/etc/init.d/puppet and /etc/init.d/puppetmaster do not start their applications
if there are other, possibly unrelated ruby processes running on the system.

This is due to the --exec switch in start-stop-daemon: start-stop-daemons only
checks if there are *any* processes running with /usr/bin/ruby in their command
line.

Reproducible: Always

Steps to Reproduce:
# normal daemon start
stampy ~ # /etc/init.d/puppetmaster start
 * Starting puppetmaster ...                                              [ ok
]
stampy ~ # /etc/init.d/puppetmaster stop
 * Stopping puppetmaster ...                                              [ ok
]
# now we start a completely unrelated ruby process in the background
stampy ~ # ruby -e 'sleep 60' &
[1] 15637
# the initscript now fails
stampy ~ # /etc/init.d/puppetmaster start
 * Starting puppetmaster ...
/usr/bin/ruby already running.
 * Failed to start puppetmaster                                           [ !!
]
stampy ~ # wait
[1]+  Done                    ruby -e 'sleep 60'
# but when the other ruby process is gone, the initscript does its job again
stampy ~ # /etc/init.d/puppetmaster start
 * Starting puppetmaster ...              



stampy ~ # emerge --info
Portage 2.1.4.4 (default/linux/amd64/2008.0, gcc-4.1.2, glibc-2.6.1-r0,
2.6.25-gentoo-r7 x86_64)
=================================================================
System uname: 2.6.25-gentoo-r7 x86_64 Intel(R) Xeon(R) CPU E5410 @ 2.33GHz
Timestamp of tree: Mon, 08 Sep 2008 01:17:01 +0000
ccache version 2.4 [enabled]
app-shells/bash:     3.2_p33
dev-lang/python:     2.4.4-r14, 2.5.2-r6
dev-python/pycrypto: 2.0.1-r6
dev-util/ccache:     2.4-r7
sys-apps/baselayout: 1.12.11.1
sys-apps/sandbox:    1.2.18.1-r2
sys-devel/autoconf:  2.61-r2
sys-devel/automake:  1.9.6-r2, 1.10.1
sys-devel/binutils:  2.18-r3
sys-devel/gcc-config: 1.4.0-r4
sys-devel/libtool:   1.5.26
virtual/os-headers:  2.6.23-r3
ACCEPT_KEYWORDS="amd64"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-O2 -pipe -march=nocona"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/env.d /etc/gconf
/etc/revdep-rebuild /etc/terminfo /etc/udev/rules.d"
CXXFLAGS="-O2 -pipe -march=nocona"
DISTDIR="/usr/portage/distfiles"
FEATURES="buildpkg ccache distlocks metadata-transfer sandbox sfperms strict
unmerge-orphans userfetch usersandbox"
GENTOO_MIRRORS="ftp://de-mirror.org/distro/gentoo
ftp://ftp.wh2.tu-dresden.de/pub/mirrors/gentoo
http://mirrors.sec.informatik.tu-darmstadt.de/gentoo/ "
LDFLAGS="-Wl,-O1"
MAKEOPTS="-j5"
PKGDIR="/usr/portage/packages"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --compress
--force --whole-file --delete --stats --timeout=180 --exclude=/distfiles
--exclude=/local --exclude=/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
SYNC="rsync://rsync.europe.gentoo.org/gentoo-portage"
USE="acl acpi amd64 apache2 bash-completion berkdb bzip2 cli cracklib crypt
cups device-mapper dri fortran gdbm gnutls gpm iconv ipv6 isdnlog jpeg ldap
logrotate midi mmx mudflap multilib ncurses nls nptl nptlonly openmp pam pcre
perl png pppd python readline reflection session spl sqlite3 sse sse2 ssl
symlink sysfs tcpd unicode vim-syntax xorg zlib" ALSA_CARDS="ali5451 als4000
atiixp atiixp-modem bt87x ca0106 cmipci emu10k1x ens1370 ens1371 es1938 es1968
fm801 hda-intel intel8x0 intel8x0m maestro3 trident usb-audio via82xx
via82xx-modem ymfpci" ALSA_PCM_PLUGINS="adpcm alaw asym copy dmix dshare dsnoop
empty extplug file hooks iec958 ioplug ladspa lfloat linear meter mmap_emul
mulaw multi null plug rate route share shm softvol" APACHE2_MODULES="actions
alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file
authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user
autoindex cache dav dav_fs dav_lock deflate dir disk_cache env expires
ext_filter file_cache filter headers include info log_config logio mem_cache
mime mime_magic negotiation rewrite setenvif speling status unique_id userdir
usertrack vhost_alias" ELIBC="glibc" INPUT_DEVICES="keyboard mouse evdev"
KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001
mtxorb ncurses text" USERLAND="GNU" VIDEO_CARDS="fbdev glint i810 mach64 mga
neomagic nv r128 radeon savage sis tdfx trident vesa vga via vmware voodoo"
Unset:  CPPFLAGS, CTARGET, EMERGE_DEFAULT_OPTS, FFLAGS, INSTALL_MASK, LANG,
LC_ALL, LINGUAS, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS,
PORTAGE_RSYNC_EXTRA_OPTS, PORTDIR_OVERLAY

Could you please confirm that this is about app-admin/puppet-0.24.4 or both
versions currently in the tree?

We tested with 0.24.5, but looking at the ebuilds I assume 0.24.4 is affected
as well.

fixed in cvs puppet-0.24.5-r1. thanks.

Use the original patch I submitted upstream - it worked just fine on both
baselayout-1 and 2. #218071