Bugzilla Bug 236886

When I am playing a song in bashee, if I use the stop media key on my laptop,
then right click the notification area icon for banshee, I get the following
error and banshee crashes.

-- BEGIN CRASH --
An unhandled exception was thrown: Object reference not set to an instance of
an object

  at
Banshee.NotificationArea.NotificationAreaService.OnNotificationAreaPopupMenuEvent
(System.Object o, Gtk.PopupMenuArgs args) [0x00000] 
  at Banshee.NotificationArea.X11NotificationAreaBox.OnPopupMenuEvent ()
[0x00000] 
  at Banshee.NotificationArea.X11NotificationAreaBox.OnButtonPressEvent
(System.Object o, Gtk.ButtonPressEventArgs args) [0x00000] 
  at Gtk.Widget.ButtonPressEventSignalCallback (IntPtr arg0, IntPtr arg1,
IntPtr gch) [0x00000] 
  at (wrapper native-to-managed) Gtk.Widget:ButtonPressEventSignalCallback
(intptr,intptr,intptr)
  at (wrapper managed-to-native) Gtk.Application:gtk_main ()
  at Gtk.Application.Run () [0x00000] 
  at Banshee.Gui.GtkBaseClient.Run () [0x00000] 
  at Banshee.Gui.GtkBaseClient.Startup () [0x00000] 
  at Hyena.Gui.CleanRoomStartup.Startup (Hyena.Gui.StartupInvocationHandler
startup) [0x00000] 

.NET Version: 2.0.50727.42
OS Version: Unix 2.6.25.7

Assembly Version Information:

System.Configuration (2.0.0.0)
System.Web (2.0.0.0)
taglib-sharp (2.0.3.0)
Banshee.FileSystemQueue (1.2.1.17403)
Mono.Media (1.2.1.17392)
Banshee.PlayQueue (1.2.1.17406)
Banshee.CoverArt (1.2.1.17402)
Banshee.MultimediaKeys (1.2.1.17405)
Lastfm (1.2.1.17393)
Banshee.Lastfm (1.2.1.17404)
Banshee.NotificationArea (1.2.1.17406)
Banshee.Bookmarks (1.2.1.17401)
Banshee.AudioCd (1.2.1.17401)
pango-sharp (2.10.0.0)
Mono.Cairo (2.0.0.0)
Banshee.Widgets (1.2.1.17396)
Banshee.Hal (1.2.1.17408)
Banshee.Unix (1.2.1.17409)
Banshee.GStreamer (1.2.1.17409)
gconf-sharp (2.16.0.0)
Banshee.Gnome (1.2.1.17408)
Banshee.NowPlaying (1.2.1.17406)
System.Transactions (2.0.0.0)
System.Xml (2.0.0.0)
System.Data (2.0.0.0)
Mono.Data.SqliteClient (2.0.0.0)
Mono.Addins (0.3.0.0)
atk-sharp (2.10.0.0)
Hyena.Gui (1.2.1.17391)
Mono.Posix (2.0.0.0)
NDesk.DBus.Proxies (0.0.0.0)
NDesk.DBus.GLib (1.0.0.0)
NDesk.DBus (1.0.0.0)
gtk-sharp (2.10.0.0)
Hyena (1.2.1.17389)
System (2.0.0.0)
glib-sharp (2.10.0.0)
gdk-sharp (2.10.0.0)
Banshee.Core (1.2.1.17394)
Banshee.Services (1.2.1.17395)
Banshee.ThickClient (1.2.1.17397)
Nereid (1.2.1.17399)
mscorlib (2.0.0.0)

Platform Information: Linux 2.6.25-gentoo-r7 i686 GenuineIntel GNU/Linux

Disribution Information:

[/etc/gentoo-release]
Gentoo Base System release 1.12.11.1
-- END CRASH --

This has happened on all three versions of banshee I have tried:  1.2.0, 1.2.1,
and 1.2.1-r1.  I have an hp dv8000 laptop where Fn+10 is supposed to be a Stop
media key.  I used GNOME keyboard shortcuts perfs to set the Stop Playback key
to 0xa4 (Fn+F10).

Here's my banshee configuration:
dan@zman0900 ~ $ eix banshee
[I] media-sound/banshee
     Available versions:  0.12.1 (~)0.13.1 (~)1.0.0-r1 (~)1.2.1 (~)1.2.1-r1
{+aac +boo +encode +flac +mad +podcast +vorbis aac boo daap debug doc encode
flac ipod mad mtp njb test vorbis}
     Installed versions:  1.2.1-r1(09:40:35 AM 09/06/2008)(aac boo encode flac
ipod mad podcast vorbis -daap -debug -doc -mtp -test)
     Homepage:            http://banshee-project.org
     Description:         Import, organize, play, and share your music using a
simple and powerful interface.



Reproducible: Always

Steps to Reproduce:
1.Start banshee
2.Play song(s) for any amount of time.
3.Press Stop key on keyboard.
4.Right click Banshee icon in notification area.

Actual Results:  
Banshee crashes giving the error listed above.

Expected Results:  
Menu pops up giving various options as usual.  

Here's my emerge --info:
dan@zman0900 ~ $ emerge --info
Portage 2.1.4.4 (default/linux/x86/2008.0, gcc-4.1.2, glibc-2.6.1-r0,
2.6.25-gentoo-r7 i686)
=================================================================
System uname: 2.6.25-gentoo-r7 i686 Genuine Intel(R) CPU T2500 @ 2.00GHz
Timestamp of tree: Sat, 06 Sep 2008 12:45:01 +0000
app-shells/bash:     3.2_p33
dev-java/java-config: 1.3.7, 2.1.6
dev-lang/python:     2.5.2-r6
sys-apps/baselayout: 1.12.11.1
sys-apps/sandbox:    1.2.18.1-r2
sys-devel/autoconf:  2.13, 2.61-r2
sys-devel/automake:  1.4_p6, 1.5, 1.7.9-r1, 1.8.5-r3, 1.9.6-r2, 1.10.1
sys-devel/binutils:  2.18-r3
sys-devel/gcc-config: 1.4.0-r4
sys-devel/libtool:   1.5.26
virtual/os-headers:  2.6.23-r3
ACCEPT_KEYWORDS="x86"
CBUILD="i686-pc-linux-gnu"
CFLAGS="-O2 -march=prescott -pipe"
CHOST="i686-pc-linux-gnu"
CONFIG_PROTECT="/etc /var/lib/hsqldb"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/env.d /etc/env.d/java/
/etc/fonts/fonts.conf /etc/gconf /etc/php/apache2-php5/ext-active/
/etc/php/cgi-php5/ext-active/ /etc/php/cli-php5/ext-active/ /etc/revdep-rebuild
/etc/terminfo /etc/texmf/web2c /etc/udev/rules.d"
CXXFLAGS="-O2 -march=prescott -pipe"
DISTDIR="/usr/portage/distfiles"
FEATURES="distlocks metadata-transfer sandbox sfperms strict unmerge-orphans
userfetch"
GENTOO_MIRRORS="http://mirrors.cs.wmich.edu/gentoo
http://gentoo.cites.uiuc.edu/pub/gentoo/ http://distfiles.gentoo.org
http://www.ibiblio.org/pub/Linux/distributions/gentoo"
LANG="en_US.UTF-8"
LC_ALL="en_US.UTF-8"
LDFLAGS="-Wl,-O1"
LINGUAS="en en_US"
MAKEOPTS="-j3"
PKGDIR="/usr/portage/packages"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --compress
--force --whole-file --delete --stats --timeout=180 --exclude=/distfiles
--exclude=/local --exclude=/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY="/usr/portage/local/layman/sunrise /usr/local/portage"
SYNC="rsync://rsync.namerica.gentoo.org/gentoo-portage"
USE="7zip X Xaw3d a52 aac aalib acl acpi aim alsa ao audiofile avahi
bash-completion bcmath berkdb branding bzip2 cairo caps cdda cddb cdparanoia
cdr cli cracklib crypt css cups curl curlwrappers cvs dbus djvu dri dts dv dvb
dvd dvdr dvdread encode exif ffmpeg fftw flac fltk fontconfig foomaticdb
fortran ftp fuse galago gd gdbm geoip ggi gif gimp glut gmp gnome gnome-keyring
gnutls gphoto2 gpm gstreamer gtk gtkhtml guile hal hddtemp iconv icq idn
ieee1394 imagemagick imap imlib ipod ipv6 isdnlog java java6 javascript
joystick jpeg jpeg2k kerberos lame lapack lcms libcaca libnotify libsamplerate
libwww lm_sensors lua lzo mad matroska mhash midi mikmod mime mmap mmx mmxext
mng modplug mp3 mpeg mpi mplayer msn mudflap musepack musicbrainz nautilus
ncurses nls nntp nptl nptlonly nvidia ocamlopt odbc offensive ogg openal opengl
openmp oscar pam pcmcia pcntl pcre pdf perl php png posix ppds pppd python
quicktime raw rdesktop readline reflection rss ruby samba sasl scanner sdl
session sharedext shorten slang slp sndfile sockets sox speex spell spl sqlite
sqlite3 sse sse2 sse3 ssl startup-notification subversion svg sysfs syslog
sysvipc taglib tcl tcpd theora threads tidy tiff timidity tk tokenizer truetype
unicode usb v4l v4l2 vcd videos vnc vorbis wavpack wifi win32codecs wmf
wxwindows x264 x86 xcb xcomposite xine xinerama xinetd xml xmlrpc xorg xosd xpm
xscreensaver xsl xulrunner xv xvid xvmc yahoo zeroconf zlib"
ALSA_CARDS="hda-intel usb-audio" ALSA_PCM_PLUGINS="adpcm alaw asym copy dmix
dshare dsnoop empty extplug file hooks iec958 ioplug ladspa lfloat linear meter
mmap_emul mulaw multi null plug rate route share shm softvol"
APACHE2_MODULES="actions alias auth_basic authn_alias authn_anon authn_dbm
authn_default authn_file authz_dbm authz_default authz_groupfile authz_host
authz_owner authz_user autoindex cache dav dav_fs dav_lock deflate dir
disk_cache env expires ext_filter file_cache filter headers include info
log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling
status unique_id userdir usertrack vhost_alias" CAMERAS="*" ELIBC="glibc"
INPUT_DEVICES="keyboard mouse evdev joystick synaptics" KERNEL="linux"
LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses
text" LINGUAS="en en_US" USERLAND="GNU" VIDEO_CARDS="nvidia vesa"
Unset:  CPPFLAGS, CTARGET, EMERGE_DEFAULT_OPTS, FFLAGS, INSTALL_MASK,
PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS

A very similar issue has already been reported upstream :
http://bugzilla.gnome.org/show_bug.cgi?id=550777

Created an attachment (id=164954) [details]
Upstream patch

I recompiled banshee 1.2.1-r1 using the attached upstream patch and it solved
my problem with no noticeable side effects.  If you look at the upstream bug
report, the patch appears to have solved the problem for one other person as
well.  I would like to recommend that this be included in portage for banshee
1.2.1-r2.

This bug has been marked fixed by upstream and they plan to include the patch
in the next release.

Thank you for reporting this problem.
+*banshee-1.2.1-r2 (10 Sep 2008)
+
+  10 Sep 2008; Peter Alfredsen <loki_val@gentoo.org>
+  files/banshee-1.2.1-libmtp-0.3.0-API.patch,
+  +files/banshee-1.2.1-notification-crash.patch, -banshee-1.2.1-r1.ebuild,
+  +banshee-1.2.1-r2.ebuild:
+  Probably definitely fix bug #233869, thanks again to Salah Colonya. Also
+  fix bug #236886 with fix from upstream.
+