Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 236858 - sys-apps/util-linux-2.14 installs non-POSIX /etc/init.d/crypto-loop
Summary: sys-apps/util-linux-2.14 installs non-POSIX /etc/init.d/crypto-loop
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Gentoo's Team for Core System packages
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-09-06 12:57 UTC by Martin Väth
Modified: 2008-10-26 03:16 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
Patch to make crypto-loop.initd POSIX compliant (crypto-loop.initd.patch,1.56 KB, patch)
2008-09-06 13:05 UTC, Martin Väth
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Väth 2008-09-06 12:57:23 UTC
As the summary says, file/crypto-loop.initd uses several bashisms which make
the file fail if e.g. /bin/sh is a symlink to dash.
As usual, only small syntax changes are necessary to make it POSIX compliant.
I attach a patch.
Comment 1 Martin Väth 2008-09-06 13:05:23 UTC
Created attachment 164719 [details, diff]
Patch to make crypto-loop.initd POSIX compliant

The patch in addition removes the redundant call of "ls" which might have
produced a confusing error message if no /dev/loop[0-9] exists
(and a new line was inserted to deal with that case).
Comment 2 Wormo (RETIRED) gentoo-dev 2008-09-06 17:59:50 UTC
Thanks for the cleanup patch, assigning to maintainers
Comment 3 SpanKY gentoo-dev 2008-10-26 03:16:36 UTC
changing [[ -n ${var} ]] to [ -n ${var} ] is broken

ive fixed things up and committed it, thanks

http://sources.gentoo.org/sys-apps/util-linux/files/crypto-loop.initd?r1=1.3&r2=1.4