Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 236341 - PyQt4 has automagic dependencies
Summary: PyQt4 has automagic dependencies
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Qt Bug Alias
URL:
Whiteboard: [qting-edge]
Keywords: InOverlay
Depends on:
Blocks:
 
Reported: 2008-09-01 10:54 UTC by Alessandro Guido
Modified: 2009-06-01 16:28 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Alessandro Guido 2008-09-01 10:54:37 UTC
PyQt4 build system compiles the bindings only for qt modules found on the system. This is a problem with the new split Qt ebuilds.

Either the PyQt4 ebuild should be updated to depend on all qt modules or it should have use-flag-based dependencies and a way to disable binding generation for not enabled modules.

Reproducible: Always
Comment 1 Martin Väth 2008-11-28 10:02:56 UTC
Just to confirm that this really is a "bug": I got hit by this recently when
I exported PyQt4 as a binary package, and revdep-rebuild immediately wants to
rebuild it (which is not reasonable on a system where you install binary
packages e.g. due to lack of processor power).

As a user's note, I would prefer if it would not depend on all of qt,
since this would destroy the main advantage of having qt split ebuilds from
the user's perspective: you do not have to install everything.

The use-flag-based dependencies (I hope that modifying the build-system
correspondingly is not too hard) have with EAPI-2 and use-flag dependencies
the additional advantage that also only those libraries of PyQt4 are built
which are really used by something.
Of course, also this advantage is ohly from the user's perspective:
Fixing all PyQt-dependencies in the tree (perhaps even with the need to
equip further packages with the corresponding useflags since the corresponding
USE-dependency itself might be optional) is probably a lot of work.
Comment 2 Ben de Groot (RETIRED) gentoo-dev 2009-05-14 20:42:11 UTC
Several useflags have been added in the meantime, so I consider this fixed. If anything is missing, please let us know.
Comment 3 Davide Pesavento (RETIRED) gentoo-dev 2009-05-15 07:54:17 UTC
No, this is not fixed.

"Automagic" means, for example, that if I do have x11-libs/qt-webkit installed and try to emerge PyQt4 with USE="-webkit", the PyQt4.QtWebKit module is built anyhow.

I'll work on this issue if you don't mind. I already have an idea to fix the automagic deps, I just don't have enough time to implement and test it at the moment. Meanwhile, could you please reopen the bug?
Comment 4 Markos Chandras (RETIRED) gentoo-dev 2009-05-15 09:59:30 UTC
Yeah this bug is still valid. The solutions is either to DEPEND PyQt4 to all qt modules or patch the build system. I ll work on that as well

Reopening
Comment 5 Davide Pesavento (RETIRED) gentoo-dev 2009-05-24 15:24:40 UTC
I've just committed PyQt4-4.4.4-r5 to the qting-edge overlay. src_configure() has been rewritten to fix this bug and more USE flags have been added. More testing of the various USE flags combinations is appreciated, though it should work quite fine.

In order not to break existing packages, I kept all the modules (except QtAssistant and phonon) enabled by default. It would be great to have proper USE-deps on all the packages that depend on PyQt4, and then we can safely remove IUSE defaults.
Comment 6 Markos Chandras (RETIRED) gentoo-dev 2009-05-24 19:36:45 UTC
(In reply to comment #5)
> I've just committed PyQt4-4.4.4-r5 to the qting-edge overlay. src_configure()
> has been rewritten to fix this bug and more USE flags have been added. More
> testing of the various USE flags combinations is appreciated, though it should
> work quite fine.
> 
> In order not to break existing packages, I kept all the modules (except
> QtAssistant and phonon) enabled by default. It would be great to have proper
> USE-deps on all the packages that depend on PyQt4, and then we can safely
> remove IUSE defaults.
> 

Very good work Davide :)
I have just one objection. "phonon" use flag should be disabled by default cause this flag will pull qt-phonon which will lead to many blockages on kde4 system. I dont think there is any need to make "phonon" default :)

Could you please port this fix on the rest of PyQt4 snapshots? 


Apart from that, your ebuild looks pretty good. We ll keep testing it on the overlay and I will push it on tree within the next 7 days


Thanks a lot
Comment 7 Davide Pesavento (RETIRED) gentoo-dev 2009-05-24 20:29:50 UTC
(In reply to comment #6)
> (In reply to comment #5)
> > I've just committed PyQt4-4.4.4-r5 to the qting-edge overlay. src_configure()
> > has been rewritten to fix this bug and more USE flags have been added. More
> > testing of the various USE flags combinations is appreciated, though it should
> > work quite fine.
> > 
> > In order not to break existing packages, I kept all the modules (except
> > QtAssistant and phonon) enabled by default. It would be great to have proper
> > USE-deps on all the packages that depend on PyQt4, and then we can safely
> > remove IUSE defaults.
> > 
> 
> Very good work Davide :)
> I have just one objection. "phonon" use flag should be disabled by default
> cause this flag will pull qt-phonon which will lead to many blockages on kde4
> system. I dont think there is any need to make "phonon" default :)
> 

Yeah, that was my intention, but apparently I forgot to do the change before committing :P
I'll fix that.

> Could you please port this fix on the rest of PyQt4 snapshots? 

Will do.
Comment 8 Davide Pesavento (RETIRED) gentoo-dev 2009-05-24 22:25:17 UTC
All done.
Comment 9 Markos Chandras (RETIRED) gentoo-dev 2009-05-27 17:28:33 UTC
This comment is more like a ping to all @qt and @python people to test -r5 ebuild for 3 more days. Then I ll commit it to the tree 
Comment 10 Davide Pesavento (RETIRED) gentoo-dev 2009-05-27 19:47:55 UTC
It would be great if we had a tracker bug to track all the reverse dependencies that need to be fixed, i.e. switched to the right USE-deps.
Comment 11 Markos Chandras (RETIRED) gentoo-dev 2009-06-01 16:28:48 UTC
+*PyQt4-4.4.4-r5 (01 Jun 2009)
+
+  01 Jun 2009; Markos Chandras <hwoarang@gentoo.org> +PyQt4-4.4.4-r5.ebuild,
+  files/configure.py.patch, metadata.xml:
+  Fixed automagic dependency issue. ( bug 236341 ). Fixed rpath issues ( bug
+  235819 , bug 271870 ). Thanks to Davide Pesavento <davidepesa@gmail.com>
+  for
+  the ebuilds and the rpath patch.
+

On tree

Thank you all

I ll try to open that tracker for migration ( maybe not today cause I dont have time ). If someone else wants to do it please feel free :)