Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 235995 - net-analyzer/nmap-4.68: forced serial make (-j1) is not needed
Summary: net-analyzer/nmap-4.68: forced serial make (-j1) is not needed
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Michal Januszewski (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-08-28 10:30 UTC by Diego Elio Pettenò (RETIRED)
Modified: 2008-08-30 21:46 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
failure build log (net-analyzer:nmap-4.68:20080829-183549.log,43.11 KB, text/plain)
2008-08-29 18:39 UTC, Mr. Bones. (RETIRED)
Details
A patch to fix concurrent nmap make. (nmap-4.68-concurrent-make-fix.patch,454 bytes, patch)
2008-08-29 23:06 UTC, Michal Januszewski (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Diego Elio Pettenò (RETIRED) gentoo-dev 2008-08-28 10:30:43 UTC
The ebuild in summary is currently forcing users to use serial make (-j1, no extra job tasks). This seems not to be needed.

The ebuild was modified to use -j8 on a truly 8-core SMP system and didn't fail the build, you should either check if it's a particular USE flag to cause the problem, or drop -j1 and leave the user to decide how many jobs to use.

I want to remember you that with modern multicore systems, forcing serial make is going to waste a lot of time and resources for users..

Thanks,
Diego
Comment 1 Michal Januszewski (RETIRED) gentoo-dev 2008-08-28 21:38:39 UTC
Fixed, thanks for checking and reporting this :)
Comment 2 Mr. Bones. (RETIRED) gentoo-dev 2008-08-29 18:32:26 UTC
With +gtk +ssl -lua the parallel build fails, yet succeeds with -j1.
Comment 3 Diego Elio Pettenò (RETIRED) gentoo-dev 2008-08-29 18:38:39 UTC
Can you get me the build log of the failure? I really cannot reproduce neither at -j8 nor -j10, I'll gladly make sure it's safe if you can show me how it fails.
Comment 4 Mr. Bones. (RETIRED) gentoo-dev 2008-08-29 18:39:40 UTC
Created attachment 164073 [details]
failure build log

And here it is, failing...
Comment 5 Doug Goldstein (RETIRED) gentoo-dev 2008-08-29 18:45:30 UTC
USE="ssl -gtk -lua" works
USE="gtk ssl -lua" fails on one box and works on another

The autoheader step from eautoreconf fails as well.
Comment 6 Diego Elio Pettenò (RETIRED) gentoo-dev 2008-08-29 19:11:13 UTC
Nice, I can't see about reproducing this with any setting right now, but I do see in the Makefile the race condition.

I tried any -j from 2 to 16 and it builds just fine, both disk-backed and tmpfs.

Which make version are you using? And how many jobs?
Comment 7 Mr. Bones. (RETIRED) gentoo-dev 2008-08-29 19:15:53 UTC
$ make --version
GNU Make 3.81

MAKEOPTS="-j3"
Comment 8 Michal Januszewski (RETIRED) gentoo-dev 2008-08-29 23:06:50 UTC
Created attachment 164099 [details, diff]
A patch to fix concurrent nmap make.

Could you please check whether this patch fixes the build problem for you?
Comment 9 Mr. Bones. (RETIRED) gentoo-dev 2008-08-30 00:05:32 UTC
seems to work.
Comment 10 Michal Januszewski (RETIRED) gentoo-dev 2008-08-30 21:46:49 UTC
Closing then.  Please reopen in case the patch doesn't fix the problem.